Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34.3k
tools: set normalizeTD text default to empty string#51543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nodejs-github-bot merged 1 commit into nodejs:main from marco-ippolito:fix/update-root-certsJan 24, 2024
Merged
tools: set normalizeTD text default to empty string #51543
nodejs-github-bot merged 1 commit into nodejs:main from marco-ippolito:fix/update-root-certsJan 24, 2024
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
marco-ippolito commented Jan 22, 2024 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
Collaborator
nodejs-github-bot commented Jan 22, 2024
Review requested:
|
richardlau approved these changes Jan 22, 2024
lpinca approved these changes Jan 22, 2024
anonrig approved these changes Jan 23, 2024
Collaborator
nodejs-github-bot commented Jan 24, 2024
Commit Queue failed- Loading data for nodejs/node/pull/51543 ✔ Done loading data for nodejs/node/pull/51543 ----------------------------------- PR info ------------------------------------ Title tools: set normalizeTD text default to empty string (#51543) Author Marco Ippolito (@marco-ippolito) Branch marco-ippolito:fix/update-root-certs -> nodejs:main Labels tools, author ready Commits 1 - tools: set normalizeTD text default to empty string Committers 1 - marco-ippolito PR-URL: https://github.com/nodejs/node/pull/51543 Fixes: https://github.com/nodejs/node/actions/runs/7597757959/job/20692964963 Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca Reviewed-By: Yagiz Nizipli ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/51543 Fixes: https://github.com/nodejs/node/actions/runs/7597757959/job/20692964963 Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca Reviewed-By: Yagiz Nizipli -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 22 Jan 2024 17:26:56 GMT ✔ Approvals: 3 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/51543#pullrequestreview-1837150227 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/51543#pullrequestreview-1837297960 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/51543#pullrequestreview-1837700370 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 51543 From https://github.com/nodejs/node * branch refs/pull/51543/merge -> FETCH_HEAD ✔ Fetched commits as 925a464cb8ba..f1867bca157f -------------------------------------------------------------------------------- [main b19e19e8b3] tools: set normalizeTD text default to empty string Author: marco-ippolito Date: Mon Jan 22 18:25:23 2024 +0100 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied -------------------------------------------------------------------------------- --------------------------------- New Message ---------------------------------- tools: set normalizeTD text default to empty stringhttps://github.com/nodejs/node/actions/runs/7643958471 |
Collaborator
nodejs-github-bot commented Jan 24, 2024
Landed in d8e385a |
Member
richardlau commented Jan 24, 2024
marco-ippolito added a commit to marco-ippolito/node that referenced this pull request Feb 2, 2024
PR-URL: nodejs#51543 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Feb 9, 2024
PR-URL: nodejs#51543 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
targos pushed a commit that referenced this pull request Feb 15, 2024
PR-URL: #51543 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
marco-ippolito added a commit to marco-ippolito/node that referenced this pull request Feb 19, 2024
PR-URL: nodejs#51543 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #51543 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #51543 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author readyPRs that have at least one approval, no pending requests for changes, and a CI started. toolsIssues and PRs related to the tools directory.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/nodejs/node/actions/runs/7597757959/job/20692964963
Undefined value crashed the action