http2: close idle connections when allowHTTP1 is true#51569
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Jan 26, 2024
Review requested:
|
nodejs-github-bot added http2 
Member
marco-ippolito commented Jan 26, 2024
Can you write a test please? |
ContributorAuthor
xsbchen commented Jan 26, 2024
sure, will do later |
ContributorAuthor
xsbchen commented Jan 31, 2024
@marco-ippolito test case added, plz help to review |
Qard approved these changes Jan 31, 2024
marco-ippolito approved these changes Jan 31, 2024
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Jan 31, 2024
Collaborator
nodejs-github-bot commented Feb 1, 2024
mcollina added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Feb 1, 2024
Landed in d1114c4 |
rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Feb 9, 2024
Fixes: nodejs#51493 PR-URL: nodejs#51569 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
targos pushed a commit that referenced this pull request Feb 15, 2024
Fixes: #51493 PR-URL: #51569 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Feb 19, 2024
Fixes: nodejs#51493 PR-URL: nodejs#51569 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
Fixes: #51493 PR-URL: #51569 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
Fixes: #51493 PR-URL: #51569 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
Merged
eugene1g added a commit to eugene1g/node-http2-timer that referenced this pull request Apr 26, 2024
When Http2SecureServer is configured with `allowHTTP1=true`, it calls `setupConnectionsTracking` to start monitoring for idle HTTP1 connections. `setupConnectionsTracking` expects to have `this.connectionsCheckingInterval` property defined, but it does not exist on `Http2SecureServer`. This `undefined` value is passed to `setInterval`, which results in `checkConnections` being called on every tick, creating significant additional load on the server CPU. The fix is to define `this.connectionsCheckingInterval` on the Http2SecureServer instance. Refs: nodejs#51569
nodejs-github-bot pushed a commit that referenced this pull request Apr 28, 2024
When Http2SecureServer is configured with `allowHTTP1=true`, it calls `setupConnectionsTracking` to start monitoring for idle HTTP1 connections. `setupConnectionsTracking` expects to have `this.connectionsCheckingInterval` property defined, but it does not exist on `Http2SecureServer`. This `undefined` value is passed to `setInterval`, which results in `checkConnections` being called on every tick, creating significant additional load on the server CPU. The fix is to define `this.connectionsCheckingInterval` on the Http2SecureServer instance. Refs: #51569 PR-URL: #52713 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
aduh95 pushed a commit that referenced this pull request Apr 29, 2024
When Http2SecureServer is configured with `allowHTTP1=true`, it calls `setupConnectionsTracking` to start monitoring for idle HTTP1 connections. `setupConnectionsTracking` expects to have `this.connectionsCheckingInterval` property defined, but it does not exist on `Http2SecureServer`. This `undefined` value is passed to `setInterval`, which results in `checkConnections` being called on every tick, creating significant additional load on the server CPU. The fix is to define `this.connectionsCheckingInterval` on the Http2SecureServer instance. Refs: #51569 PR-URL: #52713 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
marco-ippolito pushed a commit that referenced this pull request May 2, 2024
When Http2SecureServer is configured with `allowHTTP1=true`, it calls `setupConnectionsTracking` to start monitoring for idle HTTP1 connections. `setupConnectionsTracking` expects to have `this.connectionsCheckingInterval` property defined, but it does not exist on `Http2SecureServer`. This `undefined` value is passed to `setInterval`, which results in `checkConnections` being called on every tick, creating significant additional load on the server CPU. The fix is to define `this.connectionsCheckingInterval` on the Http2SecureServer instance. Refs: #51569 PR-URL: #52713 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
marco-ippolito pushed a commit that referenced this pull request May 3, 2024
When Http2SecureServer is configured with `allowHTTP1=true`, it calls `setupConnectionsTracking` to start monitoring for idle HTTP1 connections. `setupConnectionsTracking` expects to have `this.connectionsCheckingInterval` property defined, but it does not exist on `Http2SecureServer`. This `undefined` value is passed to `setInterval`, which results in `checkConnections` being called on every tick, creating significant additional load on the server CPU. The fix is to define `this.connectionsCheckingInterval` on the Http2SecureServer instance. Refs: #51569 PR-URL: #52713 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
sophoniie pushed a commit to sophoniie/node that referenced this pull request Jun 20, 2024
When Http2SecureServer is configured with `allowHTTP1=true`, it calls `setupConnectionsTracking` to start monitoring for idle HTTP1 connections. `setupConnectionsTracking` expects to have `this.connectionsCheckingInterval` property defined, but it does not exist on `Http2SecureServer`. This `undefined` value is passed to `setInterval`, which results in `checkConnections` being called on every tick, creating significant additional load on the server CPU. The fix is to define `this.connectionsCheckingInterval` on the Http2SecureServer instance. Refs: nodejs#51569 PR-URL: nodejs#52713 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
When Http2SecureServer is configured with `allowHTTP1=true`, it calls `setupConnectionsTracking` to start monitoring for idle HTTP1 connections. `setupConnectionsTracking` expects to have `this.connectionsCheckingInterval` property defined, but it does not exist on `Http2SecureServer`. This `undefined` value is passed to `setInterval`, which results in `checkConnections` being called on every tick, creating significant additional load on the server CPU. The fix is to define `this.connectionsCheckingInterval` on the Http2SecureServer instance. Refs: nodejs#51569 PR-URL: nodejs#52713 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #51493