tools: disable automated libuv updates#51775
Merged
+12 −9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Feb 15, 2024
Review requested:
|
nodejs-github-bot added the meta 
RafaelGSSforce-pushed the disable-libuv-update branch from 6359c62 to 9f8e928Compare
| cat temp-output | ||
| tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true | ||
| rm temp-output | ||
| - id: libuv |
Member
There was a problem hiding this comment.
Can we just comment this out instead of removing, I assume we will want to add it back at some point?
Member
There was a problem hiding this comment.
The other question is if we could have the update apply a patch required to re-apply the changes?
MemberAuthor
There was a problem hiding this comment.
I don't know, technically we could, but we'll need to review it carefully all libuv automatic updates + resolve conflicts.
RafaelGSSforce-pushed the disable-libuv-update branch from 9f8e928 to a2fba64Compare
edsadr reviewed Feb 19, 2024
Uh oh!
There was an error while loading. Please reload this page.
Because the previous security release modified the bundled version of libuv, we cannot automatically update libuv without potentially undoing those changes.
RafaelGSSforce-pushed the disable-libuv-update branch from a2fba64 to 847748dCompare
MemberAuthor
RafaelGSS commented Feb 22, 2024
ping @nodejs/actions @nodejs/security-wg |
joyeecheung approved these changes Feb 23, 2024
marco-ippolito approved these changes Feb 23, 2024
RafaelGSS added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Feb 24, 2024
Landed in a492646 |
marco-ippolito pushed a commit that referenced this pull request Feb 26, 2024
Because the previous security release modified the bundled version of libuv, we cannot automatically update libuv without potentially undoing those changes. PR-URL: #51775 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Feb 26, 2024
Because the previous security release modified the bundled version of libuv, we cannot automatically update libuv without potentially undoing those changes. PR-URL: #51775 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Feb 27, 2024
Because the previous security release modified the bundled version of libuv, we cannot automatically update libuv without potentially undoing those changes. PR-URL: #51775 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
Because the previous security release modified the bundled version of libuv, we cannot automatically update libuv without potentially undoing those changes. PR-URL: #51775 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
Because the previous security release modified the bundled version of libuv, we cannot automatically update libuv without potentially undoing those changes. PR-URL: #51775 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
Merged
rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Mar 26, 2024
Because the previous security release modified the bundled version of libuv, we cannot automatically update libuv without potentially undoing those changes. PR-URL: nodejs#51775 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the previous security release modified the bundled version of libuv, we cannot automatically update libuv without potentially undoing those changes.
cc: @nodejs/security-wg