Revert "build: fix warning in cares under GN build"#51865
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Feb 24, 2024
Review requested:
|
nodejs-github-bot added cares 
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Feb 25, 2024
Collaborator
nodejs-github-bot commented Feb 25, 2024
lpincaforce-pushed the revert/f22802ceb89a branch from 2f66f1c to faedc96CompareThis reverts commit f22802c.
lpincaforce-pushed the revert/f22802ceb89a branch from faedc96 to 92156e8Comparegithub-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Feb 25, 2024
Collaborator
nodejs-github-bot commented Feb 25, 2024
H4ad approved these changes Feb 25, 2024
lpinca added the commit-queue nodejs-github-bot added commit-queue-failed Collaborator
nodejs-github-bot commented Mar 2, 2024
Commit Queue failed- Loading data for nodejs/node/pull/51865 ✔ Done loading data for nodejs/node/pull/51865 ----------------------------------- PR info ------------------------------------ Title Revert "build: fix warning in cares under GN build" (#51865) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch lpinca:revert/f22802ceb89a -> nodejs:main Labels cares, needs-ci, dependencies Commits 1 - Revert "build: fix warning in cares under GN build" Committers 1 - Luigi Pinca PR-URL: https://github.com/nodejs/node/pull/51865 Reviewed-By: Vinícius Lourenço Claro Cardoso ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/51865 Reviewed-By: Vinícius Lourenço Claro Cardoso -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 24 Feb 2024 19:24:30 GMT ✔ Approvals: 1 ✔ - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/51865#pullrequestreview-1899748051 ✘ This PR needs to wait 7 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-02-25T16:48:31Z: https://ci.nodejs.org/job/node-test-pull-request/57406/ - Querying data for job/node-test-pull-request/57406/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/8122507139 |
lpinca added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Mar 3, 2024
Landed in 3a456c6 |
targos pushed a commit that referenced this pull request Mar 7, 2024
This reverts commit f22802c. PR-URL: #51865 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
This reverts commit f22802c. PR-URL: #51865 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
This reverts commit f22802c. PR-URL: #51865 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Merged
rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Mar 26, 2024
This reverts commit f22802c. PR-URL: nodejs#51865 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #51846.