build: fix arm64 host cross-compilation in GN#51903
Closed
+27 −25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Feb 28, 2024
Review requested:
|
nodejs-github-bot added dependencies 
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Feb 28, 2024
targos approved these changes Feb 28, 2024
lpinca approved these changes Feb 28, 2024
Should use `current_cpu` instead of `target_cpu` in GN build files, otherwise the host build may use wrong configs when doing cross compilation.
zcbenzforce-pushed the fix-cross-compilation branch from 2af5430 to 6942d29Comparegithub-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Mar 5, 2024
Collaborator
nodejs-github-bot commented Mar 5, 2024
Collaborator
nodejs-github-bot commented Mar 5, 2024
Collaborator
nodejs-github-bot commented Mar 5, 2024
Collaborator
nodejs-github-bot commented Mar 5, 2024
zcbenz added commit-queue nodejs-github-bot added commit-queue-failed Collaborator
nodejs-github-bot commented Mar 6, 2024
Commit Queue failed- Loading data for nodejs/node/pull/51903 ✔ Done loading data for nodejs/node/pull/51903 ----------------------------------- PR info ------------------------------------ Title build: fix arm64 host cross-compilation in GN (#51903) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch zcbenz:fix-cross-compilation -> nodejs:main Labels openssl, needs-ci, dependencies, commit-queue-squash Commits 1 - build: fix arm64 host cross-compilation in GN Committers 1 - Cheng Zhao PR-URL: https://github.com/nodejs/node/pull/51903 Reviewed-By: Michaël Zasso Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/51903 Reviewed-By: Michaël Zasso Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - build: fix arm64 host cross-compilation in GN ℹ This PR was created on Wed, 28 Feb 2024 02:36:17 GMT ✔ Approvals: 2 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/51903#pullrequestreview-1905393209 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/51903#pullrequestreview-1907326923 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-03-05T23:36:22Z: https://ci.nodejs.org/job/node-test-pull-request/57601/ - Querying data for job/node-test-pull-request/57601/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/8165436949 |
zcbenz added a commit that referenced this pull request Mar 6, 2024
Should use `current_cpu` instead of `target_cpu` in GN build files, otherwise the host build may use wrong configs when doing cross compilation. PR-URL: #51903 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
ContributorAuthor
zcbenz commented Mar 6, 2024
Landed in 384fd17 |
targos pushed a commit that referenced this pull request Mar 7, 2024
Should use `current_cpu` instead of `target_cpu` in GN build files, otherwise the host build may use wrong configs when doing cross compilation. PR-URL: #51903 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
Should use `current_cpu` instead of `target_cpu` in GN build files, otherwise the host build may use wrong configs when doing cross compilation. PR-URL: #51903 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
Should use `current_cpu` instead of `target_cpu` in GN build files, otherwise the host build may use wrong configs when doing cross compilation. PR-URL: #51903 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Mar 26, 2024
Should use `current_cpu` instead of `target_cpu` in GN build files, otherwise the host build may use wrong configs when doing cross compilation. PR-URL: nodejs#51903 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
jcbhmr pushed a commit to jcbhmr/node that referenced this pull request May 15, 2024
Should use `current_cpu` instead of `target_cpu` in GN build files, otherwise the host build may use wrong configs when doing cross compilation. PR-URL: nodejs#51903 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should use
current_cpuinstead oftarget_cpuin GN build files, otherwise the host build may use wrong configs when doing cross-compilation.