Skip to content

Conversation

@JounQin
Copy link
Contributor

image

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. labels Feb 28, 2024
@MoLowMoLow added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 28, 2024
@github-actions
Copy link
Contributor

Fast-track has been requested by @MoLow. Please 👍 to approve.

@JounQinJounQin changed the title docs: remove redundant backquote which breaks sentencedoc: remove redundant backquote which breaks sentenceFeb 28, 2024
@JounQin
Copy link
ContributorAuthor

@MoLow Hi, sorry, my first commit message docs: does not match the CI linter, I've adapt the correct format with a force push.

@MoLowMoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 28, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 28, 2024
@nodejs-github-botnodejs-github-bot merged commit 2f01f02 into nodejs:mainFeb 28, 2024
@nodejs-github-bot
Copy link
Collaborator

Landed in 2f01f02

@JounQinJounQin deleted the patch-1 branch February 28, 2024 10:55
marco-ippolito pushed a commit that referenced this pull request Feb 29, 2024
PR-URL: #51904 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: theanarkh <[email protected]> Reviewed-By: Qingyu Deng <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Feb 29, 2024
PR-URL: #51904 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: theanarkh <[email protected]> Reviewed-By: Qingyu Deng <[email protected]>
@marco-ippolitomarco-ippolito mentioned this pull request Mar 1, 2024
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #51904 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: theanarkh <[email protected]> Reviewed-By: Qingyu Deng <[email protected]>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #51904 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: theanarkh <[email protected]> Reviewed-By: Qingyu Deng <[email protected]>
@richardlaurichardlau mentioned this pull request Mar 25, 2024
rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Mar 26, 2024
PR-URL: nodejs#51904 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: theanarkh <[email protected]> Reviewed-By: Qingyu Deng <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.esmIssues and PRs related to the ECMAScript Modules implementation.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@JounQin@nodejs-github-bot@JakobJingleheimer@Ayase-252@MoLow@theanarkh