Skip to content

[v20.x backport] deps: update icu to 74.2#51972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
targos wants to merge 5 commits into from
Closed

[v20.x backport] deps: update icu to 74.2 #51972

targos wants to merge 5 commits into from

Conversation

@targos
Copy link
Member

@targostargos commented Mar 5, 2024

  • deps: update icu to 74.1
  • deps: update timezone to 2023d
  • tools: fix update-icu.sh
  • deps: update icu to 74.2
  • deps: update timezone to 2024a

Refs: #51933

nodejs-github-botand others added 5 commits March 5, 2024 15:56
@nodejs-github-bot@targos
deps: update icu to 74.1
4d0c243
PR-URL: nodejs#50515 Reviewed-By: Steven R Loomis <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]>
@nodejs-github-bot@targos
deps: update timezone to 2023d
26f3b08
PR-URL: nodejs#51461 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@targos
tools: fix update-icu.sh
fe47c63
The name of the sources MD5 file has changed. Refs: https://github.com/unicode-org/icu/releases/tag/release-74-2 PR-URL: nodejs#51723 Refs: nodejs#51721 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Steven R Loomis <[email protected]> Reviewed-By: Richard Lau <[email protected]>
@targos
deps: update icu to 74.2
39f5430
Refs: https://github.com/unicode-org/icu/releases/tag/release-74-2 PR-URL: nodejs#51723 Refs: nodejs#51721 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Steven R Loomis <[email protected]> Reviewed-By: Richard Lau <[email protected]>
@targos
deps: update timezone to 2024a
4631d7c
PR-URL: nodejs#51723 Refs: https://github.com/unicode-org/icu/releases/tag/release-74-2 Refs: nodejs#51721 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Steven R Loomis <[email protected]> Reviewed-By: Richard Lau <[email protected]>
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 5, 2024

Review requested:

  • @nodejs/security-wg

@nodejs-github-botnodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. labels Mar 5, 2024
@targostargos mentioned this pull request Mar 5, 2024
Closed
@targostargos added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 5, 2024
@github-actionsgithub-actionsbot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Mar 5, 2024
@github-actions
Copy link
Contributor

github-actionsbot commented Mar 5, 2024

Failed to start CI
/opt/hostedtoolcache/node/16.20.2/x64/lib/node_modules/@node-core/utils/node_modules/undici/lib/web/fetch/response.js:507 ReadableStream ^ 
ReferenceError: ReadableStream is not defined
 at Object. (/opt/hostedtoolcache/node/16.20.2/x64/lib/node_modules/@node-core/utils/node_modules/undici/lib/web/fetch/response.js:507:3)
 at Module._compile (node:internal/modules/cjs/loader:1198:14)
 at Object.Module._extensions..js (node:internal/modules/cjs/loader:1252:10)
 at Module.load (node:internal/modules/cjs/loader:1076:32)
 at Function.Module._load (node:internal/modules/cjs/loader:911:12)
 at Module.require (node:internal/modules/cjs/loader:1100:19)
 at require (node:internal/modules/cjs/helpers:119:18)
 at Object. (/opt/hostedtoolcache/node/16.20.2/x64/lib/node_modules/@node-core/utils/node_modules/undici/lib/web/fetch/index.js:11:5)
 at Module._compile (node:internal/modules/cjs/loader:1198:14)
 at Object.Module._extensions..js (node:internal/modules/cjs/loader:1252:10)
https://github.com/nodejs/node/actions/runs/8158770866

@richardlaurichardlau added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Mar 5, 2024
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 5, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@richardlaurichardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 15, 2024
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 15, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 15, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/57765/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 15, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/57771/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 16, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/57777/

@ghiscoding
Copy link

ghiscoding commented Mar 20, 2024

I assume this might fix this issue #51090 that I've opened a while ago!?

richardlau pushed a commit that referenced this pull request Mar 25, 2024
@nodejs-github-bot@richardlau
deps: update icu to 74.1
4ee0f83
PR-URL: #50515 Backport-PR-URL: #51972 Reviewed-By: Steven R Loomis <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Refs: #51933
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@nodejs-github-bot@richardlau
deps: update timezone to 2023d
e6fc5a5
PR-URL: #51461 Backport-PR-URL: #51972 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Refs: #51933
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@targos@richardlau
tools: fix update-icu.sh
bc6bdda
The name of the sources MD5 file has changed. Refs: https://github.com/unicode-org/icu/releases/tag/release-74-2 PR-URL: #51723 Backport-PR-URL: #51972 Refs: #51721 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Steven R Loomis <[email protected]> Reviewed-By: Richard Lau <[email protected]> Refs: #51933
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@targos@richardlau
deps: update icu to 74.2
452d74c
Refs: https://github.com/unicode-org/icu/releases/tag/release-74-2 PR-URL: #51723 Backport-PR-URL: #51972 Refs: #51721 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Steven R Loomis <[email protected]> Reviewed-By: Richard Lau <[email protected]> Refs: #51933
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@targos@richardlau
deps: update timezone to 2024a
4ee7f29
PR-URL: #51723 Backport-PR-URL: #51972 Refs: https://github.com/unicode-org/icu/releases/tag/release-74-2 Refs: #51721 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Steven R Loomis <[email protected]> Reviewed-By: Richard Lau <[email protected]> Refs: #51933
@richardlau
Copy link
Member

richardlau commented Mar 25, 2024

Landed in e8f5735...4ee7f29.

@targostargos deleted the update-icu-v20.x branch June 10, 2024 09:47
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlaurichardlaurichardlau approved these changes

Assignees

No one assigned

Labels

dependenciesPull requests that update a dependency file.needs-ciPRs that need a full CI run.v20.xIssues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@targos@nodejs-github-bot@ghiscoding@richardlau