Skip to content

test: fix watch test with require not testing pid#52353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 2 commits into from
Apr 11, 2024
Merged

test: fix watch test with require not testing pid #52353

nodejs-github-bot merged 2 commits into from
Apr 11, 2024

Conversation

@rluvaton
Copy link
Member

@rluvatonrluvaton commented Apr 3, 2024

process._rawDebug output to stderr and not stdout

@rluvatonrluvaton added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 3, 2024
@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 3, 2024
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 3, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 3, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/58072/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 3, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/58083/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 3, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/58089/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 4, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/58092/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 4, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/58097/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 4, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/58105/

aduh95
aduh95 reviewed Apr 4, 2024
View reviewed changes
aduh95
aduh95 reviewed Apr 4, 2024
View reviewed changes
@rluvatonrluvaton added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 6, 2024
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 6, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 6, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/58163/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 7, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/58173/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 7, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/58181/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 7, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/58191/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 8, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/58203/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 10, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/58250/

@MoLowMoLow added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 11, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 11, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/58261/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 11, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/58263/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 11, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/58266/

@MoLowMoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 11, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 11, 2024
@nodejs-github-botnodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Apr 11, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 11, 2024

Commit Queue failed
- Loading data for nodejs/node/pull/52353 ✔ Done loading data for nodejs/node/pull/52353 ----------------------------------- PR info ------------------------------------ Title test: fix watch test with require not testing pid (#52353) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch rluvaton:fix-watch-test -> nodejs:main Labels test, author ready, needs-ci Commits 2 - test: fix watch test with require not testing pid - watch: code review changes Committers 1 - Raz Luvaton <[email protected]> PR-URL: https://github.com/nodejs/node/pull/52353 Reviewed-By: Moshe Atlow Reviewed-By: Antoine du Hamel ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/52353 Reviewed-By: Moshe Atlow Reviewed-By: Antoine du Hamel -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 03 Apr 2024 16:25:35 GMT ✔ Approvals: 2 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/52353#pullrequestreview-1977470529 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/52353#pullrequestreview-1984873056 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-04-11T09:19:17Z: https://ci.nodejs.org/job/node-test-pull-request/58266/ - Querying data for job/node-test-pull-request/58266/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 52353 From https://github.com/nodejs/node * branch refs/pull/52353/merge -> FETCH_HEAD ✔ Fetched commits as 3f8cc88009ef..87074ea57c32 -------------------------------------------------------------------------------- Auto-merging test/sequential/test-watch-mode.mjs [main 3cf6e9c119] test: fix watch test with require not testing pid Author: Raz Luvaton <[email protected]> Date: Wed Apr 3 17:23:55 2024 +0100 1 file changed, 7 insertions(+), 4 deletions(-) Auto-merging test/sequential/test-watch-mode.mjs [main 66d6cd1175] watch: code review changes Author: Raz Luvaton <[email protected]> Date: Sat Apr 6 21:54:56 2024 +0300 1 file changed, 2 insertions(+), 2 deletions(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4) 
Executing: git node land --amend --yes
 --------------------------------- New Message ----------------------------------
 test: fix watch test with require not testing pid
PR-URL: #52353
 Reviewed-By: Moshe Atlow [email protected]
 Reviewed-By: Antoine du Hamel [email protected]
[detached HEAD e2f7183cdc] test: fix watch test with require not testing pid
 Author: Raz Luvaton [email protected]
 Date: Wed Apr 3 17:23:55 2024 +0100
 1 file changed, 7 insertions(+), 4 deletions(-)
 Rebasing (3/4)
 Rebasing (4/4)
Executing: git node land --amend --yes
 --------------------------------- New Message ----------------------------------
 watch: code review changes
PR-URL: #52353
 Reviewed-By: Moshe Atlow [email protected]
 Reviewed-By: Antoine du Hamel [email protected]
[detached HEAD 0723bdbfc9] watch: code review changes
 Author: Raz Luvaton [email protected]
 Date: Sat Apr 6 21:54:56 2024 +0300
 1 file changed, 2 insertions(+), 2 deletions(-)
Successfully rebased and updated refs/heads/main.
ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.
https://github.com/nodejs/node/actions/runs/8645152431

@MoLowMoLow added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Apr 11, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 11, 2024
@nodejs-github-botnodejs-github-bot merged commit ee4fa77 into nodejs:mainApr 11, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 11, 2024

Landed in ee4fa77

@rluvatonrluvaton deleted the fix-watch-test branch April 11, 2024 11:00
@RafaelGSSRafaelGSS mentioned this pull request Apr 15, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request May 2, 2024
@rluvaton@marco-ippolito
test: fix watch test with require not testing pid
e1734ea
PR-URL: #52353 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
@marco-ippolitomarco-ippolito mentioned this pull request May 2, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request May 3, 2024
@rluvaton@marco-ippolito
test: fix watch test with require not testing pid
1f7a28c
PR-URL: #52353 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MoLowMoLowMoLow approved these changes

@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rluvaton@nodejs-github-bot@MoLow@aduh95