doc: update the description of the return type for options.filter#52742
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added doc 
ContributorAuthor
kylo5aby commented Apr 29, 2024
aduh95 reviewed Apr 30, 2024
Uh oh!
There was an error while loading. Please reload this page.
aduh95 reviewed Apr 30, 2024
Uh oh!
There was an error while loading. Please reload this page.
ContributorAuthor
kylo5aby commented May 15, 2024
can you please take a look @aduh95 |
H4ad approved these changes Jun 8, 2024
legendecas approved these changes Jun 19, 2024
legendecas added the commit-queue nodejs-github-bot removed the commit-queue 
Collaborator
nodejs-github-bot commented Jun 19, 2024
Landed in a072ec3 |
targos pushed a commit that referenced this pull request Jun 20, 2024
PR-URL: #52742 Refs: #52461 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
sophoniie pushed a commit to sophoniie/node that referenced this pull request Jun 20, 2024
PR-URL: nodejs#52742 Refs: nodejs#52461 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
PR-URL: nodejs#52742 Refs: nodejs#52461 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
PR-URL: #52742 Refs: #52461 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
PR-URL: #52742 Refs: #52461 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The return type of
options.filterinfs.cp,fs.cpSync, andfsPromises.cpcan be coerced to types that are coercible toboolean, not onlyboolean, So I update related contents in the doc.Once this PR has no further issues, I will close#52461.
Refs: #52461