Skip to content

Conversation

@MattiasBuelens
Copy link
Contributor

Manual backport of #51168 to v20.x.
Depends on #52772, so keeping this in draft until that one lands.

This one was a bit tricky, since there are changes to transferables on v22.x that are not on v20.x (such as #50107) which also affect web streams. However, I think I made it work. 🤞

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/web-standards

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. web streams labels May 1, 2024
@MattiasBuelensMattiasBuelensforce-pushed the backport-51168-to-v20.x branch 2 times, most recently from 43c8f92 to a7758eeCompareMay 1, 2024 11:18
@marco-ippolito
Copy link
Member

can you fix the conflicts? I'll try to backport it in the next v20 release

@MattiasBuelensMattiasBuelensforce-pushed the backport-51168-to-v20.x branch from a7758ee to c6f0199CompareMay 16, 2024 18:27
@MattiasBuelensMattiasBuelens marked this pull request as ready for review May 16, 2024 18:27
@MattiasBuelens
Copy link
ContributorAuthor

@marco-ippolito Updated and ready for review. 😉

@marco-ippolitomarco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label May 17, 2024
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 17, 2024
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@marco-ippolito
Copy link
Member

marco-ippolito commented Jun 12, 2024

Hi @MattiasBuelens I was backporting your commits, I encountered some issue, can you please cherry-pick the landed commits from the original PR (example #51168 (comment)), instead of the commits from your fork, so that they contain metadata like PR-URL and reviewers, and please squash the fixup commits

@marco-ippolitomarco-ippolitoforce-pushed the v20.x-staging branch 3 times, most recently from a924e20 to 473fa73CompareJune 19, 2024 09:12
@MattiasBuelensMattiasBuelensforce-pushed the backport-51168-to-v20.x branch from c6f0199 to 773f990CompareJune 25, 2024 19:09
PR-URL: nodejs#51168 Backport-PR-URL: nodejs#52773 Reviewed-By: Matteo Collina <[email protected]>
@MattiasBuelensMattiasBuelensforce-pushed the backport-51168-to-v20.x branch from 773f990 to 573f5dfCompareJune 25, 2024 19:12
@MattiasBuelens
Copy link
ContributorAuthor

@marco-ippolito I've squashed the commits on this PR and rebased them onto v20.x-staging.

The original PR didn't have the most prominent change in the first commit, so we landed it in 20c6313 with the unimaginative title "stream: fix code style". 😅 I changed it to "stream: fixes for webstreams" for this PR, if that's okay.

@marco-ippolito
Copy link
Member

@marco-ippolito I've squashed the commits on this PR and rebased them onto v20.x-staging.

The original PR didn't have the most prominent change in the first commit, so we landed it in 20c6313 with the unimaginative title "stream: fix code style". 😅 I changed it to "stream: fixes for webstreams" for this PR, if that's okay.

You can just cherry-pick the landed commits from the original PR (at the end of the pr in the comment from the bot landed in ...) and squash only the fixup commits

Copy link
Member

@mcollinamcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
PR-URL: #51168 Backport-PR-URL: #52773 Reviewed-By: Matteo Collina <[email protected]>
@marco-ippolito
Copy link
Member

Landed in 48138af

@MattiasBuelensMattiasBuelens deleted the backport-51168-to-v20.x branch July 25, 2024 16:25
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ciPRs that need a full CI run.v20.xIssues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch.web streams

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@MattiasBuelens@nodejs-github-bot@marco-ippolito@mcollina