Release proposal: 5.7.0 (Stable)

[rvagg]

For Tuesday, the 23rd, it's not even been two weeks and the backlog is already pretty amazing:

Notable changes

• buffer:
  • You can now supply an encoding argument when filling a Buffer Buffer#fill(string[, start[, end]][, encoding]), supplying an existing Buffer will also work with Buffer#fill(buffer[, start[, end]]). See the API documentation for details on how this works. (Trevor Norris) #4935
  • Buffer#indexOf() no longer requires a byteOffset argument if you also wish to specify an encoding: Buffer#indexOf(val[, byteOffset][, encoding]). (Trevor Norris) #4803
• child_process: spawn() and spawnSync() now support a 'shell' option to allow for optional execution of the given command inside a shell. If set to true, cmd.exe will be used on Windows and /bin/sh elsewhere. A path to a custom shell can also be passed to override these defaults. On Windows, this option allows .bat. and .cmd files to be executed with spawn() and spawnSync(). (Colin Ihrig) #4598
• http_parser: Update to http-parser 2.6.2 to fix an unintentionally strict limitation of allowable header characters (James M Snell) #5237
• dgram: socket.send() now supports accepts an array of Buffers or Strings as the first argument. See the API docs for details on how this works. (Matteo Collina) #4374
• http: Fix a bug where handling headers will mistakenly trigger an 'upgrade' event where the server is just advertising its protocols. This bug can prevent HTTP clients from communicating with HTTP/2 enabled servers. (Fedor Indutny) #4337
• net: Added a listening Boolean property to net and http servers to indicate whether the server is listening for connections. (José Moreira) #4743
• node: The C++ node::MakeCallback() API is now reentrant and calling it from inside another MakeCallback() call no longer causes the nextTick queue or Promises microtask queue to be processed out of order. (Trevor Norris) #4507
• tls: Add a new tlsSocket.getProtocol() method to get the negotiated TLS protocol version of the current connection. (Brian White) #4995
• vm: Introduce new 'produceCachedData' and 'cachedData' options to new vm.Script() to interact with V8's code cache. When a new vm.Script object is created with the 'produceCachedData' set to true a Buffer with V8's code cache data will be produced and stored in cachedData property of the returned object. This data in turn may be supplied back to another vm.Script() object with a 'cachedData' option if the supplied source is the same. Successfully executing a script from cached data can speed up instantiation time. See the API docs for details. (Fedor Indutny) #4777
• performance: Improvements in:
  • process.nextTick() (Ruben Bridgewater) #5092
  • path module (Brian White) #5123
  • querystring module (Brian White) #5012
  • streams module when processing small chunks (Matteo Collina) #4354

Current CI run: https://ci.nodejs.org/job/node-test-commit/2273/
No citgm run yet, the path regression should be fixed at least.

[rvagg]

May need to s/Tuesday, the 23rd/Monday, the 22nd/ (US time) for (Jenkins-related) security reasons.

[jbergstroem]

Can we get a RC? It'd be good to test the ppcle release.

[rvagg]

@jbergstroem will do it on our Monday, there's likely to be a lot of extra code landed in here before release so an RC won't really be anything like an RC, plus, on Jenkins, the RC path is similar to the nightly path I think so it's not quite as interesting as an actual release.

[jbergstroem]

Ah; I'll dig up a nightly this weekend and test it out on our machines then.

[ronkorving]

 dgram: socket.send() now supports accepts an array of Buffers of Strings as the first argument. See the API docs for details on how this works. (Matteo Collina) #4374 

Buffers or Strings

[MylesBorins]

citgm: https://ci.nodejs.org/job/thealphanerd-smoker/86/

edit: looks good

expected failures on ppc. Single failure on ubuntu 64 was tape, which is known the be flaky

[jasnell]

Overall looking good. Definitely would like to see a RC

[rvagg]

Updated branch with some more commits, probably not going to add much more than this before final.

• RC 1: https://nodejs.org/download/rc/v5.7.0-rc.1/ (including ppcle @mhdawson@jbergstroem)
• Test: https://ci.nodejs.org/job/node-test-commit/2296/ (such green, many wow!)
• Smoke: https://ci.nodejs.org/job/thealphanerd-smoker/88/ (12.04 tape failure, is this flaky if it's consistently failing on that platform @thealphanerd?)

[MylesBorins]

@rvagg tape has been periodically failing but on different platforms. The last person who dug into it deemed that there was something flaky in the tape test suite, but we have not dug in further. I've left it unflaky to monitor it.

One commit to keep an eye on is #5369
It has the graceful-fs updates as well as some important windows fixes.

[rvagg]

Interesting re tape, @thealphanerd do you know off the top of your head if it's always the same failure? it was in the require test that I noticed it fail here, is that consistent?

#5369 (npm) isn't going to make it in to this release, too soon to get that landed for this one I think, I'll be trying to get 5.7.0 out in a matter of hours from now.

[rvagg]

Heads up, preparing for release

Test @ https://ci.nodejs.org/job/node-test-commit/2315/ and repeat of Linux tests @ https://ci.nodejs.org/job/node-test-commit-linux/2394/ (looks like a flaky)
Smoke @ https://ci.nodejs.org/job/thealphanerd-smoker/95/ (tape failure so far, known flaky)
Release build @ https://ci.nodejs.org/job/iojs+release/411/ (currently waiting for armv6 and the results of the testing to have enough assurance to actually release)

Should be out shortly if all continues to go well.

[rvagg]

FYI also #5212 was merged in to v5.x for this release to deal with the extra files in deps/npm that are causing problems for Windows users, it's expected that at the latest this will be dealt with on master by the next npm update @ #5369 but for now we're using #5212 to get v5.7.0 out the door without causing the same problems for folks.

[rvagg]

All done

[jbergstroem]

(still waiting for arm to finish)

[rvagg]

not for this one, I got armv6l for v5.7.0 ages ago https://nodejs.org/download/release/v5.7.0/, must be something else

[rvagg]

oh, sorry @jbergstroem that arm run was for the mac installer PR I was building a test binary for, the pkg build failed but I neglected to stop the rest of the jobs cause they were not helpful at all.

killed it, carry on

[chorrell]

v5.7.0 should hopefully land in the Docker hub later today:

docker-library/official-images#1472