Skip to content

Conversation

@avivkeller
Copy link
Member

@avivkelleravivkeller commented May 14, 2024

When --experimental-detect-module is enabled, the default format will no longer be commonjs; instead, it will be null until the source is loaded. In this PR, the behavior is changed to default to commonjs, aligning with the non-experimental behavior.

@nodejs-github-botnodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels May 14, 2024
@GeoffreyBooth
Copy link
Member

@nodejs/loaders

@GeoffreyBoothGeoffreyBooth added the module Issues and PRs related to the module subsystem. label May 14, 2024
@GeoffreyBooth
Copy link
Member

This seems to undo part of #50314 but not necessarily incorrectly; @aduh95 can you please review?

@avivkeller
Copy link
MemberAuthor

avivkeller commented May 14, 2024

This change, while it resolves one issue, it introduces several others (E.G. node --experimental-detect-module /xxx/test/fixtures/es-modules/package-without-type/module.js will not work now)

@avivkelleravivkeller marked this pull request as draft May 14, 2024 20:31
@avivkeller
Copy link
MemberAuthor

Marking as draft, as some things need to worked out before this is ready

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

esmIssues and PRs related to the ECMAScript Modules implementation.moduleIssues and PRs related to the module subsystem.needs-ciPRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@avivkeller@GeoffreyBooth@nodejs-github-bot