test: remove flaky mark for test-debug-no-context#5317
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
test-debug-no-context flakiness was worked around in issue 5269 but the flaky designation was left for the test. This change removes it. Refs: nodejs#5269
Contributor
evanlucas commented Feb 19, 2016
LGTM |
1 similar comment
Member
jasnell commented Feb 19, 2016
LGTM |
jasnell pushed a commit that referenced this pull request Feb 19, 2016
test-debug-no-context flakiness was worked around in issue 5269 but the flaky designation was left for the test. This change removes it. Refs: #5269 PR-URL: #5317 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
jasnell commented Feb 19, 2016
Landed in 3144ecd |
rvagg pushed a commit that referenced this pull request Feb 21, 2016
test-debug-no-context flakiness was worked around in issue 5269 but the flaky designation was left for the test. This change removes it. Refs: #5269 PR-URL: #5317 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 1, 2016
test-debug-no-context flakiness was worked around in issue 5269 but the flaky designation was left for the test. This change removes it. Refs: #5269 PR-URL: #5317 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 1, 2016
test-debug-no-context flakiness was worked around in issue 5269 but the flaky designation was left for the test. This change removes it. Refs: #5269 PR-URL: #5317 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
test-debug-no-context flakiness was worked around in issue 5269 but the flaky designation was left for the test. This change removes it. Refs: #5269 PR-URL: #5317 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test-debug-no-context flakiness was worked around in issue 5269 but the
flaky designation was left for the test. This change removes it.
Refs: #5269