doc: refine child_process detach behaviour#5330
Uh oh!
There was an error while loading. Please reload this page.
Conversation
ChALkeR added child_process 
doc/api/child_process.markdown Outdated
There was a problem hiding this comment.
Perhaps: *Note that detaching a process is platform specific.* ... also would be good to list the platform specific differences here.
jasnell commented Mar 21, 2016
@nodejs/documentation |
eljefedelrodeodeljefe commented Mar 30, 2016
enhanced upon @jasnell's comment. Note, the reason I wanted to mention the specific behaviour down there again is because copy-pasting the either of the code snippet will likely lead to unwanted behaviour depending on which platform you are. The API isn't really consistent there, which of course is OS'es nature of different process implementations. I also removed |
doc/api/child_process.markdown Outdated
There was a problem hiding this comment.
Looking at the new layout of the file, this note seems unnecessary.
cjihrig commented Mar 30, 2016
LGTM with a few comments. |
this adds an example of a long running node process that actually executes node code. Also it mentions the not to harmonic detach behaviours of the different platforms, whereas detaching on unix requires ignoring the child_process' stdio explicitely.
eljefedelrodeodeljefe commented Mar 30, 2016
@cjihrig addressed your comments. Content-wise I just omitted the |
cjihrig commented Mar 30, 2016
Cool. Thanks. If @jasnell is good with it, we can land this. |
jasnell commented Apr 2, 2016
LGTM |
this adds an example of a long running node process that actually executes node code. Also it mentions the not to harmonic detach behaviours of the different platforms, whereas detaching on unix requires ignoring the child_process' stdio explicitely. PR-URL: #5330 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
jasnell commented Apr 2, 2016
Landed in 82c2996 |
this adds an example of a long running node process that actually executes node code. Also it mentions the not to harmonic detach behaviours of the different platforms, whereas detaching on unix requires ignoring the child_process' stdio explicitely. PR-URL: #5330 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
this adds an example of a long running node process that actually executes node code. Also it mentions the not to harmonic detach behaviours of the different platforms, whereas detaching on unix requires ignoring the child_process' stdio explicitely. PR-URL: #5330 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
5 participants
This adds an example of a long running node process that actually
executes node code.
Also it mentions the not to harmonic detach behaviours of the
different platforms, which might also invite some core work.
I felt this to be necessary after researching for #5146, whereas the the behaviour of detaching seems highly inconsistent and very untransparent for the user.
/cc @nodejs/documentation