test: refactor test-dgram-udp4

[santigimeno]

This test was sometimes timing out in OS X. Remove the timeout and
clean up the code.

This test has failed in my OS X box with this error:

=== release test-dgram-udp4 === Path: parallel/test-dgram-udp4 server is listening on 0.0.0.0:12446 /Users/sgimeno/node/node/test/parallel/test-dgram-udp4.js:59 throw new Error('Timeout'); ^ Error: Timeout at null._onTimeout (/Users/sgimeno/node/node/test/parallel/test-dgram-udp4.js:59:9) at Timer.listOnTimeout (timers.js:92:15) Command: out/Release/node /Users/sgimeno/node/node/test/parallel/test-dgram-udp4.js 

[jasnell]

LGTM

[r-52]

Full CI run: https://ci.nodejs.org/job/node-test-pull-request/1724/

[mcollina]

I'm not sure removing the timeout is a great call, otherwise the test will get stuck instead of failing (as far as I understand it).
However, we should be consistent within all dgram tests.

[santigimeno]

@mcollina the idea was that the test runner timeout handled it. Sometimes the use of timeouts has been a source of test flakiness. Do you see it as a problem?

[mcollina]

No, I'm happy with this.
There are more that needs the timeout removal.

[mcollina]

LGTM

[santigimeno]

There are more that needs the timeout removal.

Agreed. See: nodejs/testing#19

[mcollina]

are you a contributor here, or should I land this?

[santigimeno]

I am not, please land. Thanks

[mcollina]

Landed in dff01d1