Skip to content

src: move FromNamespacedPath to path.cc#53540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Jun 27, 2024
Merged

src: move FromNamespacedPath to path.cc #53540

nodejs-github-bot merged 1 commit into from
Jun 27, 2024

Conversation

@anonrig
Copy link
Member

@anonriganonrig commented Jun 21, 2024

Since ->starts_with() is C++20, this pull-request can not land on v18 and v20.

@anonriganonrig added dont-land-on-v18.x dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. labels Jun 21, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 21, 2024

Review requested:

  • @nodejs/url

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jun 21, 2024
@anonriganonrigforce-pushed the refactor-from-namespaced-path branch from a73098a to ff82bc5CompareJune 21, 2024 22:15
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 21, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/59918/

jasnell
jasnell reviewed Jun 21, 2024
View reviewed changes
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 26, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/59977/

@anonrig
Copy link
MemberAuthor

anonrig commented Jun 26, 2024

cc @nodejs/cpp-reviewers

@anonriganonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 26, 2024
@nodejs-github-botnodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 27, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 27, 2024

Commit Queue failed
- Loading data for nodejs/node/pull/53540 ✔ Done loading data for nodejs/node/pull/53540 ----------------------------------- PR info ------------------------------------ Title src: move `FromNamespacedPath` to path.cc (#53540) Author Yagiz Nizipli (@anonrig) Branch anonrig:refactor-from-namespaced-path -> nodejs:main Labels c++, lib / src, author ready, needs-ci, dont-land-on-v18.x, dont-land-on-v20.x Commits 1 - src: move `FromNamespacedPath` to path.cc Committers 1 - Yagiz Nizipli PR-URL: https://github.com/nodejs/node/pull/53540 Reviewed-By: Daniel Lemire ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/53540 Reviewed-By: Daniel Lemire -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 21 Jun 2024 22:15:46 GMT ✔ Approvals: 1 ✔ - Daniel Lemire (@lemire): https://github.com/nodejs/node/pull/53540#pullrequestreview-2142818588 ✘ This PR needs to wait 31 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-06-26T13:05:50Z: https://ci.nodejs.org/job/node-test-pull-request/59977/ - Querying data for job/node-test-pull-request/59977/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/9698314507

@anonriganonrig added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jun 27, 2024
Ethan-Arrowood
Ethan-Arrowood approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@Ethan-ArrowoodEthan-Arrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🫡

H4ad
H4ad reviewed Jun 27, 2024
View reviewed changes
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 27, 2024
@nodejs-github-botnodejs-github-bot merged commit 3036066 into nodejs:mainJun 27, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 27, 2024

Landed in 3036066

aduh95 pushed a commit that referenced this pull request Jul 12, 2024
@anonrig@aduh95
src: move FromNamespacedPath to path.cc
c6befef
PR-URL: #53540 Reviewed-By: Daniel Lemire <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]>
@aduh95aduh95 mentioned this pull request Jul 12, 2024
Merged
aduh95 pushed a commit that referenced this pull request Jul 16, 2024
@anonrig@aduh95
src: move FromNamespacedPath to path.cc
cc1f497
PR-URL: #53540 Reviewed-By: Daniel Lemire <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]>
codebytere added a commit to electron/electron that referenced this pull request Oct 16, 2024
@codebytere
src: move FromNamespacedPath to path.cc
9989cae
nodejs/node#53540
codebytere added a commit to electron/electron that referenced this pull request Oct 21, 2024
@codebytere
src: move FromNamespacedPath to path.cc
c9d1dc0
nodejs/node#53540
codebytere added a commit to electron/electron that referenced this pull request Oct 21, 2024
@codebytere
src: move FromNamespacedPath to path.cc
9d60908
nodejs/node#53540
codebytere added a commit to electron/electron that referenced this pull request Oct 22, 2024
@codebytere
src: move FromNamespacedPath to path.cc
1c687d2
nodejs/node#53540
codebytere added a commit to electron/electron that referenced this pull request Oct 28, 2024
@codebytere
src: move FromNamespacedPath to path.cc
987c214
nodejs/node#53540
codebytere added a commit to electron/electron that referenced this pull request Oct 29, 2024
@codebytere
src: move FromNamespacedPath to path.cc
371959f
nodejs/node#53540
codebytere added a commit to electron/electron that referenced this pull request Oct 31, 2024
@codebytere
src: move FromNamespacedPath to path.cc
ee90b9a
nodejs/node#53540
jkleinsc pushed a commit to electron/electron that referenced this pull request Nov 4, 2024
@codebytere
chore: bump Node.js to v22.9.0 (#44281)
c63d0d6
* chore: bump Node.js to v22.9.0 * build: drop base64 dep in GN build nodejs/node#52856 * build,tools: make addons tests work with GN nodejs/node#50737 * fs: add fast api for InternalModuleStat nodejs/node#51344 * src: move package_json_reader cache to c++ nodejs/node#50322 * crypto: disable PKCS#1 padding for privateDecrypt nodejs-private/node-private#525 * src: move more crypto code to ncrypto nodejs/node#54320 * crypto: ensure valid point on elliptic curve in SubtleCrypto.importKey nodejs/node#50234 * src: shift more crypto impl details to ncrypto nodejs/node#54028 * src: switch crypto APIs to use Maybe<void> nodejs/node#54775 * crypto: remove DEFAULT_ENCODING nodejs/node#47182 * deps: update libuv to 1.47.0 nodejs/node#50650 * build: fix conflict gyp configs nodejs/node#53605 * lib,src: drop --experimental-network-imports nodejs/node#53822 * esm: align sync and async load implementations nodejs/node#49152 * esm: remove unnecessary toNamespacedPath calls nodejs/node#53656 * module: detect ESM syntax by trying to recompile as SourceTextModule nodejs/node#52413 * test: adapt debugger tests to V8 11.4 nodejs/node#49639 * lib: update usage of always on Atomics API nodejs/node#49639 * test: adapt test-fs-write to V8 internal changes nodejs/node#49639 * test: adapt to new V8 trusted memory spaces nodejs/node#50115 * deps: update libuv to 1.47.0 nodejs/node#50650 * src: use non-deprecated v8::Uint8Array::kMaxLength nodejs/node#50115 * src: update default V8 platform to override functions with location nodejs/node#51362 * src: add missing TryCatch nodejs/node#51362 * lib,test: handle new Iterator global nodejs/node#51362 * src: use non-deprecated version of CreateSyntheticModule nodejs/node#50115 * src: remove calls to recently deprecated V8 APIs nodejs/node#52996 * src: use new V8 API to define stream accessor nodejs/node#53084 * src: do not use deprecated V8 API nodejs/node#53084 * src: do not use soon-to-be-deprecated V8 API nodejs/node#53174 * src: migrate to new V8 interceptors API nodejs/node#52745 * src: use supported API to get stalled TLA messages nodejs/node#51362 * module: print location of unsettled top-level await in entry points nodejs/node#51999 * test: make snapshot comparison more flexible nodejs/node#54375 * test: do not set concurrency on parallelized runs nodejs/node#52177 * src: move FromNamespacedPath to path.cc nodejs/node#53540 * test: adapt to new V8 trusted memory spaces nodejs/node#50115 * build: add option to enable clang-cl on Windows nodejs/node#52870 * chore: fixup patch indices * chore: add/remove changed files * esm: drop support for import assertions nodejs/node#54890 * build: compile with C++20 support nodejs/node#52838 * deps: update nghttp2 to 1.62.1 nodejs/node#52966 * src: parse inspector profiles with simdjson nodejs/node#51783 * build: add GN build files nodejs/node#47637 * deps,lib,src: add experimental web storage nodejs/node#52435 * build: add missing BoringSSL dep * src: rewrite task runner in c++ nodejs/node#52609 * fixup! build: add GN build files * src: stop using deprecated fields of v8::FastApiCallbackOptions nodejs/node#54077 * fix: shadow variable * build: add back incorrectly removed SetAccessor patch * fixup! fixup! build: add GN build files * crypto: fix integer comparison in crypto for BoringSSL * src,lib: reducing C++ calls of esm legacy main resolvenodejs/node#48325 * src: move more crypto_dh.cc code to ncrypto nodejs/node#54459 * chore: fixup GN files for previous commit * src: move more crypto code to ncrypto nodejs/node#54320 * Fixup Perfetto ifdef guards * fix: missing electron_natives dep * fix: node_use_node_platform = false * fix: include src/node_snapshot_stub.cc in libnode * 5507047: [import-attributes] Remove support for import assertions https://chromium-review.googlesource.com/c/v8/v8/+/5507047 * fix: restore v8-sandbox.h in filenames.json * fix: re-add original-fs generation logic * fix: ngtcp2 openssl dep * test: try removing NAPI_VERSION undef * chore(deps): bump @types/node * src: move more crypto_dh.cc code to ncrypto nodejs/node#54459 * esm: remove unnecessary toNamespacedPath calls nodejs/node#53656 * buffer: fix out of range for toString nodejs/node#54553 * lib: rewrite AsyncLocalStorage without async_hooks nodejs/node#48528 * module: print amount of load time of a cjs module nodejs/node#52213 * test: skip reproducible snapshot test on 32-bit nodejs/node#53592 * fixup! src: move more crypto_dh.cc code to ncrypto * test: adjust emittedUntil return type * chore: remove redundant wpt streams patch * fixup! chore(deps): bump @types/node * fix: gn executable name on Windows * fix: build on Windows * fix: rename conflicting win32 symbols in //third_party/sqlite On Windows otherwise we get: lld-link: error: duplicate symbol: sqlite3_win32_write_debug >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:47987 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_sleep >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48042 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_is_nt >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48113 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_utf8_to_unicode >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48470 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_unicode_to_utf8 >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48486 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_mbcs_to_utf8 >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48502 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_mbcs_to_utf8_v2 >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48518 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_utf8_to_mbcs >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48534 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_utf8_to_mbcs_v2 >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48550 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj * docs: remove unnecessary ts-expect-error after types bump * src: move package resolver to c++ nodejs/node#50322 * build: set ASAN detect_container_overflow=0 nodejs/node#55584 * chore: fixup rebase * test: disable failing ASAN test * win: almost fix race detecting ESRCH in uv_kill libuv/libuv#4341
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell left review comments

@H4adH4adH4ad approved these changes

@lemirelemirelemire approved these changes

@Ethan-ArrowoodEthan-ArrowoodEthan-Arrowood approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.dont-land-on-v20.xPRs that should not land on the v20.x-staging branch and should not be released in v20.x.lib / srcIssues and PRs related to general changes in the lib or src directory.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@anonrig@nodejs-github-bot@lemire@jasnell@H4ad@Ethan-Arrowood