lib,test,benchmark: simplify code with String.prototype.repeat()#5359
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ContributorAuthor
JacksonTian commented Feb 22, 2016
like #5311 . |
Contributor
mscdex commented Feb 22, 2016
mscdex added test Contributor
mscdex commented Feb 22, 2016
Linter failed: |
Contributor
mscdex commented Feb 22, 2016
Also this test is failing on all platforms: |
JacksonTianforce-pushed the repeat branch 2 times, most recently from 00753aa to 34c6b03CompareContributorAuthor
JacksonTian commented Feb 22, 2016
Hi @mscdex , I updated the PR. |
Contributor
mscdex commented Feb 22, 2016
Contributor
mscdex commented Feb 22, 2016
CI is all green |
Member
targos commented Feb 22, 2016
LGTM |
use String.prototype.repeat() to simplify code, less code, more semantically.
ContributorAuthor
JacksonTian commented Mar 2, 2016
Rebased with master. |
Member
jasnell commented Mar 2, 2016
LGTM |
2 tasks
jasnell pushed a commit that referenced this pull request Mar 21, 2016
use String.prototype.repeat() to simplify code, less code, more semantically. PR-URL: #5359 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
jasnell commented Mar 21, 2016
Landed in 4d78121 |
Member
Trott commented Mar 22, 2016
@jasnell Landing this has broken |
4 tasks
Member
Trott commented Mar 22, 2016
I'll put together a fix unless someone beats me to it. |
ContributorAuthor
JacksonTian commented Mar 22, 2016
I am sorry, Let me fix it. @Trott . |
Member
Trott commented Mar 22, 2016
I already opened #5840, but thanks! |
Member
Trott commented Mar 22, 2016
(And no worries, this isn't the first time this sort of thing has happened, the problem is our process not anything you did wrong.) |
Member
jasnell commented Mar 22, 2016
Yep, not your fault at all @JacksonTian ... I'm the one who missed the step. I saw the green CI without checking the date and forgot to run |
Member
Trott commented Mar 22, 2016
Yeah, we've got a lot of opportunities for automation, for sure. |
Fishrock123 pushed a commit that referenced this pull request Mar 22, 2016
use String.prototype.repeat() to simplify code, less code, more semantically. PR-URL: #5359 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
Contributor
MylesBorins commented Mar 30, 2016
I've manually added the linting changes while backporting. @Trott I've marked your linting PR as don't land on v4 |
MylesBorins pushed a commit that referenced this pull request Mar 30, 2016
use String.prototype.repeat() to simplify code, less code, more semantically. PR-URL: #5359 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 30, 2016
use String.prototype.repeat() to simplify code, less code, more semantically. PR-URL: #5359 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use String.prototype.repeat() to simplify code, less code, more
semantically.