build: update codecov#53891
Closed
build: update codecov #53891
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
targos commented Jul 17, 2024
In #35759 (comment), there was a coverage chart showing the issue. Can you post an updated one? |
MemberAuthor
anonrig commented Jul 17, 2024
I've reached out to Codecov teams, and with @bcoe working at Sentry, I have high hopes of fixing this soon! |
Member
avivkeller commented Jul 17, 2024
Would the landing of this PR close that issue? (So it can be closed once this lands if needed) |
avivkeller added the meta MemberAuthor
anonrig commented Jul 18, 2024
I've splitted the controversial changes, and moved the easy to review ones to #53929
No it won't. |
Contributor
bcoe commented Jul 25, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codecov comments were disabled almost 4 years ago. I think we can reenable them. Additionally, we now have 1 more coverage build. This PR fixes that.
Previous issue with codecov: #35759
cc @nodejs/build