build: don't store eslint locally

[avivkeller]

This PR removes eslint as a local dependency and switches to downloading it from npm. It will still be updated regularly via @dependabot.

Why?

1. eslint is the only linter stored locally (besides cpplint, which has patches, unlike ESLint).
2. There are multiple issues related to file paths being too long and tarballs failing to lint properly (see: Missing ./tools/node_modules/eslint/eslint.js on make test? #39709, make -s test-doc fails with Error: Cannot find module '/node-v14.4.0/tools/doc/../node_modules/eslint/node_modules/js-yaml' #34005, Erbium: test regression in tarball #32765, and others).

Why was eslint set up like this initially?

When eslint was first added to the repository in #1539 around 10 years, it replaced a (not as large, but still large) library, closure-lint. Since then, the library has almost 4x its size. At the time, there was no discussion (AFAICT) about keeping or removing the directory—it was simply included as it was.

Size-wise, this'll save ~40MB, which isn't a huge much, but it's a decent amount.

[nodejs-github-bot]

Review requested:

• @nodejs/actions
• @nodejs/security-wg
• @nodejs/tsc

[avivkeller]

Note that all linters passed in this PR, meaning that eslint is still working the exact same :-)

ref: https://github.com/nodejs/node/actions/runs/10022363992/job/27702051106?pr=53974

[mcollina]

@nodejs/build is this ok for you?

[anonrig]

iOS app and Safari crashes whenever I look into pull-requests like this. Please separate the change into multiple commits and add commit-queue-squash label in order to receive more reviews on pull-requests such as this.

It will still be updated regularly via https://github.com/dependabot.

Where do we see this change?

[avivkeller]

I've split the PR into build: don't store eslint locally (Which removes the node_modules), and (actual changes) which is what is for review.

Where do we see this change?

@dependabot will, every month, check eslint for an update. If it finds one, it will open a PR (with a max of 10 open at a time) to merge the change. Examples of this with Github Actions can be seen via the following search query:
https://github.com/nodejs/node/issues?q=author%3Adependabot%5Bbot%5D

[bnb]

as long as this doesn't break build, huge +1 to getting this out of core

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/60539/

[avivkeller]

as long as this doesn't break build, huge +1 to getting this out of core

It doesn't AFAICT. Additionally, CI passing backs this up.

[avivkeller]

Closing in favor of #54231