doc: fix documentation for --run#53976
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added cli 
aduh95 approved these changes Jul 20, 2024
anonrig requested changes Jul 20, 2024
doc/api/cli.md Outdated
| This runs a specified command from a package.json's `"scripts"` object. | ||
| If no`"command"` is provided, it will list the available scripts. | ||
| If an invalid`"command"` is provided, it will list the available scripts. |
Member
There was a problem hiding this comment.
Suggested change
| If an invalid`"command"` is provided, it will list the available scripts. | |
| If a missing`"command"` is provided, it will list the available scripts. |
Member
There was a problem hiding this comment.
I think "invalid" is better. node --run is still missing a command so it is not different from the original wording.
Member
There was a problem hiding this comment.
How about "If there is not a matching "command", it will list the available scripts."?
Co-authored-by: Yagiz Nizipli <[email protected]>
anonrig approved these changes Jul 20, 2024
avivkeller added the commit-queue-squash 
trivikr approved these changes Jul 21, 2024
anonrig added the commit-queue nodejs-github-bot removed the commit-queue 
Collaborator
nodejs-github-bot commented Jul 22, 2024
Landed in 4b8000c |
targos pushed a commit that referenced this pull request Jul 28, 2024
PR-URL: #53976 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Merged
RafaelGSS pushed a commit that referenced this pull request Aug 5, 2024
PR-URL: #53976 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
targos added the dont-land-on-v20.x Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#53944