Skip to content

buffer: use native copy impl#54087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Aug 2, 2024
Merged

buffer: use native copy impl #54087

nodejs-github-bot merged 1 commit into from
Aug 2, 2024

Conversation

@ronag
Copy link
Member

@ronagronag commented Jul 28, 2024•
edited
Loading

Apple M2 Pro

buffers/buffer-copy.js n=6000000 partial='false' bytes=0 -0.53 % ±6.78% ±9.02% ±11.74% buffers/buffer-copy.js n=6000000 partial='false' bytes=128 *** 30.37 % ±10.39% ±13.88% ±18.19% buffers/buffer-copy.js n=6000000 partial='false' bytes=32768 2.73 % ±3.96% ±5.27% ±6.86% buffers/buffer-copy.js n=6000000 partial='false' bytes=8 *** 73.09 % ±10.43% ±13.89% ±18.08% buffers/buffer-copy.js n=6000000 partial='true' bytes=0 -1.66 % ±7.78% ±10.35% ±13.47% buffers/buffer-copy.js n=6000000 partial='true' bytes=128 *** 327.50 % ±23.05% ±31.00% ±41.01% buffers/buffer-copy.js n=6000000 partial='true' bytes=32768 * 4.50 % ±4.34% ±5.78% ±7.55% buffers/buffer-copy.js n=6000000 partial='true' bytes=8 *** 311.90 % ±33.99% ±45.75% ±60.62%

Benchmark CI

10:33:07 buffers/buffer-copy.js n=6000000 partial='false' bytes=0 0.56 % ±1.11% ±1.48% ±1.95% 10:33:07 buffers/buffer-copy.js n=6000000 partial='false' bytes=128 *** 34.10 % ±0.81% ±1.08% ±1.41% 10:33:07 buffers/buffer-copy.js n=6000000 partial='false' bytes=32768 *** -1.80 % ±0.84% ±1.12% ±1.47% 10:33:07 buffers/buffer-copy.js n=6000000 partial='false' bytes=8 *** 38.98 % ±1.00% ±1.34% ±1.75% 10:33:07 buffers/buffer-copy.js n=6000000 partial='true' bytes=0 -0.44 % ±0.81% ±1.08% ±1.41% 10:33:07 buffers/buffer-copy.js n=6000000 partial='true' bytes=128 *** 256.54 % ±1.31% ±1.75% ±2.31% 10:33:07 buffers/buffer-copy.js n=6000000 partial='true' bytes=32768 *** 35.39 % ±11.48% ±15.46% ±20.49% 10:33:07 buffers/buffer-copy.js n=6000000 partial='true' bytes=8 *** 249.26 % ±1.67% ±2.24% ±2.95%

@nodejs-github-botnodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. needs-ci PRs that need a full CI run. labels Jul 28, 2024
@ronag
Copy link
MemberAuthor

ronag commented Jul 28, 2024

@tniessen@anonrig @nodejs/performance @nodejs/buffer

@ronagronagforce-pushed the buffer-copy branch 3 times, most recently from d525f28 to 509b66dCompareJuly 28, 2024 21:39
@anonriganonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jul 28, 2024
@github-actionsgithub-actionsbot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jul 28, 2024
@github-actions
Copy link
Contributor

github-actionsbot commented Jul 28, 2024

Failed to start CI
- Validating Jenkins credentials ✔ Jenkins credentials valid - Starting PR CI job ✘ Failed to start PR CI: 400 Bad Request
https://github.com/nodejs/node/actions/runs/10134974481

@ronagronagforce-pushed the buffer-copy branch 2 times, most recently from 147b14d to ce07761CompareJuly 28, 2024 22:29
@jakecastellijakecastelli added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Jul 29, 2024
@github-actionsgithub-actionsbot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jul 29, 2024
@github-actions
Copy link
Contributor

github-actionsbot commented Jul 29, 2024

Failed to start CI
 ⚠ Something was pushed to the Pull Request branch since the last approving review. ℹ request-ci label was added by a Collaborator after the last push event. - Validating Jenkins credentials ✔ Jenkins credentials valid - Starting PR CI job ✘ Failed to start PR CI: 400 Bad Request
https://github.com/nodejs/node/actions/runs/10137136972

@targostargos mentioned this pull request Jul 29, 2024
Closed
@targostargos added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 29, 2024
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 29, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 29, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/60694/

@ronag

This comment was marked as resolved.

Sign in to view
@ronag

This comment was marked as outdated.

Sign in to view
@ronagronagforce-pushed the buffer-copy branch 3 times, most recently from 68cc51b to 7328b6fCompareJuly 29, 2024 05:58
@ronagronag added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Jul 31, 2024
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 31, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 31, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/60778/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 1, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/60794/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 1, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/60798/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 1, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/60799/

@ronagronag added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Aug 2, 2024
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 2, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 2, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/60819/

@ronagronag added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 2, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 2, 2024
@nodejs-github-botnodejs-github-bot merged commit 76c8ba9 into nodejs:mainAug 2, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 2, 2024

Landed in 76c8ba9

targos pushed a commit that referenced this pull request Aug 14, 2024
@ronag@targos
buffer: use native copy impl
9f8f26e
PR-URL: #54087 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Daniel Lemire <[email protected]>
RafaelGSS added a commit that referenced this pull request Aug 19, 2024
@RafaelGSS
2024-08-20, Version 22.7.0 (Current)
5414225
Notable changes: buffer: * use fast API for writing one-byte strings (Robert Nagy) #54311 * optimize createFromString (Robert Nagy) #54324 * use native copy impl (Robert Nagy) #54087 inspector: * (SEMVER-MINOR) support `Network.loadingFailed` event (Kohei Ueno) #54246 lib: * (SEMVER-MINOR) rewrite AsyncLocalStorage without async_hooks (Stephen Belanger) #48528 module: * (SEMVER-MINOR) unflag detect-module (Geoffrey Booth) #53619 PR-URL: TODO
RafaelGSS added a commit that referenced this pull request Aug 19, 2024
@RafaelGSS
2024-08-20, Version 22.7.0 (Current)
69b8bbe
Notable changes: buffer: * use fast API for writing one-byte strings (Robert Nagy) #54311 * optimize createFromString (Robert Nagy) #54324 * use native copy impl (Robert Nagy) #54087 inspector: * (SEMVER-MINOR) support `Network.loadingFailed` event (Kohei Ueno) #54246 lib: * (SEMVER-MINOR) rewrite AsyncLocalStorage without async_hooks (Stephen Belanger) #48528 module: * (SEMVER-MINOR) unflag detect-module (Geoffrey Booth) #53619 PR-URL: #54452
@RafaelGSSRafaelGSS mentioned this pull request Aug 19, 2024
Merged
RafaelGSS added a commit that referenced this pull request Aug 20, 2024
@RafaelGSS
2024-08-20, Version 22.7.0 (Current)
56a5662
Notable changes: buffer: * use fast API for writing one-byte strings (Robert Nagy) #54311 * optimize createFromString (Robert Nagy) #54324 * use native copy impl (Robert Nagy) #54087 inspector: * (SEMVER-MINOR) support `Network.loadingFailed` event (Kohei Ueno) #54246 lib: * (SEMVER-MINOR) rewrite AsyncLocalStorage without async_hooks (Stephen Belanger) #48528 module: * (SEMVER-MINOR) add --experimental-transform-types flag (Marco Ippolito) #54283 * (SEMVER-MINOR) unflag detect-module (Geoffrey Booth) #53619 PR-URL: #54452
RafaelGSS added a commit that referenced this pull request Aug 21, 2024
@RafaelGSS
2024-08-22, Version 22.7.0 (Current)
65eff1e
Notable changes: buffer: * use fast API for writing one-byte strings (Robert Nagy) #54311 * optimize createFromString (Robert Nagy) #54324 * use native copy impl (Robert Nagy) #54087 inspector: * (SEMVER-MINOR) support `Network.loadingFailed` event (Kohei Ueno) #54246 lib: * (SEMVER-MINOR) rewrite AsyncLocalStorage without async_hooks (Stephen Belanger) #48528 module: * (SEMVER-MINOR) add --experimental-transform-types flag (Marco Ippolito) #54283 * (SEMVER-MINOR) unflag detect-module (Geoffrey Booth) #53619 PR-URL: #54452
RafaelGSS added a commit that referenced this pull request Aug 22, 2024
@RafaelGSS
2024-08-22, Version 22.7.0 (Current)
4d5c885
Notable changes: buffer: * use fast API for writing one-byte strings (Robert Nagy) #54311 * optimize createFromString (Robert Nagy) #54324 * use native copy impl (Robert Nagy) #54087 inspector: * (SEMVER-MINOR) support `Network.loadingFailed` event (Kohei Ueno) #54246 lib: * (SEMVER-MINOR) rewrite AsyncLocalStorage without async_hooks (Stephen Belanger) #48528 module: * (SEMVER-MINOR) add --experimental-transform-types flag (Marco Ippolito) #54283 * (SEMVER-MINOR) unflag detect-module (Geoffrey Booth) #53619 PR-URL: #54452
@dlarocquedlarocque mentioned this pull request Aug 23, 2024
Closed
@ronagronag mentioned this pull request Aug 29, 2024
Closed
@targostargos added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Sep 21, 2024
@ramidzkhramidzkh mentioned this pull request Oct 2, 2024
Closed
@avivkelleravivkeller mentioned this pull request Oct 17, 2024
Open
@ronagronag mentioned this pull request Oct 21, 2024
Open
7 tasks
@ChALkeR
Copy link
Member

ChALkeR commented Sep 23, 2025

This likely caused #59985

@ChALkeRChALkeR mentioned this pull request Oct 26, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lemirelemirelemire approved these changes

@benjamingrbenjamingrbenjamingr approved these changes

@anonriganonriganonrig approved these changes

@mcollinamcollinaAwaiting requested review from mcollina

@targostargosAwaiting requested review from targos

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.bufferIssues and PRs related to the buffer subsystem.dont-land-on-v20.xPRs that should not land on the v20.x-staging branch and should not be released in v20.x.needs-ciPRs that need a full CI run.notable-changePRs with changes that should be highlighted in changelogs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@ronag@nodejs-github-bot@aduh95@ChALkeR@mcollina@lemire@benjamingr@anonrig@targos@jakecastelli