Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34.3k
build: add --without-amaro build flag#54136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
nodejs-github-bot commented Jul 31, 2024
Review requested:
|
marco-ippolito commented Jul 31, 2024
should the flag be added to the vcbuild.bat too? |
codecovbot commented Jul 31, 2024 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #54136 +/- ## ======================================= Coverage 87.06% 87.07% ======================================= Files 643 643 Lines 181576 181576 Branches 34894 34891 -3 ======================================= + Hits 158088 158106 +18 + Misses 16759 16753 -6 + Partials 6729 6717 -12
|
aduh95 commented Jul 31, 2024
Not my area of expertise, and no way for me to test it, but I'd say no based on the fact that |
nodejs-github-bot commented Jul 31, 2024
marco-ippolito left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
nodejs-github-bot commented Aug 1, 2024
nodejs-github-bot commented Aug 1, 2024
nodejs-github-bot commented Aug 2, 2024
nodejs-github-bot commented Aug 2, 2024
Landed in 1e3a347 |
PR-URL: #54136 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
PR-URL: #55798 Refs: #54136 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #55798 Refs: #54136 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: nodejs#55798 Refs: nodejs#54136 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: nodejs#55798 Refs: nodejs#54136 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #55798 Refs: #54136 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #55798 Refs: #54136 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #55798 Refs: #54136 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #55798 Refs: #54136 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #55798 Refs: #54136 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #55798 Refs: #54136 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #55798 Refs: #54136 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
With
./configure --without-amaro, the resultingnodebinary won't contain the Amaro source (which includes the SWC WASM binary). This PR does not remove the--experimental-strip-typesCLI flag, when using this flag an error will be emitted when trying to load amodule-typescriptorcommonjs-typescriptmodule.