src,tools: allow utf-8 in built-in js source code#5418
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Closed
Contributor
trevnorris commented Feb 24, 2016
whoot! LGTM |
bnoordhuisforce-pushed the allow-utf8-in-builtins branch from 730d2c0 to 83773b0CompareMemberAuthor
bnoordhuis commented Feb 25, 2016
PR-URL: nodejs#5418 Reviewed-By: Trevor Norris <[email protected]>
PR-URL: nodejs#5418 Reviewed-By: Trevor Norris <[email protected]>
PR-URL: nodejs#5418 Reviewed-By: Trevor Norris <[email protected]>
bnoordhuisforce-pushed the allow-utf8-in-builtins branch from 83773b0 to 33e51feComparervagg pushed a commit that referenced this pull request Feb 27, 2016
PR-URL: #5418 Reviewed-By: Trevor Norris <[email protected]>
rvagg pushed a commit that referenced this pull request Feb 27, 2016
PR-URL: #5418 Reviewed-By: Trevor Norris <[email protected]>
rvagg pushed a commit that referenced this pull request Feb 27, 2016
PR-URL: #5418 Reviewed-By: Trevor Norris <[email protected]>
rvagg pushed a commit that referenced this pull request Feb 27, 2016
PR-URL: #5418 Reviewed-By: Trevor Norris <[email protected]>
rvagg pushed a commit that referenced this pull request Feb 27, 2016
PR-URL: #5418 Reviewed-By: Trevor Norris <[email protected]>
rvagg pushed a commit that referenced this pull request Feb 27, 2016
PR-URL: #5418 Reviewed-By: Trevor Norris <[email protected]>
Contributor
MylesBorins commented Mar 10, 2016
adding lts-watch @trevnorris feel free to remove if this is not appropriate |
Member
jasnell commented Mar 11, 2016
SGTM for LTS |
Contributor
MylesBorins commented Mar 17, 2016
@bnoordhuis this is not landing cleanly onto v4.x would you have time to backport it? |
Contributor
trevnorris commented Mar 17, 2016
If @bnoordhuis doesn't have time I could take care of it some time next week. |
Contributor
MylesBorins commented Mar 21, 2016
@trevnorris I just got this to land cleanly, although we are getting some fun errors now Seems to happen right after landing the first commit 14df4dc |
Member
jasnell commented Mar 21, 2016
@thealphanerd ... on what platform(s)? |
MemberAuthor
bnoordhuis commented Mar 31, 2016
I can back-port it but I confess I still haven't gotten around to unpacking the development rig where I've set up v4.x. (We plan on breaking out some walls so I've left most of my gear in boxes.) I'll see if I can get around to it this week. |
Contributor
MylesBorins commented Apr 8, 2016
@bnoordhuis hows the walls? 😃 |
bnoordhuis added a commit to bnoordhuis/io.js that referenced this pull request Apr 14, 2016
PR-URL: nodejs#5418 Reviewed-By: Trevor Norris <[email protected]>
bnoordhuis added a commit to bnoordhuis/io.js that referenced this pull request Apr 14, 2016
PR-URL: nodejs#5418 Reviewed-By: Trevor Norris <[email protected]>
bnoordhuis added a commit to bnoordhuis/io.js that referenced this pull request Apr 14, 2016
PR-URL: nodejs#5418 Reviewed-By: Trevor Norris <[email protected]>
MemberAuthor
bnoordhuis commented Apr 14, 2016
@thealphanerd Sorry for the delay. Back-port in #6200; the commits applied cleanly for me, FWIW. |
Contributor
not a problem. It is possible that something landed in the last round of backports that fixed things thanks! |
MylesBorins pushed a commit that referenced this pull request Apr 14, 2016
PR-URL: #5418 Reviewed-By: Trevor Norris <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 14, 2016
PR-URL: #5418 Reviewed-By: Trevor Norris <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 14, 2016
PR-URL: #5418 Reviewed-By: Trevor Norris <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 22, 2016
PR-URL: #5418 Reviewed-By: Trevor Norris <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 22, 2016
PR-URL: #5418 Reviewed-By: Trevor Norris <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 22, 2016
PR-URL: #5418 Reviewed-By: Trevor Norris <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 6, 2016
PR-URL: #5418 Reviewed-By: Trevor Norris <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 6, 2016
PR-URL: #5418 Reviewed-By: Trevor Norris <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 6, 2016
PR-URL: #5418 Reviewed-By: Trevor Norris <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 18, 2016
PR-URL: #5418 Reviewed-By: Trevor Norris <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 18, 2016
PR-URL: #5418 Reviewed-By: Trevor Norris <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 18, 2016
PR-URL: #5418 Reviewed-By: Trevor Norris <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4007 (comment) for background.
The meat is in the first commit, the other two are minor efficiency tweaks.
R=@Fishrock123