doc: require node:process in Events examples#54221
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added doc 
Contributor
aduh95 commented Aug 6, 2024
I don't think this is necessary, |
ContributorAuthor
mfdebian commented Aug 6, 2024
Oh ok! No problem! I just thought about making this change because I had previously made a similar PR that got merged, but if it's not really necessary I'll close it. Thanks for the review! 🙌 |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These
CJSexamples on the Events docs were missing theirnode:processrequirestatements.With this change they'd all match their
ESMcounterparts.Best regards!