test: refactor test_runner tests to change default reporter#54547
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Aug 24, 2024
Review requested:
|
nodejs-github-bot added needs-ci 
Member
avivkeller commented Aug 24, 2024
Note: this PR is part of #54548 |
avivkeller added the test_runner 
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #54547 +/- ## ========================================== - Coverage 87.33% 87.32% -0.01% ========================================== Files 649 649 Lines 182622 182623 +1 Branches 35037 35044 +7 ========================================== - Hits 159494 159483 -11 - Misses 16393 16401 +8 - Partials 6735 6739 +4 |
ContributorAuthor
cjihrig commented Aug 25, 2024
|
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Aug 25, 2024
Member
avivkeller commented Aug 25, 2024
It's also failing in a few other places, like https://ci.nodejs.org/job/node-test-binary-windows-js-suites/29545/testReport/ |
benjamingr approved these changes Aug 25, 2024
Member
jakecastelli commented Aug 25, 2024
Member
jakecastelli commented Aug 26, 2024
Issue has been resolved, would you mind rebasing 🙏 I will try to follow up with the CI |
jasnell approved these changes Aug 26, 2024
This commit updates the test runner tests in order to switch the default reporter from tap to spec. This commit can be backported, while changing the default reporter cannot. Refs: nodejs#54540
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Aug 26, 2024
cjihrig added request-ci github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Aug 26, 2024
MoLow approved these changes Aug 26, 2024
Collaborator
jakecastelli approved these changes Aug 27, 2024
jakecastelli added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Aug 27, 2024
Landed in 3d5357a |
RafaelGSS pushed a commit that referenced this pull request Aug 30, 2024
This commit updates the test runner tests in order to switch the default reporter from tap to spec. This commit can be backported, while changing the default reporter cannot. Refs: #54540 PR-URL: #54547 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Aug 30, 2024
This commit updates the test runner tests in order to switch the default reporter from tap to spec. This commit can be backported, while changing the default reporter cannot. Refs: #54540 PR-URL: #54547 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]>
Merged
targos added the dont-land-on-v20.x louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
This commit updates the test runner tests in order to switch the default reporter from tap to spec. This commit can be backported, while changing the default reporter cannot. Refs: nodejs#54540 PR-URL: nodejs#54547 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates the test runner tests in order to switch the default reporter from tap to spec. This commit can be backported, while changing the default reporter cannot.
This will also allow us to more slowly migrate the tests off of using the TAP reporter in some places. We should still test the TAP reporter though. In some cases the TAP reporter is beneficial for testing purposes - for example, verifying that tests are output with the correct test number ordering.
Refs: #54540