Engine method rsa#5463

sam-github · 2016-02-27T03:24:09Z

ENGINE_METHOD_PKEY_METH and ENGINE_METHOD_PKEY_ASN1_METH are misspelled in the documentation, both should be ..._METHS. constants.ENGINE_METHOD_RSA was documented, but not implemented.

This is semver-minor I guess, it introduces a new constant, albeit one that was documented to already exist.

sam-github · 2016-02-27T03:24:56Z

/to @indutny

indutny · 2016-02-27T03:31:20Z

LGTM, though, I would land documentation fix separately to backport it to LTS.

sam-github · 2016-02-27T03:41:43Z

@indutny Thanks. The doc change is a separate commit from the new crypto constant, so they can be cherry-picked independently.

constants.ENGINE_METHOD_RSA was documented, but not implemented. PR-URL: nodejs#5463 Reviewed-By: Fedor Indutny <[email protected]>

ENGINE_METHOD_PKEY_METH and ENGINE_METHOD_PKEY_ASN1_METH are misspelled in the documentation, both should be ..._METHS. PR-URL: nodejs#5463 Reviewed-By: Fedor Indutny <[email protected]>

sam-github · 2016-02-27T03:50:54Z

@indutny Hm, I hope I didn't close that too fast... it seemed trivial enough that your OK would be sufficient, I can't imagine any debate.

jasnell · 2016-03-02T16:17:48Z

Looks good, good catch on this. I'll mark this lts-watch with the caveat that only 513133c would be backported. /cc @thealphanerd

sam-github · 2016-03-06T05:48:04Z

For my future reference: does it work better with the tracking machinery that entire PRs are either backportable or not, or is it sufficient that standalone commits are back-portable or not?

@jasnell @Fishrock123

jasnell · 2016-03-07T18:06:10Z

Generally full PRs as the tools that pull this stuff out use the PR reference as opposed to the individual commit reference. What would likely be easiest is having a new PR that contains just the backported commit opened against v4.x-staging.

constants.ENGINE_METHOD_RSA was documented, but not implemented. PR-URL: #5463 Reviewed-By: Fedor Indutny <[email protected]>

ENGINE_METHOD_PKEY_METH and ENGINE_METHOD_PKEY_ASN1_METH are misspelled in the documentation, both should be ..._METHS. PR-URL: #5463 Reviewed-By: Fedor Indutny <[email protected]>

constants.ENGINE_METHOD_RSA was documented, but not implemented. PR-URL: #5463 Reviewed-By: Fedor Indutny <[email protected]>

ENGINE_METHOD_PKEY_METH and ENGINE_METHOD_PKEY_ASN1_METH are misspelled in the documentation, both should be ..._METHS. PR-URL: #5463 Reviewed-By: Fedor Indutny <[email protected]>

Notable changes: * child_process: “send()” now accepts an options parameter (cjihrig) #5283 - Currently the only option is “keepOpen”, which keeps the underlying socket open after the message is sent. * constants: “ENGINE_METHOD_RSA” is now correctly exposed (Sam Roberts) #5463 * Fixed two regressions which originated in v5.7.0: - http: Errors inside of http client callbacks now propagate correctly (Trevor Norris) #5591 - path: Fixed normalization of absolute paths (Evan Lucas) #5589 * repl: “start()” no longer requires an options parameter (cjihrig) #5388 * util: Improved “format()” performance 50-300% (Evan Lucas) #5360 PR-URL: #5559

Notable changes: * child_process: “send()” now accepts an options parameter (cjihrig) nodejs#5283 - Currently the only option is “keepOpen”, which keeps the underlying socket open after the message is sent. * constants: “ENGINE_METHOD_RSA” is now correctly exposed (Sam Roberts) nodejs#5463 * Fixed two regressions which originated in v5.7.0: - http: Errors inside of http client callbacks now propagate correctly (Trevor Norris) nodejs#5591 - path: Fixed normalization of absolute paths (Evan Lucas) nodejs#5589 * repl: “start()” no longer requires an options parameter (cjihrig) nodejs#5388 * util: Improved “format()” performance 50-300% (Evan Lucas) nodejs#5360 PR-URL: nodejs#5559

sam-github · 2016-03-11T04:42:24Z

What would likely be easiest is having a new PR that contains just the backported commit opened against v4.x-staging.

@jasnell so do you want me to do that, or is that a "next time" comment?

jasnell · 2016-03-11T04:45:15Z

If you're able and willing to :)
On Mar 10, 2016 8:42 PM, "Sam Roberts" [email protected] wrote:

What would likely be easiest is having a new PR that contains just the
backported commit opened against v4.x-staging.
@jasnell https://github.com/jasnell so do you want me to do that, or is
that a "next time" comment?
—
Reply to this email directly or view it on GitHub
#5463 (comment).

sam-github · 2016-04-01T20:12:59Z

@thealphanerd so, you want me to PR just f80c1c4 against v4.x?

sam-github · 2017-01-25T19:06:25Z

@MylesBorins both these commits should land on v4.x

sam-github · 2017-01-25T19:20:14Z

Ah, I see. The API docs were renamed from .markdown to .md. Not so clear on why that was worth the price.

backport #11002

constants.ENGINE_METHOD_RSA was documented, but not implemented. PR-URL: nodejs#5463 Reviewed-By: Fedor Indutny <[email protected]>

ENGINE_METHOD_PKEY_METH and ENGINE_METHOD_PKEY_ASN1_METH are misspelled in the documentation, both should be ..._METHS. PR-URL: nodejs#5463 Reviewed-By: Fedor Indutny <[email protected]>

Original Commit Message: constants.ENGINE_METHOD_RSA was documented, but not implemented. PR-URL: #5463 Reviewed-By: Fedor Indutny <[email protected]> Backport-Of: #5463 PR-URL: #11002 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>

Original Commit Message: ENGINE_METHOD_PKEY_METH and ENGINE_METHOD_PKEY_ASN1_METH are misspelled in the documentation, both should be ..._METHS. PR-URL: #5463 Reviewed-By: Fedor Indutny <[email protected]> Backport-Of: #5463 PR-URL: #11002 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>

Original Commit Message: constants.ENGINE_METHOD_RSA was documented, but not implemented. PR-URL: #5463 Reviewed-By: Fedor Indutny <[email protected]> Backport-Of: #5463 PR-URL: #11002 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>

Original Commit Message: ENGINE_METHOD_PKEY_METH and ENGINE_METHOD_PKEY_ASN1_METH are misspelled in the documentation, both should be ..._METHS. PR-URL: #5463 Reviewed-By: Fedor Indutny <[email protected]> Backport-Of: #5463 PR-URL: #11002 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>

Original Commit Message: constants.ENGINE_METHOD_RSA was documented, but not implemented. PR-URL: #5463 Reviewed-By: Fedor Indutny <[email protected]> Backport-Of: #5463 PR-URL: #11002 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>

Original Commit Message: ENGINE_METHOD_PKEY_METH and ENGINE_METHOD_PKEY_ASN1_METH are misspelled in the documentation, both should be ..._METHS. PR-URL: #5463 Reviewed-By: Fedor Indutny <[email protected]> Backport-Of: #5463 PR-URL: #11002 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>

Original Commit Message: constants.ENGINE_METHOD_RSA was documented, but not implemented. PR-URL: #5463 Reviewed-By: Fedor Indutny <[email protected]> Backport-Of: #5463 PR-URL: #11002 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>

Original Commit Message: ENGINE_METHOD_PKEY_METH and ENGINE_METHOD_PKEY_ASN1_METH are misspelled in the documentation, both should be ..._METHS. PR-URL: #5463 Reviewed-By: Fedor Indutny <[email protected]> Backport-Of: #5463 PR-URL: #11002 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>

Original Commit Message: constants.ENGINE_METHOD_RSA was documented, but not implemented. PR-URL: nodejs#5463 Reviewed-By: Fedor Indutny <[email protected]> Backport-Of: nodejs#5463 PR-URL: nodejs#11002 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>

Original Commit Message: ENGINE_METHOD_PKEY_METH and ENGINE_METHOD_PKEY_ASN1_METH are misspelled in the documentation, both should be ..._METHS. PR-URL: nodejs#5463 Reviewed-By: Fedor Indutny <[email protected]> Backport-Of: nodejs#5463 PR-URL: nodejs#11002 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>

sam-github added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. semver-minor PRs that contain new features and should be released in the next minor version. labels Feb 27, 2016

sam-github added 2 commits February 26, 2016 19:42

constants: define ENGINE_METHOD_RSA
292033b
constants.ENGINE_METHOD_RSA was documented, but not implemented. PR-URL: nodejs#5463 Reviewed-By: Fedor Indutny <[email protected]>

doc: correct name of engine methods
513133c
ENGINE_METHOD_PKEY_METH and ENGINE_METHOD_PKEY_ASN1_METH are misspelled in the documentation, both should be ..._METHS. PR-URL: nodejs#5463 Reviewed-By: Fedor Indutny <[email protected]>

sam-github force-pushed the engine-method-rsa branch from aacdf8a to 513133cCompare February 27, 2016 03:44

sam-github merged commit 513133c into nodejs:masterFeb 27, 2016

sam-github deleted the engine-method-rsa branch February 27, 2016 03:49

Fishrock123 mentioned this pull request Mar 1, 2016
Release proposal: v5.7.1 #5464
Merged
5 tasks

jasnell added the lts-watch-v4.x label Mar 2, 2016

Fishrock123 mentioned this pull request Mar 8, 2016
v5.8.0 proposal #5559
Merged

Fishrock123 pushed a commit that referenced this pull request Mar 8, 2016
constants: define ENGINE_METHOD_RSA
a161549
constants.ENGINE_METHOD_RSA was documented, but not implemented. PR-URL: #5463 Reviewed-By: Fedor Indutny <[email protected]>

Fishrock123 pushed a commit that referenced this pull request Mar 8, 2016
constants: define ENGINE_METHOD_RSA
9db827c
constants.ENGINE_METHOD_RSA was documented, but not implemented. PR-URL: #5463 Reviewed-By: Fedor Indutny <[email protected]>

MylesBorins added land-on-v4.x and removed lts-watch-v4.x labels Mar 17, 2016

sam-github added lts-watch-v4.x and removed dont-land-on-v4.x labels Jan 25, 2017

sam-github added a commit to sam-github/node that referenced this pull request Feb 22, 2017
constants: define ENGINE_METHOD_RSA
6f92c50
constants.ENGINE_METHOD_RSA was documented, but not implemented. PR-URL: nodejs#5463 Reviewed-By: Fedor Indutny <[email protected]>

Uh oh!

Engine method rsa#5463

Engine method rsa #5463

Uh oh!

Conversation

sam-github commented Feb 27, 2016

Uh oh!

sam-github commented Feb 27, 2016

Uh oh!

indutny commented Feb 27, 2016

Uh oh!

sam-github commented Feb 27, 2016

Uh oh!

sam-github commented Feb 27, 2016

Uh oh!

jasnell commented Mar 2, 2016

Uh oh!

sam-github commented Mar 6, 2016

Uh oh!

jasnell commented Mar 7, 2016

Uh oh!

sam-github commented Mar 11, 2016

Uh oh!

jasnell commented Mar 11, 2016

Uh oh!

sam-github commented Apr 1, 2016

Uh oh!

sam-github commented Jan 25, 2017

Uh oh!

sam-github commented Jan 25, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants