Skip to content

esm: do not interpret "main" as a URL#55003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 3 commits into from
Sep 27, 2024
Merged

esm: do not interpret "main" as a URL #55003

nodejs-github-bot merged 3 commits into from
Sep 27, 2024

Conversation

@aduh95
Copy link
Contributor

@aduh95aduh95 commented Sep 19, 2024

As documented, its value is a path.

node/doc/api/packages.md

Lines 1210 to 1211 in c42d846

The `"main"` field defines the entry point of a package when imported by name
via a `node_modules` lookup. Its value is a path.

@aduh95
esm: do not interpret "main" as a URL
7e25f19
As documented, its value is a path.
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 19, 2024

Review requested:

  • @nodejs/loaders

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. esm Issues and PRs related to the ECMAScript Modules implementation. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Sep 19, 2024
avivkeller
avivkeller reviewed Sep 19, 2024
View reviewed changes
@codecov
Copy link

codecovbot commented Sep 19, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.03%. Comparing base (c42d846) to head (f0c3a2c).
Report is 480 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #55003 +/- ## ======================================= Coverage 88.03% 88.03% ======================================= Files 652 652 Lines 183759 183744 -15 Branches 35861 35853 -8 ======================================= - Hits 161770 161766 -4 + Misses 15239 15229 -10 + Partials 6750 6749 -1
Files with missing linesCoverage Δ
lib/internal/modules/esm/resolve.js96.62% <100.00%> (-0.01%)⬇️
src/node_file.cc77.36% <100.00%> (+0.26%)⬆️

... and 31 files with indirect coverage changes

@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 20, 2024
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 20, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 20, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/62587/

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 27, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 27, 2024
@nodejs-github-botnodejs-github-bot merged commit fb85279 into nodejs:mainSep 27, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 27, 2024

Landed in fb85279

@aduh95aduh95 deleted the main-is-a-path branch September 27, 2024 14:45
targos pushed a commit that referenced this pull request Oct 4, 2024
@aduh95@targos
esm: do not interpret "main" as a URL
fe866e3
As documented, its value is a path. PR-URL: #55003 Reviewed-By: Benjamin Gruenbaum <[email protected]>
targos pushed a commit that referenced this pull request Oct 4, 2024
@aduh95@targos
esm: do not interpret "main" as a URL
0fb446e
As documented, its value is a path. PR-URL: #55003 Reviewed-By: Benjamin Gruenbaum <[email protected]>
@aduh95aduh95 mentioned this pull request Oct 9, 2024
Merged
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@aduh95@louwers
esm: do not interpret "main" as a URL
7a7b215
As documented, its value is a path. PR-URL: nodejs#55003 Reviewed-By: Benjamin Gruenbaum <[email protected]>
@marco-ippolitomarco-ippolito added the backport-blocked-v20.x PRs that should land on the v20.x-staging branch but are blocked by another PR's pending backport. label Nov 16, 2024
codebytere added a commit to electron/electron that referenced this pull request Nov 20, 2024
@codebytere
esm: do not interpret "main" as a URL
3d8221c
nodejs/node#55003
codebytere added a commit to electron/electron that referenced this pull request Nov 20, 2024
@codebytere
esm: do not interpret "main" as a URL
af06538
nodejs/node#55003
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
@aduh95@tpoisseau
esm: do not interpret "main" as a URL
f0c9f2c
As documented, its value is a path. PR-URL: nodejs#55003 Reviewed-By: Benjamin Gruenbaum <[email protected]>
codebytere added a commit to electron/electron that referenced this pull request Nov 21, 2024
@codebytere
esm: do not interpret "main" as a URL
0dbd423
nodejs/node#55003
codebytere added a commit to electron/electron that referenced this pull request Dec 3, 2024
@codebytere
esm: do not interpret "main" as a URL
98f1f75
nodejs/node#55003
codebytere added a commit to electron/electron that referenced this pull request Dec 4, 2024
@codebytere
esm: do not interpret "main" as a URL
b80cd2b
nodejs/node#55003
codebytere added a commit to electron/electron that referenced this pull request Jan 22, 2025
@codebytere
esm: do not interpret "main" as a URL
2a1c1ec
nodejs/node#55003
samuelmaddock pushed a commit to electron/electron that referenced this pull request Jan 22, 2025
@electron-roller@codebytere
chore: bump node to v22.11.0 (main) (#44530)
863faea
* chore: bump node in DEPS to v22.11.0 * src: move evp stuff to ncrypto nodejs/node#54911 * crypto: add Date fields for validTo and validFrom nodejs/node#54159 * module: fix discrepancy between .ts and .js nodejs/node#54461 * esm: do not interpret "main" as a URL nodejs/node#55003 * src: modernize likely/unlikely hints nodejs/node#55155 * chore: update patch indices * crypto: add validFromDate and validToDate fields to X509Certificate nodejs/node#54159 * chore: fixup perfetto patch * fix: clang warning in simdjson * src: add receiver to fast api callback methods nodejs/node#54408 * chore: fixup revert patch * fixup! esm: do not interpret "main" as a URL * fixup! crypto: add Date fields for validTo and validFrom * fix: move ArrayBuffer test patch * src: fixup Error.stackTraceLimit during snapshot building nodejs/node#55121 * fix: bad rebase * chore: fixup amaro * chore: address feedback from review * src: revert filesystem::path changes nodejs/node#55015 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <[email protected]>
soobinrho pushed a commit to soobinrho/electron that referenced this pull request Jan 22, 2025
@electron-roller@codebytere@soobinrho
chore: bump node to v22.11.0 (main) (electron#44530)
8c4d83f
* chore: bump node in DEPS to v22.11.0 * src: move evp stuff to ncrypto nodejs/node#54911 * crypto: add Date fields for validTo and validFrom nodejs/node#54159 * module: fix discrepancy between .ts and .js nodejs/node#54461 * esm: do not interpret "main" as a URL nodejs/node#55003 * src: modernize likely/unlikely hints nodejs/node#55155 * chore: update patch indices * crypto: add validFromDate and validToDate fields to X509Certificate nodejs/node#54159 * chore: fixup perfetto patch * fix: clang warning in simdjson * src: add receiver to fast api callback methods nodejs/node#54408 * chore: fixup revert patch * fixup! esm: do not interpret "main" as a URL * fixup! crypto: add Date fields for validTo and validFrom * fix: move ArrayBuffer test patch * src: fixup Error.stackTraceLimit during snapshot building nodejs/node#55121 * fix: bad rebase * chore: fixup amaro * chore: address feedback from review * src: revert filesystem::path changes nodejs/node#55015 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <[email protected]>
codebytere added a commit to electron/electron that referenced this pull request Feb 3, 2025
@codebytere
esm: do not interpret "main" as a URL
29d6935
nodejs/node#55003
codebytere added a commit to electron/electron that referenced this pull request Feb 10, 2025
@codebytere
esm: do not interpret "main" as a URL
fee60cd
nodejs/node#55003
codebytere added a commit to electron/electron that referenced this pull request Feb 10, 2025
@codebytere
esm: do not interpret "main" as a URL
91a5be1
nodejs/node#55003
codebytere added a commit to electron/electron that referenced this pull request Feb 14, 2025
@codebytere
esm: do not interpret "main" as a URL
cc6f2a5
nodejs/node#55003
codebytere added a commit to electron/electron that referenced this pull request Feb 14, 2025
@electron-roller@codebytere
chore: bump node to v22.13.1 (35-x-y) (#45216)
bc163a5
* chore: bump node in DEPS to v22.13.0 * chore: bump node in DEPS to v22.13.1 * src: move evp stuff to ncrypto nodejs/node#54911 * crypto: add Date fields for validTo and validFrom nodejs/node#54159 * module: fix discrepancy between .ts and .js nodejs/node#54461 * esm: do not interpret "main" as a URL nodejs/node#55003 * src: modernize likely/unlikely hints nodejs/node#55155 * chore: update patch indices * crypto: add validFromDate and validToDate fields to X509Certificate nodejs/node#54159 * chore: fixup perfetto patch * fix: clang warning in simdjson * src: add receiver to fast api callback methods nodejs/node#54408 * chore: fixup revert patch * fixup! esm: do not interpret "main" as a URL * fixup! crypto: add Date fields for validTo and validFrom * fix: move ArrayBuffer test patch * src: fixup Error.stackTraceLimit during snapshot building nodejs/node#55121 * fix: bad rebase * chore: fixup amaro * chore: address feedback from review * src: revert filesystem::path changes nodejs/node#55015 * chore: fixup GN build file * nodejs/node#55529 * nodejs/node#55798 * nodejs/node#55530 * module: simplify --inspect-brk handling nodejs/node#55679 * src: fix outdated js2c.cc references nodejs/node#56133 * crypto: include openssl/rand.h explicitly nodejs/node#55425 * build: use variable for crypto dep path nodejs/node#55928 * crypto: fix RSA_PKCS1_PADDING error message nodejs/node#55629 * build: use variable for simdutf path nodejs/node#56196 * test,crypto: make crypto tests work with BoringSSL nodejs/node#55491 * fix: suppress clang -Wdeprecated-declarations in libuv libuv/libuv#4486 * deps: update libuv to 1.49.1 nodejs/node#55114 * test: make test-node-output-v8-warning more flexible nodejs/node#55401 * [v22.x] Revert "v8: enable maglev on supported architectures" nodejs/node#54384 * fix: potential WIN32_LEAN_AND_MEAN redefinition c-ares/c-ares#869 * deps: update nghttp2 to 1.64.0 nodejs/node#55559 * src: provide workaround for container-overflow nodejs/node#55591 * build: use variable for simdutf path nodejs/node#56196 * chore: fixup patch indices * fixup! module: simplify --inspect-brk handling * lib: fix fs.readdir recursive async nodejs/node#56041 * lib: avoid excluding symlinks in recursive fs.readdir with filetypes nodejs/node#55714 This doesn't currently play well with ASAR - this should be fixed in a follow up * test: disable CJS permission test for config.main This has diverged as a result of our revert of src,lb: reducing C++ calls of esm legacy main resolve * fixup! lib: fix fs.readdir recursive async * deps: update libuv to 1.49.1 nodejs/node#55114 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@avivkelleravivkelleravivkeller left review comments

@benjamingrbenjamingrbenjamingr approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.backport-blocked-v20.xPRs that should land on the v20.x-staging branch but are blocked by another PR's pending backport.c++Issues and PRs that require attention from people who are familiar with C++.esmIssues and PRs related to the ECMAScript Modules implementation.fsIssues and PRs related to the fs subsystem / file system.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aduh95@nodejs-github-bot@benjamingr@avivkeller@marco-ippolito