test,crypto: update WebCryptoAPI WPT#55029
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
panva added crypto 
Collaborator
nodejs-github-bot commented Sep 20, 2024
Review requested:
|
Collaborator
nodejs-github-bot commented Sep 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #55029 +/- ## ========================================== - Coverage 88.06% 88.03% -0.04% ========================================== Files 652 652 Lines 183546 183797 +251 Branches 35860 35861 +1 ========================================== + Hits 161648 161801 +153 - Misses 15149 15243 +94 - Partials 6749 6753 +4 |
lpinca approved these changes Sep 21, 2024
github-actionsbot removed the request-ci Collaborator
panva added the author ready 
jakecastelli approved these changes Sep 21, 2024
panva added the commit-queue 
jasnell approved these changes Sep 21, 2024
nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Sep 22, 2024
Landed in 0e187e4 |
targos pushed a commit that referenced this pull request Oct 4, 2024
PR-URL: #55029 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
PR-URL: nodejs#55029 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: James M Snell <[email protected]>
marco-ippolito added the backport-requested-v20.x tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
PR-URL: nodejs#55029 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just
git node wpt WebCryptoAPI.