Skip to content

Conversation

@avivkeller
Copy link
Member

@avivkelleravivkeller commented Sep 30, 2024

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. test_runner Issues and PRs related to the test runner subsystem. labels Sep 30, 2024
@avivkelleravivkeller added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Sep 30, 2024
@cjihrigcjihrig requested review from aduh95 and mcollinaOctober 3, 2024 15:39
@avivkelleravivkeller added the review wanted PRs that need reviews. label Oct 30, 2024
@cjihrigcjihrig removed their request for review December 5, 2024 02:30
@avivkeller
Copy link
MemberAuthor

Bump @mcollina@aduh95 for reviews

**Note:** A number of CLI flags will not function properly when used with
`execArgv`, and users should avoid using it unless they have a deep
understanding of its implications. In general, bug reports regarding this
behavior will not be investigated.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have the list somewhere, right? We should link it.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last time I checked I don't think we did.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If not, we should probably add one or this note really is not going to be very useful for folks.

@avivkelleravivkeller closed this by deleting the head repository Dec 18, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.docIssues and PRs related to the documentations.review wantedPRs that need reviews.test_runnerIssues and PRs related to the test runner subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@avivkeller@nodejs-github-bot@mcollina@jasnell