module: add internal type def for flushCompileCache#55226
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
JakobJingleheimer added module 
anonrig approved these changes Oct 1, 2024
JakobJingleheimer added author ready 
Contributor
Fast-track has been requested by @JakobJingleheimer. Please 👍 to approve. |
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Oct 1, 2024
JakobJingleheimer added commit-queue 
nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Oct 2, 2024
Commit Queue failed- Loading data for nodejs/node/pull/55226 ✔ Done loading data for nodejs/node/pull/55226 ----------------------------------- PR info ------------------------------------ Title module: add internal type def for `flushCompileCache` (#55226) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch JakobJingleheimer:feat/module-ts-d-flushCompileCache -> nodejs:main Labels module, fast-track, author ready, typings, loaders, commit-queue-squash Commits 1 - module: add internal type def for `flushCompileCache` Committers 1 - Jacob Smith <[email protected]> PR-URL: https://github.com/nodejs/node/pull/55226 Reviewed-By: Yagiz Nizipli <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/55226 Reviewed-By: Yagiz Nizipli <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 01 Oct 2024 18:52:33 GMT ✔ Approvals: 1 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/55226#pullrequestreview-2341362421 ℹ This PR is being fast-tracked ✘ This PR needs to wait 143 more hours to land (or 23 hours if there is one more approval) (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators). ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/11149822812 |
nodejs-github-bot added the commit-queue-failed 
H4ad approved these changes Oct 3, 2024
H4ad added commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Oct 3, 2024
Landed in 5e4da33 |
targos pushed a commit that referenced this pull request Oct 4, 2024
PR-URL: #55226 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
targos pushed a commit that referenced this pull request Oct 4, 2024
PR-URL: #55226 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Merged
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
PR-URL: nodejs#55226 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
marco-ippolito added the dont-land-on-v20.x tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
PR-URL: nodejs#55226 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a type def for the util from #54971