test_runner: fix TypeError exception when --enable-source-maps is passed#55231

geeksilva97 · 2024-10-02T03:32:39Z

Split of #55228

nodejs-github-bot · 2024-10-02T03:32:44Z

Review requested:

@nodejs/test_runner

lib/internal/test_runner/test.js

codecov · 2024-10-02T05:04:09Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.41%. Comparing base (bbdfeeb) to head (b208245).
Report is 6 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #55231 +/- ## ========================================== - Coverage 88.41% 88.41% -0.01%  ========================================== Files 652 652 Lines 186612 186612 Branches 36062 36063 +1 ========================================== - Hits 165001 164997 -4 + Misses 14885 14883 -2 - Partials 6726 6732 +6

Files with missing lines	Coverage Δ
lib/internal/test_runner/test.js	`96.98% <100.00%> (ø)`

... and 33 files with indirect coverage changes

lib/internal/test_runner/test.js

cjihrig

LGTM once the test is updated. It's odd that this does not appear to be an issue on Node 22.

test/parallel/test-runner-coverage.js

test/parallel/test-runner-enable-source-maps-issue.js

nodejs-github-bot · 2024-10-02T14:30:22Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62894/

nodejs-github-bot · 2024-10-03T13:10:45Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62902/

nodejs-github-bot · 2024-10-04T03:35:00Z

Commit Queue failed

- Loading data for nodejs/node/pull/55231 ✔ Done loading data for nodejs/node/pull/55231 ----------------------------------- PR info ------------------------------------ Title test_runner: fix TypeError exception when --enable-source-maps is passed (#55231) Author Edigleysson Silva (Edy) <[email protected]> (@geeksilva97) Branch geeksilva97:fix-test-runner-when-source-maps-is-enabled -> nodejs:main Labels author ready, commit-queue-squash, test_runner Commits 3 - test_runner: assert entry is a valid object - test: test case when --enable-source-maps is provided - test: move --enable-source-maps test to a single file Committers 1 - Edy Silva <[email protected]> PR-URL: https://github.com/nodejs/node/pull/55231 Reviewed-By: Colin Ihrig <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/55231 Reviewed-By: Colin Ihrig <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 02 Oct 2024 03:32:39 GMT ✔ Approvals: 1 ✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/55231#pullrequestreview-2343110183 ✘ This PR needs to wait 119 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-10-03T13:10:45Z: https://ci.nodejs.org/job/node-test-pull-request/62902/ - Querying data for job/node-test-pull-request/62902/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/11173525108

nodejs-github-bot · 2024-10-05T17:42:09Z

Commit Queue failed

- Loading data for nodejs/node/pull/55231 ✔ Done loading data for nodejs/node/pull/55231 ----------------------------------- PR info ------------------------------------ Title test_runner: fix TypeError exception when --enable-source-maps is passed (#55231) Author Edigleysson Silva (Edy) <[email protected]> (@geeksilva97) Branch geeksilva97:fix-test-runner-when-source-maps-is-enabled -> nodejs:main Labels author ready, commit-queue-squash, test_runner Commits 3 - test_runner: assert entry is a valid object - test: test case when --enable-source-maps is provided - test: move --enable-source-maps test to a single file Committers 1 - Edy Silva <[email protected]> PR-URL: https://github.com/nodejs/node/pull/55231 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/55231 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 02 Oct 2024 03:32:39 GMT ✔ Approvals: 2 ✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/55231#pullrequestreview-2343110183 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/55231#pullrequestreview-2349881585 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-10-04T03:35:00Z: https://ci.nodejs.org/job/node-test-pull-request/62902/ - Querying data for job/node-test-pull-request/62902/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 55231 From https://github.com/nodejs/node * branch refs/pull/55231/merge -> FETCH_HEAD ✔ Fetched commits as 20d8b85d3493..d8a51cf8f8ca -------------------------------------------------------------------------------- [main 20a251ec71] test_runner: assert entry is a valid object Author: Edy Silva <[email protected]> Date: Wed Oct 2 00:05:35 2024 -0300 1 file changed, 2 insertions(+), 1 deletion(-) Auto-merging test/parallel/test-runner-coverage.js CONFLICT (content): Merge conflict in test/parallel/test-runner-coverage.js error: could not apply f5c4c40689... test: test case when --enable-source-maps is provided hint: After resolving the conflicts, mark them with hint: "git add/rm <pathspec>", then run hint: "git cherry-pick --continue". hint: You can instead skip this commit with "git cherry-pick --skip". hint: To abort and get back to the state before "git cherry-pick", hint: run "git cherry-pick --abort". hint: Disable this message with "git config advice.mergeConflict false" ✘ Failed to apply patches

https://github.com/nodejs/node/actions/runs/11195118022

MoLow · 2024-10-05T17:50:30Z

@geeksilva97 unfortunately, this PR needs a rebase

geeksilva97 · 2024-10-05T18:25:49Z

@geeksilva97 unfortunately, this PR needs a rebase

Will do

EDIT: done

nodejs-github-bot · 2024-10-05T19:16:37Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62933/

mcollina

Lgtm

nodejs-github-bot · 2024-10-06T18:12:36Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62946/

nodejs-github-bot · 2024-10-06T19:47:01Z

Landed in 980b91a

PR-URL: #55231 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

PR-URL: nodejs#55231 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

PR-URL: #55231 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [node](https://nodejs.org) ([source](https://github.com/nodejs/node)) | patch | `20.18.0` -> `20.18.1` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>nodejs/node (node)</summary> ### [`v20.18.1`](https://github.com/nodejs/node/releases/tag/v20.18.1): 2024-11-20, Version 20.18.1 'Iron' (LTS), @marco-ippolito [Compare Source](nodejs/node@v20.18.0...v20.18.1) ##### Notable Changes - \[[`7a8992b2d6`](nodejs/node@7a8992b2d6)] - **doc**: add abmusse to collaborators (Abdirahim Musse) [#55086](nodejs/node#55086) ##### Commits - \[[`085c3441fe`](nodejs/node@085c3441fe)] - **assert**: show the diff when deep comparing data with a custom message (Giovanni) [#54759](nodejs/node#54759) - \[[`01f0b0e7b4`](nodejs/node@01f0b0e7b4)] - **benchmark**: adjust config for deepEqual object (Rafael Gonzaga) [#55254](nodejs/node#55254) - \[[`a45537269b`](nodejs/node@a45537269b)] - **benchmark**: rewrite detect-esm-syntax benchmark (Joyee Cheung) [#55238](nodejs/node#55238) - \[[`1a0d8ef64f`](nodejs/node@1a0d8ef64f)] - **benchmark**: add no-warnings to process.has bench (Rafael Gonzaga) [#55159](nodejs/node#55159) - \[[`2be5d611ce`](nodejs/node@2be5d611ce)] - **benchmark**: create benchmark for typescript (Marco Ippolito) [#54904](nodejs/node#54904) - \[[`a2aa4fa477`](nodejs/node@a2aa4fa477)] - **benchmark**: include ascii to fs/readfile (Rafael Gonzaga) [#54988](nodejs/node#54988) - \[[`09849105fe`](nodejs/node@09849105fe)] - **benchmark**: add dotenv benchmark (Aviv Keller) [#54278](nodejs/node#54278) - \[[`6b3c24dbad`](nodejs/node@6b3c24dbad)] - **buffer**: fix out of range for toString (Jason Zhang) [#54553](nodejs/node#54553) - \[[`f25a5b6dc4`](nodejs/node@f25a5b6dc4)] - **build**: use rclone instead of aws CLI (Michaël Zasso) [#55617](nodejs/node#55617) - \[[`0bbeb605de`](nodejs/node@0bbeb605de)] - **build**: fix notify-on-review-wanted action (Rafael Gonzaga) [#55304](nodejs/node#55304) - \[[`5b35836732`](nodejs/node@5b35836732)] - **build**: include `.nycrc` in coverage workflows (Wuli Zuo) [#55210](nodejs/node#55210) - \[[`f38d1e90e0`](nodejs/node@f38d1e90e0)] - **build**: notify via slack when review-wanted (Rafael Gonzaga) [#55102](nodejs/node#55102) - \[[`0b985ec4bb`](nodejs/node@0b985ec4bb)] - **build**: remove -v flag to reduce noise (iwuliz) [#55025](nodejs/node#55025) - \[[`09f75b27a1`](nodejs/node@09f75b27a1)] - **build**: display free disk space after build in the test-macOS workflow (iwuliz) [#55025](nodejs/node#55025) - \[[`f25760c4a2`](nodejs/node@f25760c4a2)] - **build**: add the option to generate compile_commands.json in vcbuild.bat (Segev Finer) [#52279](nodejs/node#52279) - \[[`746e78c4f3`](nodejs/node@746e78c4f3)] - ***Revert*** "**build**: upgrade clang-format to v18" (Chengzhong Wu) [#54994](nodejs/node#54994) - \[[`67834ee646`](nodejs/node@67834ee646)] - **build**: print `Running XYZ linter...` for py and yml (Aviv Keller) [#54386](nodejs/node#54386) - \[[`ae34e276a2`](nodejs/node@ae34e276a2)] - **build**: pin doc workflow to Node.js 20 (Richard Lau) [#55755](nodejs/node#55755) - \[[`d0e871a706`](nodejs/node@d0e871a706)] - **build,win**: add winget config to set up env (Hüseyin Açacak) [#54729](nodejs/node#54729) - \[[`93ac799b6b`](nodejs/node@93ac799b6b)] - **cli**: fix spacing for port range error (Aviv Keller) [#54495](nodejs/node#54495) - \[[`3ba2e7bf97`](nodejs/node@3ba2e7bf97)] - ***Revert*** "**console**: colorize console error and warn" (Aviv Keller) [#54677](nodejs/node#54677) - \[[`2f678ea53b`](nodejs/node@2f678ea53b)] - **crypto**: ensure invalid SubtleCrypto JWK data import results in DataError (Filip Skokan) [#55041](nodejs/node#55041) - \[[`5d28d98542`](nodejs/node@5d28d98542)] - **deps**: update undici to 6.20.0 (Node.js GitHub Bot) [#55329](nodejs/node#55329) - \[[`0c7f2fc421`](nodejs/node@0c7f2fc421)] - **deps**: update archs files for openssl-3.0.15+quic1 (Node.js GitHub Bot) [#55184](nodejs/node#55184) - \[[`da15e7edf5`](nodejs/node@da15e7edf5)] - **deps**: upgrade openssl sources to quictls/openssl-3.0.15+quic1 (Node.js GitHub Bot) [#55184](nodejs/node#55184) - \[[`381f1f9d08`](nodejs/node@381f1f9d08)] - **deps**: update archs files for openssl-3.0.14+quic1 (Node.js GitHub Bot) [#54336](nodejs/node#54336) - \[[`48d643f78a`](nodejs/node@48d643f78a)] - **deps**: upgrade openssl sources to quictls/openssl-3.0.14+quic1 (Node.js GitHub Bot) [#54336](nodejs/node#54336) - \[[`7b1796803b`](nodejs/node@7b1796803b)] - **deps**: update timezone to 2024b (Node.js GitHub Bot) [#55056](nodejs/node#55056) - \[[`8f1956c588`](nodejs/node@8f1956c588)] - **deps**: update acorn-walk to 8.3.4 (Node.js GitHub Bot) [#54950](nodejs/node#54950) - \[[`20501a7350`](nodejs/node@20501a7350)] - **deps**: update corepack to 0.29.4 (Node.js GitHub Bot) [#54845](nodejs/node#54845) - \[[`0f81eafecc`](nodejs/node@0f81eafecc)] - **doc**: fix Markdown linter (Antoine du Hamel) [#55344](nodejs/node#55344) - \[[`df713f0a98`](nodejs/node@df713f0a98)] - ***Revert*** "**doc**: update test context.assert" (Antoine du Hamel) [#55344](nodejs/node#55344) - \[[`fd6fc61d2c`](nodejs/node@fd6fc61d2c)] - **doc**: add pmarchini to collaborators (Pietro Marchini) [#55331](nodejs/node#55331) - \[[`b963db9ee2`](nodejs/node@b963db9ee2)] - **doc**: fix `events.once()` example using `AbortSignal` (Ivo Janssen) [#55144](nodejs/node#55144) - \[[`50b13bfb12`](nodejs/node@50b13bfb12)] - **doc**: add onboarding details for ambassador program (Marco Ippolito) [#55284](nodejs/node#55284) - \[[`27564b7811`](nodejs/node@27564b7811)] - **doc**: fix initial default value of autoSelectFamily (Ihor Rohovets) [#55245](nodejs/node#55245) - \[[`9e7be23aa5`](nodejs/node@9e7be23aa5)] - **doc**: tweak onboarding instructions (Michael Dawson) [#55212](nodejs/node#55212) - \[[`f412a029c3`](nodejs/node@f412a029c3)] - **doc**: update test context.assert (Pietro Marchini) [#55186](nodejs/node#55186) - \[[`2f7828debb`](nodejs/node@2f7828debb)] - **doc**: fix unordered error anchors (Antoine du Hamel) [#55242](nodejs/node#55242) - \[[`d08e4c235b`](nodejs/node@d08e4c235b)] - **doc**: mention addons to experimental permission (Rafael Gonzaga) [#55166](nodejs/node#55166) - \[[`d65c2458dc`](nodejs/node@d65c2458dc)] - **doc**: use correct dash in stability status (Antoine du Hamel) [#55200](nodejs/node#55200) - \[[`d9839c16cf`](nodejs/node@d9839c16cf)] - **doc**: fix link in `test/README.md` (Livia Medeiros) [#55165](nodejs/node#55165) - \[[`1ad659afa4`](nodejs/node@1ad659afa4)] - **doc**: add esm examples to node:net (Alfredo González) [#55134](nodejs/node#55134) - \[[`81ad69d50f`](nodejs/node@81ad69d50f)] - **doc**: move the YAML changes element (sendoru) [#55112](nodejs/node#55112) - \[[`7a51a161be`](nodejs/node@7a51a161be)] - **doc**: fix the require resolve algorithm in `modules.md` (chirsz) [#55117](nodejs/node#55117) - \[[`80edcdf899`](nodejs/node@80edcdf899)] - **doc**: update style guide (Aviv Keller) [#53223](nodejs/node#53223) - \[[`388c754dd2`](nodejs/node@388c754dd2)] - **doc**: add missing `:` to `run()`'s `globPatterns` (Aviv Keller) [#55135](nodejs/node#55135) - \[[`94302b6a76`](nodejs/node@94302b6a76)] - **doc**: add abmusse to collaborators (Abdirahim Musse) [#55086](nodejs/node#55086) - \[[`27ff2da964`](nodejs/node@27ff2da964)] - **doc**: add note about `--expose-internals` (Aviv Keller) [#52861](nodejs/node#52861) - \[[`df6dc753b7`](nodejs/node@df6dc753b7)] - **doc**: remove `parseREPLKeyword` from REPL documentation (Aviv Keller) [#54749](nodejs/node#54749) - \[[`4baa5c4d10`](nodejs/node@4baa5c4d10)] - **doc**: change backporting guide with updated info (Aviv Keller) [#53746](nodejs/node#53746) - \[[`9947fc112f`](nodejs/node@9947fc112f)] - **doc**: add missing definitions to `internal-api.md` (Aviv Keller) [#53303](nodejs/node#53303) - \[[`a4586f0e94`](nodejs/node@a4586f0e94)] - **doc**: update documentation for externalizing deps (Michael Dawson) [#54792](nodejs/node#54792) - \[[`70504f8522`](nodejs/node@70504f8522)] - **doc**: update `require(ESM)` history and stability status (Antoine du Hamel) [#55199](nodejs/node#55199) - \[[`9d0041ac40`](nodejs/node@9d0041ac40)] - **doc**: add release key for aduh95 (Antoine du Hamel) [#55349](nodejs/node#55349) - \[[`0c1666a52a`](nodejs/node@0c1666a52a)] - **events**: allow null/undefined eventInitDict (Matthew Aitken) [#54643](nodejs/node#54643) - \[[`453df77f99`](nodejs/node@453df77f99)] - **events**: return `currentTarget` when dispatching (Matthew Aitken) [#54642](nodejs/node#54642) - \[[`0decaab9db`](nodejs/node@0decaab9db)] - **fs**: acknowledge `signal` option in `filehandle.createReadStream()` (Livia Medeiros) [#55148](nodejs/node#55148) - \[[`00a2fc7166`](nodejs/node@00a2fc7166)] - **lib**: move `Symbol[Async]Dispose` polyfills to `internal/util` (Antoine du Hamel) [#54853](nodejs/node#54853) - \[[`8e6b606ac4`](nodejs/node@8e6b606ac4)] - **lib**: remove lib/internal/idna.js (Yagiz Nizipli) [#55050](nodejs/node#55050) - \[[`c96e5cb664`](nodejs/node@c96e5cb664)] - **lib**: the REPL should survive deletion of Array.prototype methods (Jordan Harband) [#31457](nodejs/node#31457) - \[[`748ed2e559`](nodejs/node@748ed2e559)] - **meta**: move one or more collaborators to emeritus (Node.js GitHub Bot) [#55300](nodejs/node#55300) - \[[`8b8d35f015`](nodejs/node@8b8d35f015)] - **meta**: bump mozilla-actions/sccache-action from 0.0.5 to 0.0.6 (dependabot\[bot]) [#55225](nodejs/node#55225) - \[[`d3441ff0c8`](nodejs/node@d3441ff0c8)] - **meta**: bump actions/checkout from 4.1.7 to 4.2.0 (dependabot\[bot]) [#55224](nodejs/node#55224) - \[[`1c20908558`](nodejs/node@1c20908558)] - **meta**: bump actions/setup-node from 4.0.3 to 4.0.4 (dependabot\[bot]) [#55223](nodejs/node#55223) - \[[`8a529abd69`](nodejs/node@8a529abd69)] - **meta**: bump peter-evans/create-pull-request from 7.0.1 to 7.0.5 (dependabot\[bot]) [#55219](nodejs/node#55219) - \[[`9053d210ab`](nodejs/node@9053d210ab)] - **meta**: add mailmap entry for abmusse (Abdirahim Musse) [#55182](nodejs/node#55182) - \[[`db2496c125`](nodejs/node@db2496c125)] - **meta**: add more information about nightly releases (Aviv Keller) [#55084](nodejs/node#55084) - \[[`d2ce003b2f`](nodejs/node@d2ce003b2f)] - **meta**: add `linux` to OS labels in collaborator guide (Aviv Keller) [#54986](nodejs/node#54986) - \[[`37b0bea247`](nodejs/node@37b0bea247)] - **meta**: remove never-used workflow trigger (Aviv Keller) [#54983](nodejs/node#54983) - \[[`ae27e2dcd7`](nodejs/node@ae27e2dcd7)] - **meta**: add links to alternative issue trackers (Aviv Keller) [#54401](nodejs/node#54401) - \[[`6e5d524b0f`](nodejs/node@6e5d524b0f)] - **module**: remove duplicated import (Aviv Keller) [#54942](nodejs/node#54942) - \[[`3a682cca03`](nodejs/node@3a682cca03)] - **path**: remove repetitive conditional operator in `posix.resolve` (Wiyeong Seo) [#54835](nodejs/node#54835) - \[[`ac1cb8dfdb`](nodejs/node@ac1cb8dfdb)] - **perf_hooks**: add missing type argument to getEntriesByName (Luke Taher) [#54767](nodejs/node#54767) - \[[`85b3edc83b`](nodejs/node@85b3edc83b)] - **repl**: catch `\v` and `\r` in new-line detection (Aviv Keller) [#54512](nodejs/node#54512) - \[[`df1f04999e`](nodejs/node@df1f04999e)] - **src**: decode native error messages as UTF-8 (Joyee Cheung) [#55024](nodejs/node#55024) - \[[`86d718177a`](nodejs/node@86d718177a)] - **src**: update clang-tidy and focus on modernization (Yagiz Nizipli) [#53757](nodejs/node#53757) - \[[`7d01b6a9c5`](nodejs/node@7d01b6a9c5)] - **src**: cleanup per env handles directly without a list (Chengzhong Wu) [#54993](nodejs/node#54993) - \[[`a730cdb622`](nodejs/node@a730cdb622)] - **src**: remove duplicate code setting AF_INET (He Yang) [#54939](nodejs/node#54939) - \[[`f10d9ad283`](nodejs/node@f10d9ad283)] - **stream**: treat null asyncIterator as undefined (Jason Zhang) [#55119](nodejs/node#55119) - \[[`6027084245`](nodejs/node@6027084245)] - **test**: make `test-loaders-workers-spawned` less flaky (Antoine du Hamel) [#55172](nodejs/node#55172) - \[[`66a87d19bd`](nodejs/node@66a87d19bd)] - **test**: update multiple assert tests to use node:test (James M Snell) [#54585](nodejs/node#54585) - \[[`5105188c47`](nodejs/node@5105188c47)] - **test**: update wpt test for encoding (devstone) [#55151](nodejs/node#55151) - \[[`81bcec0b82`](nodejs/node@81bcec0b82)] - **test**: deflake test/pummel/test-timers.js (jakecastelli) [#55098](nodejs/node#55098) - \[[`82c402265a`](nodejs/node@82c402265a)] - **test**: deflake test-http-remove-header-stays-removed (Luigi Pinca) [#55004](nodejs/node#55004) - \[[`78021701ed`](nodejs/node@78021701ed)] - **test**: fix test-tls-junk-closes-server (Michael Dawson) [#55089](nodejs/node#55089) - \[[`c908b8a2d8`](nodejs/node@c908b8a2d8)] - **test**: fix more tests that fail when path contains a space (Antoine du Hamel) [#55088](nodejs/node#55088) - \[[`afc1628e73`](nodejs/node@afc1628e73)] - **test**: fix `assertSnapshot` when path contains a quote (Antoine du Hamel) [#55087](nodejs/node#55087) - \[[`7c88739b83`](nodejs/node@7c88739b83)] - **test**: fix some tests when path contains `%` (Antoine du Hamel) [#55082](nodejs/node#55082) - \[[`eb4d468671`](nodejs/node@eb4d468671)] - ***Revert*** "**test**: mark test-fs-watch-non-recursive flaky on Windows" (Luigi Pinca) [#55079](nodejs/node#55079) - \[[`bc7b5249d4`](nodejs/node@bc7b5249d4)] - **test**: make `test-runner-assert` more robust (Aviv Keller) [#55036](nodejs/node#55036) - \[[`6c2a1386f7`](nodejs/node@6c2a1386f7)] - **test**: update tls test to support OpenSSL32 (Michael Dawson) [#55030](nodejs/node#55030) - \[[`96406610fa`](nodejs/node@96406610fa)] - **test**: fix `test-vm-context-dont-contextify` when path contains a space (Antoine du Hamel) [#55026](nodejs/node#55026) - \[[`39a80eed4f`](nodejs/node@39a80eed4f)] - **test**: adjust tls-set-ciphers for OpenSSL32 (Michael Dawson) [#55016](nodejs/node#55016) - \[[`bd8fd4fceb`](nodejs/node@bd8fd4fceb)] - **test**: add `util.stripVTControlCharacters` test (RedYetiDev) [#54865](nodejs/node#54865) - \[[`333b5a02d0`](nodejs/node@333b5a02d0)] - **test**: improve coverage for timer promises schedular (Aviv Keller) [#53370](nodejs/node#53370) - \[[`f48992f433`](nodejs/node@f48992f433)] - **test**: remove unused common utilities (RedYetiDev) [#54825](nodejs/node#54825) - \[[`93a098c56d`](nodejs/node@93a098c56d)] - **test**: deflake test-http-header-overflow (Luigi Pinca) [#54978](nodejs/node#54978) - \[[`f849cf677d`](nodejs/node@f849cf677d)] - **test**: fix `soucre` to `source` (Aviv Keller) [#55038](nodejs/node#55038) - \[[`1a007ea814`](nodejs/node@1a007ea814)] - **test**: add asserts to validate test assumptions (Michael Dawson) [#54997](nodejs/node#54997) - \[[`6f53c096f8`](nodejs/node@6f53c096f8)] - **test**: move test-http-max-sockets to parallel (Luigi Pinca) [#54977](nodejs/node#54977) - \[[`aba9dc775e`](nodejs/node@aba9dc775e)] - **test**: remove test-http-max-sockets flaky designation (Luigi Pinca) [#54976](nodejs/node#54976) - \[[`ee5624bffe`](nodejs/node@ee5624bffe)] - **test**: adjust key sizes to support OpenSSL32 (Michael Dawson) [#54972](nodejs/node#54972) - \[[`5c11a61140`](nodejs/node@5c11a61140)] - **test**: update test to support OpenSSL32 (Michael Dawson) [#54968](nodejs/node#54968) - \[[`62f21470e4`](nodejs/node@62f21470e4)] - **test**: update DOM events web platform tests (Matthew Aitken) [#54642](nodejs/node#54642) - \[[`426851705c`](nodejs/node@426851705c)] - **test_runner**: assert entry is a valid object (Edigleysson Silva (Edy)) [#55231](nodejs/node#55231) - \[[`b1cad519d7`](nodejs/node@b1cad519d7)] - **test_runner**: use `test:` symbol on second print of parent test (RedYetiDev) [#54956](nodejs/node#54956) - \[[`63c8f3d436`](nodejs/node@63c8f3d436)] - **test_runner**: replace ansi clear with ansi reset (Pietro Marchini) [#55013](nodejs/node#55013) - \[[`0b3fb344f7`](nodejs/node@0b3fb344f7)] - **tools**: add `polyfilled` option to `prefer-primordials` rule (Antoine du Hamel) [#55318](nodejs/node#55318) - \[[`8981309bd9`](nodejs/node@8981309bd9)] - **tools**: make `choco install` script more readable (Aviv Keller) [#54002](nodejs/node#54002) - \[[`7310abeae1`](nodejs/node@7310abeae1)] - **tools**: bump Rollup from 4.18.1 to 4.22.4 for `lint-md` (dependabot\[bot]) [#55093](nodejs/node#55093) - \[[`083311e8af`](nodejs/node@083311e8af)] - **tools**: remove redudant code from eslint require rule (Aviv Keller) [#54892](nodejs/node#54892) - \[[`ae4b2aece1`](nodejs/node@ae4b2aece1)] - **tools**: update error message for ICU in license-builder (Aviv Keller) [#54742](nodejs/node#54742) - \[[`3ebd31684d`](nodejs/node@3ebd31684d)] - **tools**: update github_reporter to 1.7.1 (Node.js GitHub Bot) [#54951](nodejs/node#54951) - \[[`397be8a10e`](nodejs/node@397be8a10e)] - **tty**: fix links for terminal colors (Aviv Keller) [#54596](nodejs/node#54596) - \[[`a3c2ef9e98`](nodejs/node@a3c2ef9e98)] - **util**: update ansi regex (Aviv Keller) [#54865](nodejs/node#54865) - \[[`efdccc88a2`](nodejs/node@efdccc88a2)] - **watch**: preserve output when gracefully restarted (Théo LUDWIG) [#54323](nodejs/node#54323) - \[[`226836c5ac`](nodejs/node@226836c5ac)] - **worker**: throw InvalidStateError in postMessage after close (devstone) [#55206](nodejs/node#55206) - \[[`f39ff4d14b`](nodejs/node@f39ff4d14b)] - **worker**: handle `--input-type` more consistently (Antoine du Hamel) [#54979](nodejs/node#54979) - \[[`30383ffb9a`](nodejs/node@30383ffb9a)] - **zlib**: throw brotli initialization error from c++ (Yagiz Nizipli) [#54698](nodejs/node#54698) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

PR-URL: nodejs#55231 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Oct 2, 2024

geeksilva97 force-pushed the fix-test-runner-when-source-maps-is-enabled branch from 3cf0246 to 4a29562Compare October 2, 2024 03:33

geeksilva97 mentioned this pull request Oct 2, 2024
test_runner: fix coverage report when --enable-source-maps is provided #55228
Merged

geeksilva97 marked this pull request as ready for review October 2, 2024 03:39

geeksilva97 changed the title ~~Fix test runner when source maps is enabled~~test_runner: fix TypeError exception when --enable-source-maps is passedOct 2, 2024

geeksilva97 commented Oct 2, 2024
View reviewed changes

lib/internal/test_runner/test.js Outdated Show resolvedHide resolved

geeksilva97 force-pushed the fix-test-runner-when-source-maps-is-enabled branch 2 times, most recently from e0eb38c to f8c707cCompare October 2, 2024 03:49

avivkeller reviewed Oct 2, 2024
View reviewed changes

lib/internal/test_runner/test.js Outdated Show resolvedHide resolved

geeksilva97 force-pushed the fix-test-runner-when-source-maps-is-enabled branch from f8c707c to e440d39Compare October 2, 2024 13:08

cjihrig reviewed Oct 2, 2024
View reviewed changes

test/parallel/test-runner-coverage.js Outdated Show resolvedHide resolved
test/parallel/test-runner-coverage.js Outdated Show resolvedHide resolved

geeksilva97 force-pushed the fix-test-runner-when-source-maps-is-enabled branch from ae5b97f to 176b447Compare October 2, 2024 14:14

cjihrig approved these changes Oct 2, 2024
View reviewed changes

test/parallel/test-runner-enable-source-maps-issue.js Outdated Show resolvedHide resolved

geeksilva97 force-pushed the fix-test-runner-when-source-maps-is-enabled branch from 176b447 to d8a51cfCompare October 2, 2024 14:18

geeksilva97 requested a review from avivkeller October 2, 2024 14:18

cjihrig approved these changes Oct 2, 2024
View reviewed changes

cjihrig added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 2, 2024

github-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 2, 2024

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 4, 2024

nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Oct 5, 2024

geeksilva97 added 3 commits October 5, 2024 15:26

test_runner: assert entry is a valid object
2e2ab53

test: test case when --enable-source-maps is provided
025f1a9

test: move --enable-source-maps test to a single file
5a98f1c

geeksilva97 force-pushed the fix-test-runner-when-source-maps-is-enabled branch from d8a51cf to 5a98f1cCompare October 5, 2024 18:28

chore: rebase cleanup
b208245

geeksilva97 requested a review from MoLow October 5, 2024 18:35

MoLow approved these changes Oct 5, 2024
View reviewed changes

MoLow added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Oct 5, 2024

github-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 5, 2024

mcollina approved these changes Oct 5, 2024
View reviewed changes

cjihrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 6, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 6, 2024

nodejs-github-bot merged commit 980b91a into nodejs:mainOct 6, 2024

aduh95 pushed a commit that referenced this pull request Oct 9, 2024
test_runner: assert entry is a valid object
0f7e3f0
PR-URL: #55231 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

aduh95 mentioned this pull request Oct 9, 2024
V22.10.0 proposal #55343
Merged

louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
test_runner: assert entry is a valid object
36ada35
PR-URL: nodejs#55231 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

marco-ippolito pushed a commit that referenced this pull request Nov 16, 2024
test_runner: assert entry is a valid object
bbdccaa
PR-URL: #55231 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

marco-ippolito mentioned this pull request Nov 16, 2024
v20.18.1 proposal #55879
Merged

marco-ippolito pushed a commit that referenced this pull request Nov 17, 2024
test_runner: assert entry is a valid object
4268517
PR-URL: #55231 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

geeksilva97 deleted the fix-test-runner-when-source-maps-is-enabled branch May 20, 2025 00:47

Uh oh!

test_runner: fix TypeError exception when --enable-source-maps is passed#55231

test_runner: fix TypeError exception when --enable-source-maps is passed #55231

Uh oh!

Conversation

geeksilva97 commented Oct 2, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Oct 2, 2024

Uh oh!

Uh oh!

codecovbot commented Oct 2, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

cjihrig left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Oct 2, 2024

Uh oh!

nodejs-github-bot commented Oct 3, 2024

Uh oh!

nodejs-github-bot commented Oct 4, 2024

Uh oh!

nodejs-github-bot commented Oct 5, 2024

Uh oh!

MoLow commented Oct 5, 2024

Uh oh!

geeksilva97 commented Oct 5, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Oct 5, 2024

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Oct 6, 2024

Uh oh!

nodejs-github-bot commented Oct 6, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

geeksilva97 commented Oct 2, 2024•
edited
Loading

codecovbot commented Oct 2, 2024•
edited
Loading

geeksilva97 commented Oct 5, 2024•
edited
Loading