module: unflag --experimental-strip-types#56350

marco-ippolito · 2024-12-24T15:04:02Z

It's time to enable it by default to catch some more bugs, currently there are no open issues.
I think it's a semver minor change.

Fixes: nodejs/typescript#17

@nodejs/tsc for visibility

Notable change section:

This change enables the flag --experimental-strip-types by default.
Node.js will be able to execute TypeScript files without additional configuration. Note that there are some limitations in the supported syntax documented at https://nodejs.org/api/typescript.html#type-stripping
This feature is experimental and is subject to change.

nodejs-github-bot · 2024-12-24T15:04:07Z

Review requested:

@nodejs/loaders
@nodejs/performance
@nodejs/test_runner
@nodejs/typescript

codecov · 2024-12-24T19:38:19Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.54%. Comparing base (da3f388) to head (d847c32).
Report is 1407 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #56350 +/- ## ========================================== - Coverage 88.54% 88.54% -0.01%  ========================================== Files 657 657 Lines 190655 190658 +3 Branches 36582 36584 +2 ========================================== - Hits 168824 168820 -4 - Misses 15008 15011 +3 - Partials 6823 6827 +4

Files with missing lines	Coverage Δ
src/node_options.cc	`87.92% <ø> (ø)`
src/node_options.h	`98.30% <100.00%> (ø)`

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mcollina

LGTM

github-actions · 2024-12-25T12:09:44Z

The notable-changePRs with changes that should be highlighted in changelogs. label has been added by @marco-ippolito.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

nodejs-github-bot · 2024-12-25T12:12:07Z

CI: https://ci.nodejs.org/job/node-test-pull-request/64202/

bmuenzenmeyer

excited for this, having watched it's development and played with it quite a bit.
some suggestions and questions, none blocking

doc/api/cli.md

test/es-module/test-typescript.mjs

test/parallel/test-runner-coverage-default-exclusion.mjs

doc/api/cli.md

doc/api/typescript.md

anonrig · 2024-12-26T00:03:35Z

What about process.features.typescript? Does that also needs changing?

marco-ippolito · 2024-12-26T06:05:36Z

What about process.features.typescript? Does that also needs changing?

It works fine, tests are updated (now the default value is 'strip')

PR-URL: #57704 Backport-PR-URL: #57298 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> PR-URL: #56350Fixes: nodejs/typescript#17

PR-URL: #57871 Backport-PR-URL: #57298Fixes: #57471 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Pietro Marchini <[email protected]> PR-URL: #56350Fixes: nodejs/typescript#17

PR-URL: #58174 Backport-PR-URL: #57298 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Jacob Smith <[email protected]> PR-URL: #56350Fixes: nodejs/typescript#17

PR-URL: #58639 Backport-PR-URL: #57298 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> PR-URL: #56350Fixes: nodejs/typescript#17

PR-URL: #58754 Backport-PR-URL: #57298 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> PR-URL: #56350Fixes: nodejs/typescript#17

PR-URL: #56350 Backport-PR-URL: #57298Fixes: nodejs/typescript#17 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Pietro Marchini <[email protected]>

PR-URL: #58175 Backport-PR-URL: #57298 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> PR-URL: #56350Fixes: nodejs/typescript#17

This commit refactors the CommonJS loader to remove TypeScript-specific extensions from the require.extensions object for compatibility with libraries that depended on it to initialize extenal TypeScript loaders. PR-URL: #58657 Backport-PR-URL: #57298 Refs: nodejs/typescript#37 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Pietro Marchini <[email protected]> Reviewed-By: Xuguang Mei <[email protected]> PR-URL: #56350Fixes: nodejs/typescript#17

PR-URL: #58643 Backport-PR-URL: #57298 Refs: nodejs/typescript#24 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jordan Harband <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> PR-URL: #56350Fixes: nodejs/typescript#17

PR-URL: #57687 Backport-PR-URL: #57298Fixes: #56830 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> PR-URL: #56350Fixes: nodejs/typescript#17

PR-URL: #57704 Backport-PR-URL: #57298 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> PR-URL: #56350Fixes: nodejs/typescript#17

PR-URL: #57871 Backport-PR-URL: #57298Fixes: #57471 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Pietro Marchini <[email protected]> PR-URL: #56350Fixes: nodejs/typescript#17

PR-URL: #58174 Backport-PR-URL: #57298 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Jacob Smith <[email protected]> PR-URL: #56350Fixes: nodejs/typescript#17

PR-URL: #58639 Backport-PR-URL: #57298 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> PR-URL: #56350Fixes: nodejs/typescript#17

PR-URL: #58754 Backport-PR-URL: #57298 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> PR-URL: #56350Fixes: nodejs/typescript#17

PR-URL: #58732 Refs: #56350 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

Notable changes: deps: * (SEMVER-MINOR) update amaro to 1.1.0 (Node.js GitHub Bot) #56350 * (SEMVER-MINOR) update amaro to 1.0.0 (Node.js GitHub Bot) #56350 * (SEMVER-MINOR) update amaro to 0.5.3 (Node.js GitHub Bot) #56350 * (SEMVER-MINOR) update amaro to 0.5.2 (Node.js GitHub Bot) #56350 * (SEMVER-MINOR) update amaro to 0.5.1 (Marco Ippolito) #56350 * (SEMVER-MINOR) update amaro to 0.5.0 (nodejs-github-bot) #56350 doc: * (SEMVER-MINOR) add all watch-mode related flags to node.1 (Dario Piotrowicz) #58719 * add islandryu to collaborators (Shima Ryuhei) #58714 * (SEMVER-MINOR) add history entries to `--input-type` section (Antoine du Hamel) #56350 esm: * (SEMVER-MINOR) implement import.meta.main (Joe) #57804 fs: * (SEMVER-MINOR) allow correct handling of burst in fs-events with AsyncIterator (Philipp Dunkel) #58490 module: * (SEMVER-MINOR) improve typescript error message format (Marco Ippolito) #56350 * (SEMVER-MINOR) remove experimental warning from type stripping (Marco Ippolito) #56350 * (SEMVER-MINOR) refactor commonjs typescript loader (Marco Ippolito) #56350 * (SEMVER-MINOR) unflag --experimental-strip-types (Marco Ippolito) #56350 permission: * (SEMVER-MINOR) propagate permission model flags on spawn (Rafael Gonzaga) #58853 sqlite: * (SEMVER-MINOR) add support for readBigInts option in db connection level (Miguel Marcondes Filho) #58697 src,permission: * (SEMVER-MINOR) add support to permission.has(addon) (Rafael Gonzaga) #58951 test: * (SEMVER-MINOR) add test for async disposable worker thread (James M Snell) #58385 url: * (SEMVER-MINOR) add fileURLToPathBuffer API (James M Snell) #58700 watch: * (SEMVER-MINOR) add `--watch-kill-signal` flag (Dario Piotrowicz) #58719 worker: * (SEMVER-MINOR) make Worker async disposable (James M Snell) #58385 PR-URL: #59256

Notable changes: deps: * (SEMVER-MINOR) update amaro to 1.1.0 (Node.js GitHub Bot) #56350 doc: * add islandryu to collaborators (Shima Ryuhei) #58714 esm: * (SEMVER-MINOR) implement `import.meta.main` (Joe) #57804 fs: * (SEMVER-MINOR) allow correct handling of burst in fs-events with AsyncIterator (Philipp Dunkel) #58490 module: * (SEMVER-MINOR) remove experimental warning from type stripping (Marco Ippolito) #56350 * (SEMVER-MINOR) unflag `--experimental-strip-types` (Marco Ippolito) #56350 permission: * (SEMVER-MINOR) propagate permission model flags on spawn (Rafael Gonzaga) #58853 sqlite: * (SEMVER-MINOR) add support for `readBigInts` option in db connection level (Miguel Marcondes Filho) #58697 src,permission: * (SEMVER-MINOR) add support to `permission.has(addon)` (Rafael Gonzaga) #58951 url: * (SEMVER-MINOR) add `fileURLToPathBuffer` API (James M Snell) #58700 watch: * (SEMVER-MINOR) add `--watch-kill-signal` flag (Dario Piotrowicz) #58719 worker: * (SEMVER-MINOR) make `Worker` async disposable (James M Snell) #58385 PR-URL: #59256 Co-authored-by: Antoine du Hamel <[email protected]>

Notable changes: deps: * (SEMVER-MINOR) update amaro to 1.1.0 (Node.js GitHub Bot) nodejs#56350 doc: * add islandryu to collaborators (Shima Ryuhei) nodejs#58714 esm: * (SEMVER-MINOR) implement `import.meta.main` (Joe) nodejs#57804 fs: * (SEMVER-MINOR) allow correct handling of burst in fs-events with AsyncIterator (Philipp Dunkel) nodejs#58490 module: * (SEMVER-MINOR) remove experimental warning from type stripping (Marco Ippolito) nodejs#56350 * (SEMVER-MINOR) unflag `--experimental-strip-types` (Marco Ippolito) nodejs#56350 permission: * (SEMVER-MINOR) propagate permission model flags on spawn (Rafael Gonzaga) nodejs#58853 sqlite: * (SEMVER-MINOR) add support for `readBigInts` option in db connection level (Miguel Marcondes Filho) nodejs#58697 src,permission: * (SEMVER-MINOR) add support to `permission.has(addon)` (Rafael Gonzaga) nodejs#58951 url: * (SEMVER-MINOR) add `fileURLToPathBuffer` API (James M Snell) nodejs#58700 watch: * (SEMVER-MINOR) add `--watch-kill-signal` flag (Dario Piotrowicz) nodejs#58719 worker: * (SEMVER-MINOR) make `Worker` async disposable (James M Snell) nodejs#58385 PR-URL: nodejs#59256 Co-authored-by: Antoine du Hamel <[email protected]>

karfau · 2025-08-04T12:32:39Z

doc/api/cli.md

+### `--no-experimental-strip-types`
+
+<!-- YAML
+added: v22.6.0


This is a copy paste error, right?
This toggle was added in v22.18.0 according to https://github.com/nodejs/node/blob/5bea645e4b1ff9b740acf24cfb899fb099ba1065/doc/changelogs/CHANGELOG_V22.md#2025-07-31-version-22180-jod-lts-aduh95
and --experimental-strip-types was dropped without replacement as part of that version.

In v22.6.0 the flag was introduced, in v22.18.0 is enabled by default. --no-experimental-strip-types has been available since then

--experimental-strip-types was introduced in 22.6, and --no-experimental-strip-types was introduced in 22.18, or are they the same flag and one is the negation of the other?

They the same flag, one is the negation of the other, both were introduced in 22.6.0 (we only list the non-default one in this document)

Notable changes: deps: * (SEMVER-MINOR) update amaro to 1.1.0 (Node.js GitHub Bot) nodejs#56350 doc: * add islandryu to collaborators (Shima Ryuhei) nodejs#58714 esm: * (SEMVER-MINOR) implement `import.meta.main` (Joe) nodejs#57804 fs: * (SEMVER-MINOR) allow correct handling of burst in fs-events with AsyncIterator (Philipp Dunkel) nodejs#58490 module: * (SEMVER-MINOR) remove experimental warning from type stripping (Marco Ippolito) nodejs#56350 * (SEMVER-MINOR) unflag `--experimental-strip-types` (Marco Ippolito) nodejs#56350 permission: * (SEMVER-MINOR) propagate permission model flags on spawn (Rafael Gonzaga) nodejs#58853 sqlite: * (SEMVER-MINOR) add support for `readBigInts` option in db connection level (Miguel Marcondes Filho) nodejs#58697 src,permission: * (SEMVER-MINOR) add support to `permission.has(addon)` (Rafael Gonzaga) nodejs#58951 url: * (SEMVER-MINOR) add `fileURLToPathBuffer` API (James M Snell) nodejs#58700 watch: * (SEMVER-MINOR) add `--watch-kill-signal` flag (Dario Piotrowicz) nodejs#58719 worker: * (SEMVER-MINOR) make `Worker` async disposable (James M Snell) nodejs#58385 PR-URL: nodejs#59256 Co-authored-by: Antoine du Hamel <[email protected]>

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Dec 24, 2024

marco-ippolito added strip-types Issues or PRs related to strip-types support blocked PRs that are blocked by other issues or PRs. wip Issues and PRs that are still a work in progress. labels Dec 24, 2024

marco-ippolito force-pushed the unflag-strip-types branch from 7505688 to 72e089cCompare December 24, 2024 16:50

marco-ippolito marked this pull request as ready for review December 24, 2024 18:17

marco-ippolito removed wip Issues and PRs that are still a work in progress. blocked PRs that are blocked by other issues or PRs. labels Dec 24, 2024

marco-ippolito added semver-minor PRs that contain new features and should be released in the next minor version. dont-land-on-v18.x dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. labels Dec 25, 2024

mcollina approved these changes Dec 25, 2024
View reviewed changes

marco-ippolito added request-ci Add this label to start a Jenkins CI on a PR. notable-change PRs with changes that should be highlighted in changelogs. baking-for-lts PRs that need to wait before landing in a LTS release. labels Dec 25, 2024

marco-ippolito added the module Issues and PRs related to the module subsystem. label Dec 25, 2024

github-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 25, 2024

bmuenzenmeyer reviewed Dec 25, 2024
View reviewed changes

doc/api/cli.md Outdated Show resolvedHide resolved
doc/api/cli.mdShow resolvedHide resolved
test/es-module/test-typescript.mjs Outdated Show resolvedHide resolved
test/parallel/test-runner-coverage-default-exclusion.mjsShow resolvedHide resolved

aduh95 reviewed Dec 25, 2024
View reviewed changes

doc/api/cli.mdShow resolvedHide resolved
doc/api/cli.md Outdated Show resolvedHide resolved
doc/api/typescript.mdShow resolvedHide resolved

VoltrexKeyva approved these changes Dec 25, 2024
View reviewed changes

module: unflag --experimental-strip-types
d847c32

marco-ippolito force-pushed the unflag-strip-types branch from c28ef27 to d847c32Compare December 26, 2024 06:41

marco-ippolito added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 26, 2024

marco-ippolito pushed a commit that referenced this pull request Jul 4, 2025
deps: update amaro to 1.1.0
4af5915
PR-URL: #58754 Backport-PR-URL: #57298 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> PR-URL: #56350Fixes: nodejs/typescript#17

marco-ippolito added backported-to-v22.x PRs backported to the v22.x-staging branch. and removed backport-open-v22.x Indicate that the PR has an open backport labels Jul 4, 2025

RafaelGSS pushed a commit that referenced this pull request Jul 15, 2025
deps: update amaro to 1.1.0
26f3711
PR-URL: #58754 Backport-PR-URL: #57298 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> PR-URL: #56350Fixes: nodejs/typescript#17

github-actionsbot mentioned this pull request Jul 28, 2025
2025-07-29, Version 22.18.0 'Jod' (LTS) #59256
Merged

karfau reviewed Aug 4, 2025
View reviewed changes

Uh oh!

module: unflag --experimental-strip-types#56350

module: unflag --experimental-strip-types #56350

Uh oh!

Conversation

marco-ippolito commented Dec 24, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Dec 24, 2024

Uh oh!

codecovbot commented Dec 24, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsbot commented Dec 25, 2024

Uh oh!

nodejs-github-bot commented Dec 25, 2024

Uh oh!

bmuenzenmeyer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

anonrig commented Dec 26, 2024

Uh oh!

marco-ippolito commented Dec 26, 2024

Uh oh!

karfauAug 4, 2025

Choose a reason for hiding this comment

Uh oh!

marco-ippolitoAug 4, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

karfauAug 4, 2025

Choose a reason for hiding this comment

Uh oh!

aduh95Aug 4, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

16 participants

marco-ippolito commented Dec 24, 2024•
edited
Loading

codecovbot commented Dec 24, 2024•
edited
Loading

marco-ippolitoAug 4, 2025•
edited
Loading