doc: fix faulty YAML metadata#56508
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
Fast-track has been requested by @aduh95. Please 👍 to approve. |
lpinca approved these changes Jan 7, 2025
MoLow approved these changes Jan 7, 2025
aduh95 added author ready 
nodejs-github-bot removed the commit-queue nodejs-github-bot merged commit 5119049 into nodejs:main 30 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Collaborator
nodejs-github-bot commented Jan 7, 2025
Landed in 5119049 |
ruyadorno added a commit to nodejs/node-core-utils that referenced this pull request Jan 8, 2025
After two consecutive releases in which I mistakely pushed a broken release commit to main, I'm convinced that the process needs improvement. This changeset proposes to add a reminder to `git node release promote` to lint markdown files prior to pushing branches to upstream remote. Refs: nodejs/node@a344300 Refs: nodejs/node#56508
ruyadorno added a commit to nodejs/node-core-utils that referenced this pull request Jan 8, 2025
After two consecutive releases in which I mistakely pushed a broken release commit to main, I'm convinced that the process needs improvement. This changeset proposes to add a reminder to `git node release promote` to lint markdown files prior to pushing branches to upstream remote. Refs: nodejs/node@a344300 Refs: nodejs/node#56508
targos added dont-land-on-v18.x dont-land-on-v20.x Ceres6 pushed a commit to Ceres6/node that referenced this pull request Jan 13, 2025
PR-URL: nodejs#56508 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix the linter on
main