Skip to content

Conversation

@rvagg
Copy link
Member

I've spent some more quality time with Packages today, trying to wrangle this into something closer to ready. Building on the work of @remixz work in #776 and @fhemberger's work in #2571.

  • Remove the uninstall option - while I got it to work nicely and cleaned up the script to fully remove everything, the installer that Packages makes is not really suitable for an uninstall option, it still says it's "installing", the button is "install", the summary at the end still says it's installed Node & npm, it's basically a hack to make an uninstaller possible. We should consider putting this option on the wiki or even installing it somewhere in /usr/local/ that's not in PATH but we can point users to so they can run it themselves.
  • Switched to the new logo using the commit on master already
  • Made the "Install Node.js" option mandatory, Packages has some depend-on functionality for selecting options but there is no way to make it so you have to have Node.js if you select npm, you can make the select box turn on but you can turn it off.
  • Changed install.py to add new NODE_INSTALL_NODE_ONLY, NODE_INSTALL_NPM_ONLY and NODE_INSTALL_HEADERS_ONLY (was HEADERS_ONLY) env vars so it can install npm to a different location to node so that the options work properly and you can actually opt to not install npm (yes, it works now!).
  • Made it so you have to click "Customize" to get to the checkboxes to optionally install npm.
  • Made the LICENSE an RTF, it looks so so much nicer now that it's formatted.
  • Moved the .pkg to the top-level instead of out/, which is what the current installer does and what Jenkins expects.

Commits are all over the place and need to be compacted obviously.

Will post a test build soon, got to sort out the slaves again.

@mscdexmscdex added install Issues and PRs related to the installers. macos Issues and PRs related to the macOS platform / OSX. labels Mar 11, 2016
Makefile Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no ?=?

@Fishrock123
Copy link
Contributor

As a note, I got a few whitespace errors when applying.

@rvagg
Copy link
MemberAuthor

OK, some more adjustments and I've put Packages on both OSX build machines now (was only on one before). Now I have a test package to share! Grab it at https://nodejs.org/download/test/v6.0.0-test20160316798c9dc5b3/node-v6.0.0-test20160316798c9dc5b3.pkg to experience the new goodness.

@eljefedelrodeodeljefe
Copy link
Contributor

Looks reasonable to me. Build worked like a charm. thanks @fhemberger for pointing at this one (have missed it)

@jasnell
Copy link
Member

ping @rvagg

@jasnelljasnell added the stalled Issues and PRs that are stalled. label Feb 28, 2017
@jasnell
Copy link
Member

Closing due to lack of forward progress on this.

@jasnelljasnell closed this Aug 24, 2017
jpwesselink added a commit to jpwesselink/node that referenced this pull request Sep 15, 2017
Creates macOS pkg installer by using `pkgbuild` and `productbuild`. Removes previous npm installation before installing npm. Packages carry correct version attributes. Support for intl installer features, defaults to `en`. Fancy formatted license. Renamed `osx` references to `macOS`. Optional installation of npm PR-URL: nodejs#15179Fixes: nodejs#15012 Refs: nodejs#5656 Refs: nodejs#2571 Refs: nodejs#7097
BridgeAR pushed a commit that referenced this pull request Sep 28, 2017
Creates macOS pkg installer by using `pkgbuild` and `productbuild`. Removes previous npm installation before installing npm. Packages carry correct version attributes. Support for intl installer features, defaults to `en`. Fancy formatted license. Renamed `osx` references to `macOS`. Optional installation of npm. PR-URL: #15179Fixes: #15012 Refs: #5656 Refs: #2571 Refs: #7097 Reviewed-By: Lance Ball <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 29, 2017
Creates macOS pkg installer by using `pkgbuild` and `productbuild`. Removes previous npm installation before installing npm. Packages carry correct version attributes. Support for intl installer features, defaults to `en`. Fancy formatted license. Renamed `osx` references to `macOS`. Optional installation of npm. PR-URL: #15179Fixes: #15012 Refs: #5656 Refs: #2571 Refs: #7097 Reviewed-By: Lance Ball <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
addaleax pushed a commit to addaleax/ayo that referenced this pull request Sep 30, 2017
Creates macOS pkg installer by using `pkgbuild` and `productbuild`. Removes previous npm installation before installing npm. Packages carry correct version attributes. Support for intl installer features, defaults to `en`. Fancy formatted license. Renamed `osx` references to `macOS`. Optional installation of npm. PR-URL: nodejs/node#15179Fixes: nodejs/node#15012 Refs: nodejs/node#5656 Refs: nodejs/node#2571 Refs: nodejs/node#7097 Reviewed-By: Lance Ball <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
Creates macOS pkg installer by using `pkgbuild` and `productbuild`. Removes previous npm installation before installing npm. Packages carry correct version attributes. Support for intl installer features, defaults to `en`. Fancy formatted license. Renamed `osx` references to `macOS`. Optional installation of npm. PR-URL: #15179Fixes: #15012 Refs: #5656 Refs: #2571 Refs: #7097 Reviewed-By: Lance Ball <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
Creates macOS pkg installer by using `pkgbuild` and `productbuild`. Removes previous npm installation before installing npm. Packages carry correct version attributes. Support for intl installer features, defaults to `en`. Fancy formatted license. Renamed `osx` references to `macOS`. Optional installation of npm. PR-URL: #15179Fixes: #15012 Refs: #5656 Refs: #2571 Refs: #7097 Reviewed-By: Lance Ball <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 16, 2018
Creates macOS pkg installer by using `pkgbuild` and `productbuild`. Removes previous npm installation before installing npm. Packages carry correct version attributes. Support for intl installer features, defaults to `en`. Fancy formatted license. Renamed `osx` references to `macOS`. Optional installation of npm. PR-URL: #15179Fixes: #15012 Refs: #5656 Refs: #2571 Refs: #7097 Reviewed-By: Lance Ball <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 17, 2018
Creates macOS pkg installer by using `pkgbuild` and `productbuild`. Removes previous npm installation before installing npm. Packages carry correct version attributes. Support for intl installer features, defaults to `en`. Fancy formatted license. Renamed `osx` references to `macOS`. Optional installation of npm. PR-URL: #15179Fixes: #15012 Refs: #5656 Refs: #2571 Refs: #7097 Reviewed-By: Lance Ball <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 11, 2018
Creates macOS pkg installer by using `pkgbuild` and `productbuild`. Removes previous npm installation before installing npm. Packages carry correct version attributes. Support for intl installer features, defaults to `en`. Fancy formatted license. Renamed `osx` references to `macOS`. Optional installation of npm. PR-URL: #15179Fixes: #15012 Refs: #5656 Refs: #2571 Refs: #7097 Reviewed-By: Lance Ball <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 12, 2018
Creates macOS pkg installer by using `pkgbuild` and `productbuild`. Removes previous npm installation before installing npm. Packages carry correct version attributes. Support for intl installer features, defaults to `en`. Fancy formatted license. Renamed `osx` references to `macOS`. Optional installation of npm. PR-URL: #15179Fixes: #15012 Refs: #5656 Refs: #2571 Refs: #7097 Reviewed-By: Lance Ball <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 13, 2018
Creates macOS pkg installer by using `pkgbuild` and `productbuild`. Removes previous npm installation before installing npm. Packages carry correct version attributes. Support for intl installer features, defaults to `en`. Fancy formatted license. Renamed `osx` references to `macOS`. Optional installation of npm. PR-URL: #15179Fixes: #15012 Refs: #5656 Refs: #2571 Refs: #7097 Reviewed-By: Lance Ball <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

installIssues and PRs related to the installers.macosIssues and PRs related to the macOS platform / OSX.stalledIssues and PRs that are stalled.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@rvagg@Fishrock123@eljefedelrodeodeljefe@fhemberger@jasnell@mscdex@remixz