test: refactor http-end-throw-socket-handling

[santigimeno]

Pull Request check-list

Please make sure to review and check all of these items:

• Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
  this change (including linting)?
• Is the commit message formatted according to CONTRIBUTING.md?
• If this change fixes a bug (or a performance problem), is a regression
  test (or a benchmark) included?
• Is a documentation update included (if this change modifies
  existing APIs, or introduces new ones)?

Affected core subsystem(s)

test

Description of change

Remove timer to avoid the test to timeout occasionally.

I have been getting this error on OS X:

=== release test-http-end-throw-socket-handling === Path: parallel/test-http-end-throw-socket-handling /Users/sgimeno/node/node/test/parallel/test-http-end-throw-socket-handling.js:35 throw new Error('Taking too long!'); ^ Error: Taking too long! at ._onTimeout (/Users/sgimeno/node/node/test/parallel/test-http-end-throw-socket-handling.js:35:9) at Timer.unrefdHandle (timers.js:454:14) Command: out/Release/node /Users/sgimeno/node/node/test/parallel/test-http-end-throw-socket-handling.js 

[claudiorodriguez]

CI: https://ci.nodejs.org/job/node-test-pull-request/1909/
LGTM if CI is happy

[jasnell]

LGTM

[claudiorodriguez]

This one went under the radar. I'll be merging it in 24hs if no one objects.

[claudiorodriguez]

Landed in 8d1d3bb

[MylesBorins]

@jasnell lts?

[jasnell]

+1
On Apr 20, 2016 11:30 PM, "Myles Borins" [email protected] wrote:

@jasnellhttps://github.com/jasnell lts?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#5676 (comment)