doc: fix typos#5678
Closed
doc: fix typos #5678
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
claudiorodriguez added dgram 
Contributor
zkat commented Mar 12, 2016
LGTM! Hi, @watilde-san! 👋 |
Contributor
evanlucas commented Mar 13, 2016
LGTM CI: https://ci.nodejs.org/job/node-test-pull-request/1911/ (just because the addons docs are used for tests). Thanks!!! |
Contributor
thefourtheye commented Mar 13, 2016
The failed test is not related to this change. LGTM |
PR-URL: nodejs#5678 Reviewed-By: zkat - Kat Marchán <[email protected]> Reviewed-By: evanlucas - Evan Lucas <[email protected]> Reviewed-By: thefourtheye - Sakthipriyan Vairamani <[email protected]>
PR-URL: nodejs#5678 Reviewed-By: zkat - Kat Marchán <[email protected]> Reviewed-By: evanlucas - Evan Lucas <[email protected]> Reviewed-By: thefourtheye - Sakthipriyan Vairamani <[email protected]>
PR-URL: nodejs#5678 Reviewed-By: zkat - Kat Marchán <[email protected]> Reviewed-By: evanlucas - Evan Lucas <[email protected]> Reviewed-By: thefourtheye - Sakthipriyan Vairamani <[email protected]>
ContributorAuthor
watilde commented Mar 14, 2016
Okey rebased and re-wrote commit messages :) |
Contributor
cjihrig commented Mar 14, 2016
LGTM |
1 similar comment
Member
jasnell commented Mar 14, 2016
LGTM |
jasnell pushed a commit that referenced this pull request Mar 14, 2016
PR-URL: #5678 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
jasnell pushed a commit that referenced this pull request Mar 14, 2016
PR-URL: #5678 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
jasnell pushed a commit that referenced this pull request Mar 14, 2016
PR-URL: #5678 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
jasnell commented Mar 14, 2016
evanlucas pushed a commit that referenced this pull request Mar 14, 2016
PR-URL: #5678 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
evanlucas pushed a commit that referenced this pull request Mar 14, 2016
PR-URL: #5678 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
evanlucas pushed a commit that referenced this pull request Mar 14, 2016
PR-URL: #5678 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Contributor
Fishrock123 commented Mar 14, 2016
@watilde First commits I see! Welcome! 👏 :D |
rvagg pushed a commit that referenced this pull request Mar 16, 2016
PR-URL: #5678 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
rvagg pushed a commit that referenced this pull request Mar 16, 2016
PR-URL: #5678 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
rvagg pushed a commit that referenced this pull request Mar 16, 2016
PR-URL: #5678 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Contributor
MylesBorins commented Mar 17, 2016
the only commit of the bunch that applied to v4.x is 23df9d9 Adding both the land-on and dont-land tags |
MylesBorins pushed a commit that referenced this pull request Mar 17, 2016
PR-URL: #5678 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
PR-URL: #5678 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
PR-URL: #5678 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
test (or a benchmark) included?
existing APIs, or introduces new ones)?
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Affected core subsystem(s)
fs, dgram, addons
Description of change
addons:
dgram:
fs: