Skip to content

src: remove workaround for container-overflow#56851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
lemire wants to merge 2 commits into
base:main
Choose a base branch
from
Open

src: remove workaround for container-overflow #56851

lemire wants to merge 2 commits into from

Conversation

@lemire
Copy link
Member

@lemirelemire commented Jan 31, 2025•
edited
Loading

In PR #55591, I added a workaround for issue #55584

This PR stated the following:

With some glue code, this PR should work around this issue. It somewhat ugly code. In a future release of simdjson, we will provide a more convenient function that avoids such ugly workaround. A future PR will make the code prettier.

It is now time to make the code pretty again. We are removing a blob of hard-to-understand C++ code.

The workaround is no longer needed.

This PR does not change the functionality, it only makes the code nicer.

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jan 31, 2025
@lemirelemire added request-ci Add this label to start a Jenkins CI on a PR. and removed c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jan 31, 2025
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 31, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 31, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/64882/

@aduh95
Copy link
Contributor

aduh95 commented Nov 8, 2025

This needs a rebase

@aduh95aduh95 added stalled Issues and PRs that are stalled. needs-ci PRs that need a full CI run. labels Nov 8, 2025
@github-actions
Copy link
Contributor

github-actionsbot commented Nov 8, 2025

This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.

@github-actionsgithub-actionsbot removed the stalled Issues and PRs that are stalled. label Nov 9, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@lpincalpincalpinca approved these changes

@anonriganonriganonrig approved these changes

@addaleaxaddaleaxAwaiting requested review from addaleax

Assignees

No one assigned

Labels

needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@lemire@nodejs-github-bot@aduh95@jasnell@lpinca@anonrig