Skip to content

src: fix process exit listeners not receiving unsettled tla codes#56872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 10 commits into from
Mar 8, 2025
Merged

src: fix process exit listeners not receiving unsettled tla codes #56872

nodejs-github-bot merged 10 commits into from
Mar 8, 2025

Conversation

@dario-piotrowicz
Copy link
Member

@dario-piotrowiczdario-piotrowicz commented Feb 2, 2025•
edited
Loading

fix listeners registered via process.on('exit', ... not receiving error code 13 when an unsettled top-level-await is encountered in the code

Fixes: #53551

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Feb 2, 2025
@dario-piotrowiczdario-piotrowiczforce-pushed the dario/53551/process-on-exit-unsettled-tlas branch from eef4c1f to 80a0041CompareFebruary 2, 2025 00:35
@codecov
Copy link

codecovbot commented Feb 2, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.24%. Comparing base (db4dcc0) to head (14b759a).
Report is 68 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #56872 +/- ## ======================================= Coverage 90.24% 90.24% ======================================= Files 630 630 Lines 184921 184909 -12 Branches 36185 36187 +2 ======================================= Hits 166879 166879 + Misses 11065 11058 -7 + Partials 6977 6972 -5
Files with missing linesCoverage Δ
lib/internal/bootstrap/node.js99.57% <100.00%> (-0.01%)⬇️
src/api/embed_helpers.cc74.61% <100.00%> (-0.02%)⬇️
src/api/hooks.cc84.55% <100.00%> (+0.83%)⬆️
src/env-inl.h96.97% <100.00%> (+0.02%)⬆️
src/env.h98.14% <ø> (ø)

... and 23 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

joyeecheung
joyeecheung reviewed Feb 4, 2025
View reviewed changes
Copy link
Member

@joyeecheungjoyeecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Some comments about the approaches taken.

@dario-piotrowiczdario-piotrowiczforce-pushed the dario/53551/process-on-exit-unsettled-tlas branch 3 times, most recently from a717cb0 to b456e86CompareFebruary 9, 2025 18:13
@dario-piotrowiczdario-piotrowiczforce-pushed the dario/53551/process-on-exit-unsettled-tlas branch from b456e86 to 7a48cfdCompareFebruary 9, 2025 19:48
@anonriganonrig requested a review from jasnellFebruary 12, 2025 00:28
@anonriganonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Feb 12, 2025
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 12, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
aduh95
aduh95 reviewed Feb 12, 2025
View reviewed changes
aduh95
aduh95 reviewed Feb 12, 2025
View reviewed changes
aduh95
aduh95 reviewed Feb 12, 2025
View reviewed changes
@aduh95aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 13, 2025
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 13, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
joyeecheung
joyeecheung approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@joyeecheungjoyeecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 15, 2025•
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/65235/ 💛

aduh95
aduh95 reviewed Feb 28, 2025
View reviewed changes
aduh95
aduh95 reviewed Feb 28, 2025
View reviewed changes
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 2, 2025
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 2, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 2, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/65505/

@joyeecheungjoyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 8, 2025
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 8, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 8, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/65642/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 8, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/65647/

@aduh95aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Mar 8, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 8, 2025
@nodejs-github-botnodejs-github-bot merged commit b3b9f52 into nodejs:mainMar 8, 2025
70 checks passed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 8, 2025

Landed in b3b9f52

@github-actionsgithub-actionsbot mentioned this pull request Mar 12, 2025
Merged
@aduh95aduh95 mentioned this pull request Apr 11, 2025
Merged
@alblandinoalblandino mentioned this pull request May 21, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joyeecheungjoyeecheungjoyeecheung approved these changes

@jasnelljasnelljasnell approved these changes

@anonriganonriganonrig approved these changes

@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect exitCode when process fails due to circular dependency of dynamic import

6 participants

@dario-piotrowicz@nodejs-github-bot@jasnell@anonrig@joyeecheung@aduh95