src: add self-assigment memcpy checks#56986
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Feb 10, 2025
Review requested:
|
nodejs-github-bot added c++ 
wooffieforce-pushed the fix-issue-56718 branch from 06582bf to 399dcc4Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## main #56986 +/- ## ========================================== + Coverage 89.11% 89.13% +0.01% ========================================== Files 665 665 Lines 193174 193176 +2 Branches 37187 37188 +1 ========================================== + Hits 172154 172185 +31 + Misses 13754 13745 -9 + Partials 7266 7246 -20
|
jasnell approved these changes Feb 10, 2025
Collaborator
nodejs-github-bot commented Feb 10, 2025
addaleax approved these changes Feb 11, 2025
Collaborator
nodejs-github-bot commented Feb 11, 2025
Collaborator
nodejs-github-bot commented Feb 11, 2025
addaleax added the commit-queue nodejs-github-bot removed the commit-queue nodejs-github-bot merged commit 85f5a6c into nodejs:main 53 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Collaborator
nodejs-github-bot commented Feb 12, 2025
Landed in 85f5a6c |
targos pushed a commit that referenced this pull request Feb 17, 2025
Fixes: #56718 PR-URL: #56986 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
acidiney pushed a commit to acidiney/node that referenced this pull request Feb 23, 2025
Fixes: nodejs#56718 PR-URL: nodejs#56986 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
aduh95 pushed a commit that referenced this pull request Apr 2, 2025
Fixes: #56718 PR-URL: #56986 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
aduh95 pushed a commit that referenced this pull request Apr 3, 2025
Fixes: #56718 PR-URL: #56986 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Apr 16, 2025
Fixes: #56718 PR-URL: #56986 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Apr 17, 2025
Fixes: #56718 PR-URL: #56986 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #56718
Maybe it's pointless, but imho more clear