test: fix test-without-async-context-frame.mjs in debug mode#57034
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The test is spawning the python test runner directly without considering whether the current build is a debug build or not i.e. does not propage the mode parameter when the test is run with --mode=debug, so it always ends up using the release build to run the test even if the test is being run for debug builds. This patch fixes that.
nodejs-github-bot added needs-ci 
richardlau approved these changes Feb 13, 2025
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Feb 13, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #57034 +/- ## ========================================== - Coverage 89.11% 89.10% -0.01% ========================================== Files 665 665 Lines 193193 193193 Branches 37212 37213 +1 ========================================== - Hits 172158 172148 -10 + Misses 13775 13773 -2 - Partials 7260 7272 +12 |
lpinca approved these changes Feb 14, 2025
Member
lpinca commented Feb 14, 2025
Collaborator
nodejs-github-bot commented Feb 14, 2025
Collaborator
nodejs-github-bot commented Feb 14, 2025
lpinca added the commit-queue nodejs-github-bot removed the commit-queue nodejs-github-bot merged commit a613f2f into nodejs:main 66 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Collaborator
nodejs-github-bot commented Feb 15, 2025
Landed in a613f2f |
acidiney pushed a commit to acidiney/node that referenced this pull request Feb 23, 2025
The test is spawning the python test runner directly without considering whether the current build is a debug build or not i.e. does not propage the mode parameter when the test is run with --mode=debug, so it always ends up using the release build to run the test even if the test is being run for debug builds. This patch fixes that. PR-URL: nodejs#57034 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Feb 25, 2025
The test is spawning the python test runner directly without considering whether the current build is a debug build or not i.e. does not propage the mode parameter when the test is run with --mode=debug, so it always ends up using the release build to run the test even if the test is being run for debug builds. This patch fixes that. PR-URL: #57034 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Feb 25, 2025
The test is spawning the python test runner directly without considering whether the current build is a debug build or not i.e. does not propage the mode parameter when the test is run with --mode=debug, so it always ends up using the release build to run the test even if the test is being run for debug builds. This patch fixes that. PR-URL: #57034 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95 pushed a commit that referenced this pull request Apr 2, 2025
The test is spawning the python test runner directly without considering whether the current build is a debug build or not i.e. does not propage the mode parameter when the test is run with --mode=debug, so it always ends up using the release build to run the test even if the test is being run for debug builds. This patch fixes that. PR-URL: #57034 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95 pushed a commit that referenced this pull request Apr 3, 2025
The test is spawning the python test runner directly without considering whether the current build is a debug build or not i.e. does not propage the mode parameter when the test is run with --mode=debug, so it always ends up using the release build to run the test even if the test is being run for debug builds. This patch fixes that. PR-URL: #57034 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Apr 16, 2025
The test is spawning the python test runner directly without considering whether the current build is a debug build or not i.e. does not propage the mode parameter when the test is run with --mode=debug, so it always ends up using the release build to run the test even if the test is being run for debug builds. This patch fixes that. PR-URL: #57034 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Apr 17, 2025
The test is spawning the python test runner directly without considering whether the current build is a debug build or not i.e. does not propage the mode parameter when the test is run with --mode=debug, so it always ends up using the release build to run the test even if the test is being run for debug builds. This patch fixes that. PR-URL: #57034 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test is spawning the python test runner directly without considering whether the current build is a debug build or not i.e. does not propage the mode parameter when the test is run with --mode=debug, so it always ends up using the release build to run the test even if the test is being run for debug builds. This patch fixes that.