Skip to content

sea: suppress builtin warning with disableExperimentalSEAWarning option#57086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
koooge wants to merge 1 commit into from
Closed

sea: suppress builtin warning with disableExperimentalSEAWarning option #57086

koooge wants to merge 1 commit into from

Conversation

@koooge
Copy link
Contributor

@kooogekoooge commented Feb 16, 2025

@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Feb 16, 2025
joyeecheung
joyeecheung reviewed Feb 16, 2025
View reviewed changes
@codecov
Copy link

codecovbot commented Feb 16, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.09%. Comparing base (59cdd4f) to head (42af3be).
Report is 22 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #57086 +/- ## ========================================== - Coverage 89.10% 89.09% -0.02%  ========================================== Files 665 665 Lines 193203 193250 +47 Branches 37216 37226 +10 ========================================== + Hits 172163 172175 +12 - Misses 13767 13805 +38 + Partials 7273 7270 -3
Files with missing linesCoverage Δ
lib/internal/main/embedding.js88.88% <100.00%> (+0.09%)⬆️

... and 26 files with indirect coverage changes

@kooogekooogeforce-pushed the sea-disable-builtin-warning branch from dec12c5 to 42af3beCompareFebruary 16, 2025 10:22
@joyeecheungjoyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 16, 2025
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 16, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@joyeecheungjoyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 17, 2025
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 17, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 17, 2025•
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/65273/ 💛

jasnell pushed a commit that referenced this pull request Feb 18, 2025
@koooge@jasnell
sea: suppress builtin warning with disableExperimentalSEAWarning option
6fe0723
Signed-off-by: koooge <[email protected]> PR-URL: #57086 Refs: nodejs/single-executable#107 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Feb 18, 2025

Landed in 6fe0723

@jasnelljasnell closed this Feb 18, 2025
acidiney pushed a commit to acidiney/node that referenced this pull request Feb 23, 2025
@koooge@acidiney
sea: suppress builtin warning with disableExperimentalSEAWarning option
4f02009
Signed-off-by: koooge <[email protected]> PR-URL: nodejs#57086 Refs: nodejs/single-executable#107 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Feb 24, 2025
@koooge@targos
sea: suppress builtin warning with disableExperimentalSEAWarning option
f2db69a
Signed-off-by: koooge <[email protected]> PR-URL: #57086 Refs: nodejs/single-executable#107 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
@github-actionsgithub-actionsbot mentioned this pull request Feb 25, 2025
Merged
targos pushed a commit that referenced this pull request Feb 25, 2025
@koooge@targos
sea: suppress builtin warning with disableExperimentalSEAWarning option
ac35106
Signed-off-by: koooge <[email protected]> PR-URL: #57086 Refs: nodejs/single-executable#107 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
aduh95 pushed a commit that referenced this pull request Apr 2, 2025
@koooge@aduh95
sea: suppress builtin warning with disableExperimentalSEAWarning option
1e0f3d6
Signed-off-by: koooge <[email protected]> PR-URL: #57086 Refs: nodejs/single-executable#107 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
aduh95 pushed a commit that referenced this pull request Apr 3, 2025
@koooge@aduh95
sea: suppress builtin warning with disableExperimentalSEAWarning option
3110e64
Signed-off-by: koooge <[email protected]> PR-URL: #57086 Refs: nodejs/single-executable#107 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
@aduh95aduh95 mentioned this pull request Apr 11, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 16, 2025
@koooge@RafaelGSS
sea: suppress builtin warning with disableExperimentalSEAWarning option
8cfa144
Signed-off-by: koooge <[email protected]> PR-URL: #57086 Refs: nodejs/single-executable#107 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Apr 17, 2025
@koooge@RafaelGSS
sea: suppress builtin warning with disableExperimentalSEAWarning option
dfcd9b1
Signed-off-by: koooge <[email protected]> PR-URL: #57086 Refs: nodejs/single-executable#107 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@joyeecheungjoyeecheungjoyeecheung approved these changes

Assignees

No one assigned

Labels

needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@koooge@nodejs-github-bot@jasnell@joyeecheung