src: replace NewFromUtf8 with OneByteString where appropriate#57096
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Feb 16, 2025
Review requested:
|
nodejs-github-bot added c++ 
anonrig approved these changes Feb 16, 2025
Uh oh!
There was an error while loading. Please reload this page.
src/spawn_sync.cc Outdated
| String::NewFromUtf8(env()->isolate(), | ||
| signo_string(term_signal_)) | ||
| .ToLocalChecked()) | ||
| OneByteString(env()->isolate(), signo_string(term_signal_))) |
Member
There was a problem hiding this comment.
Should we cache this signo_string() result in the future?
MemberAuthor
There was a problem hiding this comment.
I wouldn't think that is necessary.
aduh95 approved these changes Feb 16, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #57096 +/- ## ======================================= Coverage 89.05% 89.06% ======================================= Files 665 665 Lines 193299 193292 -7 Branches 37257 37254 -3 ======================================= + Hits 172152 172155 +3 + Misses 13841 13834 -7 + Partials 7306 7303 -3
|
legendecas approved these changes Feb 17, 2025
This comment was marked as outdated.
This comment was marked as outdated.
jasnell added the author ready 
jasnellforce-pushed the jasnell/use-onebytestring-where-appropriate branch from ccf154e to 84e19d1Compare This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
nodejs-github-bot commented Feb 18, 2025
lpinca approved these changes Feb 18, 2025
lpinca added the commit-queue nodejs-github-bot removed the commit-queue nodejs-github-bot merged commit a724a9e into nodejs:main 45 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Collaborator
nodejs-github-bot commented Feb 18, 2025
Landed in a724a9e |
acidiney pushed a commit to acidiney/node that referenced this pull request Feb 23, 2025
PR-URL: nodejs#57096 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Feb 24, 2025
PR-URL: #57096 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Feb 25, 2025
PR-URL: #57096 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95 pushed a commit that referenced this pull request Apr 2, 2025
PR-URL: #57096 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95 pushed a commit that referenced this pull request Apr 3, 2025
PR-URL: #57096 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Apr 16, 2025
PR-URL: #57096 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Apr 17, 2025
PR-URL: #57096 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.