Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34.3k
[20.x backport] worker: add postMessageToThread#57101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20.x backport] worker: add postMessageToThread #57101
Uh oh!
There was an error while loading. Please reload this page.
Conversation
nodejs-github-bot commented Feb 17, 2025
Review requested:
|
nodejs-github-bot commented Feb 17, 2025
nodejs-github-bot commented Feb 17, 2025
PR-URL: nodejs#53682 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
2e70ecf to 4e1795fComparenodejs-github-bot commented Feb 17, 2025
nodejs-github-bot commented Feb 18, 2025
nodejs-github-bot commented Feb 18, 2025
ShogunPanda commented Feb 18, 2025
@marco-ippolito I have an unrelated error on this PR but all the tests are passing. What shall I do? |
marco-ippolito commented Feb 18, 2025
I only see coverage failing which is fine. Can you paste the error? |
marco-ippolito commented Feb 18, 2025
@nodejs/platform-windows we are getting a range error on windows |
targos commented Feb 18, 2025
This looks like an out of memory error. Did it happen multiple times ? |
ShogunPanda commented Feb 18, 2025
Yes, I retried that several times. But it seems not related to my changes. |
targos commented Feb 18, 2025
Unrelated indeed. the daily v20.x build fails with the same test: https://ci.nodejs.org/view/All/job/node-daily-v20.x-staging/472/ |
ShogunPanda commented Feb 18, 2025
So are we good to merge this? |
PR-URL: #53682 Backport-PR-URL: #57101 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
marco-ippolito commented Feb 20, 2025
Landed in 73b5c16 |
Backport of 66a635c