Revert "test: add tests for REPL custom evals"#57793
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This reverts commit 1f7cfb7, which was merged into the main branch despite relevant test failures.
Contributor
Fast-track has been requested by @tniessen. Please 👍 to approve. |
nodejs-github-bot added needs-ci 
github-actionsbot added request-ci-failed Contributor
Failed to start CI⚠ No approving reviews found ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/14335840440 |
cjihrig approved these changes Apr 8, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #57793 +/- ## ========================================== - Coverage 90.23% 90.22% -0.02% ========================================== Files 630 630 Lines 185288 185289 +1 Branches 36344 36342 -2 ========================================== - Hits 167203 167178 -25 - Misses 11006 11009 +3 - Partials 7079 7102 +23
🚀 New features to boost your workflow:
|
tniessen added request-ci github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Apr 8, 2025
tniessen added the author ready 
lpinca approved these changes Apr 8, 2025
Collaborator
nodejs-github-bot commented Apr 8, 2025
aduh95 approved these changes Apr 8, 2025
richardlau approved these changes Apr 8, 2025
tniessen added the commit-queue nodejs-github-bot removed the commit-queue nodejs-github-bot merged commit a6cc240 into nodejs:main 80 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Collaborator
nodejs-github-bot commented Apr 8, 2025
Landed in a6cc240 |
JonasBa pushed a commit to JonasBa/node that referenced this pull request Apr 11, 2025
This reverts commit 1f7cfb7, which was merged into the main branch despite relevant test failures. PR-URL: nodejs#57793 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]>
dario-piotrowicz added a commit to dario-piotrowicz/node that referenced this pull request Apr 12, 2025
this commit reintroduces the REPL custom eval tests that have been introduced in nodejs#57691 but reverted in nodejs#57793 the tests turned out problematic before because `getReplOutput`, the function used to return the repl output wasn't taking into account that input processing and output emitting are asynchronous operation can can resolve with a small delay
dario-piotrowicz added a commit to dario-piotrowicz/node that referenced this pull request Apr 12, 2025
this commit reintroduces the REPL custom eval tests that have been introduced in nodejs#57691 but reverted in nodejs#57793 the tests turned out problematic before because `getReplOutput`, the function used to return the repl output wasn't taking into account that input processing and output emitting are asynchronous operation can can resolve with a small delay
dario-piotrowicz added a commit to dario-piotrowicz/node that referenced this pull request Apr 12, 2025
this commit reintroduces the REPL custom eval tests that have been introduced in nodejs#57691 but reverted in nodejs#57793 the tests turned out problematic before because `getReplOutput`, the function used to return the repl output wasn't taking into account that input processing and output emitting are asynchronous operation can can resolve with a small delay
dario-piotrowicz added a commit to dario-piotrowicz/node that referenced this pull request Apr 12, 2025
this commit reintroduces the REPL custom eval tests that have been introduced in nodejs#57691 but reverted in nodejs#57793 the tests turned out problematic before because `getReplOutput`, the function used to return the repl output wasn't taking into account that input processing and output emitting are asynchronous operation can can resolve with a small delay
dario-piotrowicz added a commit to dario-piotrowicz/node that referenced this pull request Apr 18, 2025
this commit reintroduces the REPL custom eval tests that have been introduced in nodejs#57691 but reverted in nodejs#57793 the tests turned out problematic before because `getReplOutput`, the function used to return the repl output, wasn't taking into account that input processing and output emitting are asynchronous operation can resolve with a small delay
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
This reverts commit 1f7cfb7, which was merged into the main branch despite relevant test failures. PR-URL: #57793 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]>
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
This reverts commit 1f7cfb7, which was merged into the main branch despite relevant test failures. PR-URL: #57793 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]>
aduh95 pushed a commit that referenced this pull request May 6, 2025
This reverts commit 1f7cfb7, which was merged into the main branch despite relevant test failures. PR-URL: #57793 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]>
dario-piotrowicz added a commit to dario-piotrowicz/node that referenced this pull request May 11, 2025
this commit reintroduces the REPL custom eval tests that have been introduced in nodejs#57691 but reverted in nodejs#57793 the tests turned out problematic before because `getReplOutput`, the function used to return the repl output wasn't taking into account that input processing and output emitting are asynchronous operation can can resolve with a small delay
dario-piotrowicz added a commit to dario-piotrowicz/node that referenced this pull request May 11, 2025
this commit reintroduces the REPL custom eval tests that have been introduced in nodejs#57691 but reverted in nodejs#57793 the tests turned out problematic before because `getReplOutput`, the function used to return the repl output wasn't taking into account that input processing and output emitting are asynchronous operation can can resolve with a small delay
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
This reverts commit 1f7cfb7, which was merged into the main branch despite relevant test failures. PR-URL: #57793 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]>
aduh95 pushed a commit that referenced this pull request May 16, 2025
This reverts commit 1f7cfb7, which was merged into the main branch despite relevant test failures. PR-URL: #57793 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
This reverts commit 1f7cfb7, which was merged into the main branch despite relevant test failures. PR-URL: #57793 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
This reverts commit 1f7cfb7, which was merged into the main branch despite relevant test failures. PR-URL: #57793 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
This reverts commit 1f7cfb7, which was merged into the main branch despite relevant test failures. PR-URL: #57793 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]>
dario-piotrowicz added a commit to dario-piotrowicz/node that referenced this pull request May 18, 2025
this commit reintroduces the REPL custom eval tests that have been introduced in nodejs#57691 but reverted in nodejs#57793 the tests turned out problematic before because `getReplOutput`, the function used to return the repl output wasn't taking into account that input processing and output emitting are asynchronous operation can can resolve with a small delay
aduh95 pushed a commit that referenced this pull request May 19, 2025
This reverts commit 1f7cfb7, which was merged into the main branch despite relevant test failures. PR-URL: #57793 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]>
dario-piotrowicz added a commit to dario-piotrowicz/node that referenced this pull request May 23, 2025
this commit reintroduces the REPL custom eval tests that have been introduced in nodejs#57691 but reverted in nodejs#57793 the tests turned out problematic before because `getReplOutput`, the function used to return the repl output wasn't taking into account that input processing and output emitting are asynchronous operation can can resolve with a small delay
ghost mentioned this pull request dario-piotrowicz added a commit to dario-piotrowicz/node that referenced this pull request Jun 10, 2025
this commit reintroduces the REPL custom eval tests that have been introduced in nodejs#57691 but reverted in nodejs#57793 the tests turned out problematic before because `getReplOutput`, the function used to return the repl output wasn't taking into account that input processing and output emitting are asynchronous operation can resolve with a small delay the new implementation here replaces `getReplOutput` with `getReplRunOutput` that resolves repl inputs by running them and using the repl prompt as an indicator to when the input processing has completed
dario-piotrowicz added a commit to dario-piotrowicz/node that referenced this pull request Jun 10, 2025
this commit reintroduces the REPL custom eval tests that have been introduced in nodejs#57691 but reverted in nodejs#57793 the tests turned out problematic before because `getReplOutput`, the function used to return the repl output wasn't taking into account that input processing and output emitting are asynchronous operation can resolve with a small delay the new implementation here replaces `getReplOutput` with `getReplRunOutput` that resolves repl inputs by running them and using the repl prompt as an indicator to when the input processing has completed
dario-piotrowicz added a commit to dario-piotrowicz/node that referenced this pull request Jun 10, 2025
this commit reintroduces the REPL custom eval tests that have been introduced in nodejs#57691 but reverted in nodejs#57793 the tests turned out problematic before because `getReplOutput`, the function used to return the repl output wasn't taking into account that input processing and output emitting are asynchronous operation can resolve with a small delay the new implementation here replaces `getReplOutput` with `getReplRunOutput` that resolves repl inputs by running them and using the repl prompt as an indicator to when the input processing has completed
dario-piotrowicz added a commit to dario-piotrowicz/node that referenced this pull request Jun 11, 2025
this commit reintroduces the REPL custom eval tests that have been introduced in nodejs#57691 but reverted in nodejs#57793 the tests turned out problematic before because `getReplOutput`, the function used to return the repl output wasn't taking into account that input processing and output emitting are asynchronous operation can resolve with a small delay the new implementation here replaces `getReplOutput` with `getReplRunOutput` that resolves repl inputs by running them and using the repl prompt as an indicator to when the input processing has completed
dario-piotrowicz added a commit to dario-piotrowicz/node that referenced this pull request Jun 11, 2025
this commit reintroduces the REPL custom eval tests that have been introduced in nodejs#57691 but reverted in nodejs#57793 the tests turned out problematic before because `getReplOutput`, the function used to return the repl output wasn't taking into account that input processing and output emitting are asynchronous operation can resolve with a small delay the new implementation here replaces `getReplOutput` with `getReplRunOutput` that resolves repl inputs by running them and using the repl prompt as an indicator to when the input processing has completed
dario-piotrowicz added a commit to dario-piotrowicz/node that referenced this pull request Jun 11, 2025
this commit reintroduces the REPL custom eval tests that have been introduced in nodejs#57691 but reverted in nodejs#57793 the tests turned out problematic before because `getReplOutput`, the function used to return the repl output wasn't taking into account that input processing and output emitting are asynchronous operation can resolve with a small delay the new implementation here replaces `getReplOutput` with `getReplRunOutput` that resolves repl inputs by running them and using the repl prompt as an indicator to when the input processing has completed
dario-piotrowicz added a commit to dario-piotrowicz/node that referenced this pull request Jun 11, 2025
this commit reintroduces the REPL custom eval tests that have been introduced in nodejs#57691 but reverted in nodejs#57793 the tests turned out problematic before because `getReplOutput`, the function used to return the repl output wasn't taking into account that input processing and output emitting are asynchronous operation can resolve with a small delay the new implementation here replaces `getReplOutput` with `getReplRunOutput` that resolves repl inputs by running them and using the repl prompt as an indicator to when the input processing has completed
nodejs-github-bot pushed a commit that referenced this pull request Jun 15, 2025
this commit reintroduces the REPL custom eval tests that have been introduced in #57691 but reverted in #57793 the tests turned out problematic before because `getReplOutput`, the function used to return the repl output wasn't taking into account that input processing and output emitting are asynchronous operation can resolve with a small delay the new implementation here replaces `getReplOutput` with `getReplRunOutput` that resolves repl inputs by running them and using the repl prompt as an indicator to when the input processing has completed PR-URL: #57850 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
targos pushed a commit that referenced this pull request Jun 16, 2025
this commit reintroduces the REPL custom eval tests that have been introduced in #57691 but reverted in #57793 the tests turned out problematic before because `getReplOutput`, the function used to return the repl output wasn't taking into account that input processing and output emitting are asynchronous operation can resolve with a small delay the new implementation here replaces `getReplOutput` with `getReplRunOutput` that resolves repl inputs by running them and using the repl prompt as an indicator to when the input processing has completed PR-URL: #57850 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
aduh95 pushed a commit that referenced this pull request Jul 21, 2025
this commit reintroduces the REPL custom eval tests that have been introduced in #57691 but reverted in #57793 the tests turned out problematic before because `getReplOutput`, the function used to return the repl output wasn't taking into account that input processing and output emitting are asynchronous operation can resolve with a small delay the new implementation here replaces `getReplOutput` with `getReplRunOutput` that resolves repl inputs by running them and using the repl prompt as an indicator to when the input processing has completed PR-URL: #57850 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
aduh95 pushed a commit that referenced this pull request Jul 24, 2025
this commit reintroduces the REPL custom eval tests that have been introduced in #57691 but reverted in #57793 the tests turned out problematic before because `getReplOutput`, the function used to return the repl output wasn't taking into account that input processing and output emitting are asynchronous operation can resolve with a small delay the new implementation here replaces `getReplOutput` with `getReplRunOutput` that resolves repl inputs by running them and using the repl prompt as an indicator to when the input processing has completed PR-URL: #57850 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 1f7cfb7, which, as far as I can tell, was merged into the main branch despite relevant test failures.
The new test also started showing up in reliability reports immediately, see nodejs/reliability#1167.
Refs: #57691 (comment)