Skip to content

[v22.x backport] src: add config file support#57958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aduh95 merged 5 commits into from
May 6, 2025
Merged

[v22.x backport] src: add config file support #57958

aduh95 merged 5 commits into from
May 6, 2025

Conversation

@marco-ippolito
Copy link
Member

@marco-ippolitomarco-ippolito commented Apr 21, 2025

No description provided.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 21, 2025

Review requested:

  • @nodejs/config
  • @nodejs/gyp
  • @nodejs/startup

@nodejs-github-botnodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. labels Apr 21, 2025
@marco-ippolitomarco-ippolito added the config Issues or PRs related to the config subsystem label Apr 21, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 23, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/66426/

@marco-ippolito
Copy link
MemberAuthor

marco-ippolito commented Apr 24, 2025

I noticed I cherry-pick commit without metadata 😫

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 28, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/66497/

RafaelGSS
RafaelGSS approved these changes Apr 29, 2025
View reviewed changes
Copy link
Member

@RafaelGSSRafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aduh95
Copy link
Contributor

aduh95 commented May 6, 2025

To get backlinks to the PRs being backported:

@marco-ippolito@aduh95
src: add config file support
b3bdf0f
PR-URL: nodejs#57016 Backport-PR-URL: nodejs#57958 Refs: nodejs#53787 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
@marco-ippolito@aduh95
src: create THROW_ERR_OPTIONS_BEFORE_BOOTSTRAPPING
d8cf8d2
PR-URL: nodejs#57016 Backport-PR-URL: nodejs#57958 Refs: nodejs#53787 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
@marco-ippolito@aduh95
src: namespace config file flags
143064b
PR-URL: nodejs#57170 Backport-PR-URL: nodejs#57958 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
@marco-ippolito@aduh95
test: add more coverage to node_config_file
a6cff20
PR-URL: nodejs#57170 Backport-PR-URL: nodejs#57958 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
@marco-ippolito@aduh95
src: set default config as node.config.json
64a157f
PR-URL: nodejs#57171 Backport-PR-URL: nodejs#57958 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
@aduh95aduh95force-pushed the backport-config-file branch from 3db769a to 64a157fCompareMay 6, 2025 20:28
@aduh95aduh95 merged commit 64a157f into nodejs:v22.x-stagingMay 6, 2025
13 of 19 checks passed
@aduh95
Copy link
Contributor

aduh95 commented May 6, 2025•
edited
Loading

Landed in e35638d...8e58fbe

aduh95 pushed a commit that referenced this pull request May 6, 2025
@marco-ippolito@aduh95
src: add config file support
cc6fef9
PR-URL: #57016 Backport-PR-URL: #57958 Refs: #53787 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@marco-ippolito@aduh95
src: create THROW_ERR_OPTIONS_BEFORE_BOOTSTRAPPING
8f36a2c
PR-URL: #57016 Backport-PR-URL: #57958 Refs: #53787 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@marco-ippolito@aduh95
src: namespace config file flags
0545e1b
PR-URL: #57170 Backport-PR-URL: #57958 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@marco-ippolito@aduh95
test: add more coverage to node_config_file
3004682
PR-URL: #57170 Backport-PR-URL: #57958 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@marco-ippolito@aduh95
src: set default config as node.config.json
8e58fbe
PR-URL: #57171 Backport-PR-URL: #57958 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@marco-ippolito@RafaelGSS
src: add config file support
cb92a2a
PR-URL: #57016 Backport-PR-URL: #57958 Refs: #53787 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@marco-ippolito@RafaelGSS
src: create THROW_ERR_OPTIONS_BEFORE_BOOTSTRAPPING
d77e25d
PR-URL: #57016 Backport-PR-URL: #57958 Refs: #53787 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@marco-ippolito@RafaelGSS
src: namespace config file flags
9ff58d5
PR-URL: #57170 Backport-PR-URL: #57958 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@marco-ippolito@RafaelGSS
test: add more coverage to node_config_file
033127c
PR-URL: #57170 Backport-PR-URL: #57958 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@marco-ippolito@RafaelGSS
src: set default config as node.config.json
914a4d5
PR-URL: #57171 Backport-PR-URL: #57958 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95 pushed a commit that referenced this pull request May 16, 2025
@marco-ippolito@aduh95
src: add config file support
c874310
PR-URL: #57016 Backport-PR-URL: #57958 Refs: #53787 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
aduh95 pushed a commit that referenced this pull request May 16, 2025
@marco-ippolito@aduh95
src: create THROW_ERR_OPTIONS_BEFORE_BOOTSTRAPPING
8f6beba
PR-URL: #57016 Backport-PR-URL: #57958 Refs: #53787 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
aduh95 pushed a commit that referenced this pull request May 16, 2025
@marco-ippolito@aduh95
src: namespace config file flags
287a0c1
PR-URL: #57170 Backport-PR-URL: #57958 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
aduh95 pushed a commit that referenced this pull request May 16, 2025
@marco-ippolito@aduh95
test: add more coverage to node_config_file
5758187
PR-URL: #57170 Backport-PR-URL: #57958 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
aduh95 pushed a commit that referenced this pull request May 16, 2025
@marco-ippolito@aduh95
src: set default config as node.config.json
e004de5
PR-URL: #57171 Backport-PR-URL: #57958 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@marco-ippolito@aduh95
src: add config file support
1c66278
PR-URL: #57016 Backport-PR-URL: #57958 Refs: #53787 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@marco-ippolito@aduh95
src: create THROW_ERR_OPTIONS_BEFORE_BOOTSTRAPPING
262bbfd
PR-URL: #57016 Backport-PR-URL: #57958 Refs: #53787 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@marco-ippolito@aduh95
src: namespace config file flags
c4d59a6
PR-URL: #57170 Backport-PR-URL: #57958 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@marco-ippolito@aduh95
test: add more coverage to node_config_file
c75bc27
PR-URL: #57170 Backport-PR-URL: #57958 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@marco-ippolito@aduh95
src: set default config as node.config.json
6a7087e
PR-URL: #57171 Backport-PR-URL: #57958 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@marco-ippolito@aduh95
src: add config file support
c360282
PR-URL: #57016 Backport-PR-URL: #57958 Refs: #53787 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@marco-ippolito@aduh95
src: create THROW_ERR_OPTIONS_BEFORE_BOOTSTRAPPING
d0f895d
PR-URL: #57016 Backport-PR-URL: #57958 Refs: #53787 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@marco-ippolito@aduh95
src: namespace config file flags
275b227
PR-URL: #57170 Backport-PR-URL: #57958 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@marco-ippolito@aduh95
test: add more coverage to node_config_file
53e93c2
PR-URL: #57170 Backport-PR-URL: #57958 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@marco-ippolito@aduh95
src: set default config as node.config.json
188ad24
PR-URL: #57171 Backport-PR-URL: #57958 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@marco-ippolito@aduh95
src: add config file support
fc9f75b
PR-URL: #57016 Backport-PR-URL: #57958 Refs: #53787 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@marco-ippolito@aduh95
src: create THROW_ERR_OPTIONS_BEFORE_BOOTSTRAPPING
e338c8f
PR-URL: #57016 Backport-PR-URL: #57958 Refs: #53787 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@marco-ippolito@aduh95
src: namespace config file flags
3612f2d
PR-URL: #57170 Backport-PR-URL: #57958 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@marco-ippolito@aduh95
test: add more coverage to node_config_file
c8c3872
PR-URL: #57170 Backport-PR-URL: #57958 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@marco-ippolito@aduh95
src: set default config as node.config.json
a7e7b7e
PR-URL: #57171 Backport-PR-URL: #57958 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95 pushed a commit that referenced this pull request May 18, 2025
@marco-ippolito@aduh95
src: add config file support
2d4111f
PR-URL: #57016 Backport-PR-URL: #57958 Refs: #53787 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
aduh95 pushed a commit that referenced this pull request May 18, 2025
@marco-ippolito@aduh95
src: create THROW_ERR_OPTIONS_BEFORE_BOOTSTRAPPING
5d31350
PR-URL: #57016 Backport-PR-URL: #57958 Refs: #53787 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
aduh95 pushed a commit that referenced this pull request May 18, 2025
@marco-ippolito@aduh95
src: namespace config file flags
ec4201d
PR-URL: #57170 Backport-PR-URL: #57958 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
aduh95 pushed a commit that referenced this pull request May 18, 2025
@marco-ippolito@aduh95
test: add more coverage to node_config_file
e24076d
PR-URL: #57170 Backport-PR-URL: #57958 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
aduh95 pushed a commit that referenced this pull request May 18, 2025
@marco-ippolito@aduh95
src: set default config as node.config.json
e85580d
PR-URL: #57171 Backport-PR-URL: #57958 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95 pushed a commit that referenced this pull request May 19, 2025
@marco-ippolito@aduh95
src: add config file support
0350c6f
PR-URL: #57016 Backport-PR-URL: #57958 Refs: #53787 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
aduh95 pushed a commit that referenced this pull request May 19, 2025
@marco-ippolito@aduh95
src: create THROW_ERR_OPTIONS_BEFORE_BOOTSTRAPPING
30bb1cc
PR-URL: #57016 Backport-PR-URL: #57958 Refs: #53787 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
aduh95 pushed a commit that referenced this pull request May 19, 2025
@marco-ippolito@aduh95
src: namespace config file flags
ccee741
PR-URL: #57170 Backport-PR-URL: #57958 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
aduh95 pushed a commit that referenced this pull request May 19, 2025
@marco-ippolito@aduh95
test: add more coverage to node_config_file
e90583b
PR-URL: #57170 Backport-PR-URL: #57958 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
aduh95 pushed a commit that referenced this pull request May 19, 2025
@marco-ippolito@aduh95
src: set default config as node.config.json
5d1230b
PR-URL: #57171 Backport-PR-URL: #57958 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RafaelGSSRafaelGSSRafaelGSS approved these changes

Assignees

No one assigned

Labels

configIssues or PRs related to the config subsystemlib / srcIssues and PRs related to general changes in the lib or src directory.needs-ciPRs that need a full CI run.v22.xIssues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marco-ippolito@nodejs-github-bot@aduh95@RafaelGSS