http,https: give names to anonymous or misnamed functions#58180
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Affected functions: - http.OutgoingMessage.prototype.cork - http.OutgoingMessage.prototype.uncork - http.Server.prototype.close - http.Server.prototype.closeAllConnections - http.Server.prototype.closeIdleConnections - http.Server.prototype[Symbol.asyncDispose] - http.Server.prototype[nodejs.rejection] - http.validateHeaderName - http.validateHeaderValue - https.Server.prototype.closeAllConnections - https.Server.prototype.closeIdleConnections - https.Server.prototype.close
Collaborator
nodejs-github-bot commented May 5, 2025
Review requested:
|
nodejs-github-bot added http 
MemberAuthor
LiviaMedeiros commented May 5, 2025
Comment on lines +622 to +623
| Server.prototype[EE.captureRejectionSymbol]= | ||
| assignFunctionName(EE.captureRejectionSymbol,function(err,event, ...args){ |
MemberAuthor
There was a problem hiding this comment.
Linter seems to be happy with this but better suggestions would be appreciated.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #58180 +/- ## ========================================== - Coverage 90.17% 90.15% -0.03% ========================================== Files 630 630 Lines 186503 186759 +256 Branches 36618 36654 +36 ========================================== + Hits 168188 168365 +177 - Misses 11120 11192 +72 - Partials 7195 7202 +7
🚀 New features to boost your workflow:
|
ShogunPanda approved these changes May 5, 2025
Ethan-Arrowood approved these changes May 8, 2025
jasnell approved these changes May 12, 2025
LiviaMedeiros added author ready nodejs-github-bot added commit-queue-failed Collaborator
nodejs-github-bot commented May 12, 2025
Commit Queue failed- Loading data for nodejs/node/pull/58180 ✔ Done loading data for nodejs/node/pull/58180 ----------------------------------- PR info ------------------------------------ Title http,https: give names to anonymous or misnamed functions (#58180) Author Livia Medeiros <[email protected]> (@LiviaMedeiros) Branch LiviaMedeiros:http-name-functions -> nodejs:main Labels http, https, author ready, needs-ci Commits 1 - http,https: give names to anonymous or misnamed functions Committers 1 - LiviaMedeiros <[email protected]> PR-URL: https://github.com/nodejs/node/pull/58180 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: James M Snell <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/58180 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: James M Snell <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 05 May 2025 12:39:34 GMT ✔ Approvals: 3 ✔ - Paolo Insogna (@ShogunPanda) (TSC): https://github.com/nodejs/node/pull/58180#pullrequestreview-2815427791 ✔ - Ethan Arrowood (@Ethan-Arrowood): https://github.com/nodejs/node/pull/58180#pullrequestreview-2825471155 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/58180#pullrequestreview-2831904689 ✔ Last GitHub CI successful ✘ No full Jenkins CI runs detected ℹ Last Benchmark CI on 2025-05-05T12:43:16Z: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1716/ - Querying data for job/node-test-pull-request/1716/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/14965261342 |
LiviaMedeiros added request-ci 
github-actionsbot removed the request-ci This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
nodejs-github-bot commented May 12, 2025
richardlau added the commit-queue nodejs-github-bot removed the commit-queue nodejs-github-bot merged commit cfd2021 into nodejs:main 85 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Collaborator
nodejs-github-bot commented May 12, 2025
Landed in cfd2021 |
targos pushed a commit that referenced this pull request May 16, 2025
Affected functions: - http.OutgoingMessage.prototype.cork - http.OutgoingMessage.prototype.uncork - http.Server.prototype.close - http.Server.prototype.closeAllConnections - http.Server.prototype.closeIdleConnections - http.Server.prototype[Symbol.asyncDispose] - http.Server.prototype[nodejs.rejection] - http.validateHeaderName - http.validateHeaderValue - https.Server.prototype.closeAllConnections - https.Server.prototype.closeIdleConnections - https.Server.prototype.close PR-URL: #58180 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: James M Snell <[email protected]>
aduh95 pushed a commit that referenced this pull request Jun 10, 2025
Affected functions: - http.OutgoingMessage.prototype.cork - http.OutgoingMessage.prototype.uncork - http.Server.prototype.close - http.Server.prototype.closeAllConnections - http.Server.prototype.closeIdleConnections - http.Server.prototype[Symbol.asyncDispose] - http.Server.prototype[nodejs.rejection] - http.validateHeaderName - http.validateHeaderValue - https.Server.prototype.closeAllConnections - https.Server.prototype.closeIdleConnections - https.Server.prototype.close PR-URL: #58180 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, the following functions had either empty string or
wrappedFnas function name: