tools: ignore deps and benchmark folder#58254
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the meta 
benjamingr approved these changes May 10, 2025
Contributor
aduh95 commented May 10, 2025
It'd be less confusing to amend the commit message to say it's CodeQL related |
lpinca approved these changes May 10, 2025
jasnell approved these changes May 12, 2025
aduh95 merged commit 0c78a48 into nodejs:main 17 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Contributor
aduh95 commented May 15, 2025
Landed in 0c78a48 |
targos pushed a commit that referenced this pull request May 16, 2025
PR-URL: #58254 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
aduh95 pushed a commit that referenced this pull request Jun 10, 2025
PR-URL: #58254 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should solve nodejs/security-wg#1453 (comment)
cc: @nodejs/security-wg