Skip to content

buffer: give names to Buffer.prototype.*Write() functions#58258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
May 12, 2025
Merged

buffer: give names to Buffer.prototype.*Write() functions #58258

nodejs-github-bot merged 1 commit into from
May 12, 2025
+3 −3

Conversation

@LiviaMedeiros
Copy link
Member

@LiviaMedeirosLiviaMedeiros commented May 10, 2025

No description provided.

@nodejs-github-botnodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. needs-ci PRs that need a full CI run. labels May 10, 2025
@codecov
Copy link

codecovbot commented May 10, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.18%. Comparing base (dc7ec42) to head (958df92).
Report is 18 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #58258 +/- ## ========================================== - Coverage 90.18% 90.18% -0.01%  ========================================== Files 629 629 Lines 186641 186641 Branches 36654 36658 +4 ========================================== - Hits 168329 168325 -4 - Misses 11112 11121 +9 + Partials 7200 7195 -5
Files with missing linesCoverage Δ
lib/internal/buffer.js98.58% <100.00%> (+0.08%)⬆️

... and 26 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jabari-max

This comment was marked as off-topic.

Sign in to view
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 10, 2025
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 10, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 10, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/66739/

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label May 10, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 12, 2025
@nodejs-github-botnodejs-github-bot merged commit 91d2400 into nodejs:mainMay 12, 2025
73 checks passed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 12, 2025

Landed in 91d2400

targos pushed a commit that referenced this pull request May 16, 2025
@LiviaMedeiros@targos
buffer: give names to Buffer.prototype.*Write() functions
a1b078b
PR-URL: #58258 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jordan Harband <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ulises Gascón <[email protected]>
@github-actionsgithub-actionsbot mentioned this pull request May 20, 2025
Merged
aduh95 pushed a commit that referenced this pull request Jun 10, 2025
@LiviaMedeiros@aduh95
buffer: give names to Buffer.prototype.*Write() functions
b9a16e9
PR-URL: #58258 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jordan Harband <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ulises Gascón <[email protected]>
@github-actionsgithub-actionsbot mentioned this pull request Jun 10, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharbljharbljharb approved these changes

@jasnelljasnelljasnell approved these changes

@lpincalpincalpinca approved these changes

@cjihrigcjihrigcjihrig approved these changes

@UlisesGasconUlisesGasconUlisesGascon approved these changes

@aduh95aduh95aduh95 approved these changes

@RaisinTenRaisinTenRaisinTen approved these changes

+1 more reviewer

@mertcanaltinmertcanaltinmertcanaltin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.bufferIssues and PRs related to the buffer subsystem.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@LiviaMedeiros@jabari-max@nodejs-github-bot@ljharb@jasnell@lpinca@cjihrig@UlisesGascon@aduh95@mertcanaltin@RaisinTen