Skip to content

Conversation

@aduh95
Copy link
Contributor

I was getting error about libuvwasi not found, this patch makes the error go away.

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels May 10, 2025
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 11, 2025
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 11, 2025
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label May 12, 2025
Copy link
Member

@mhdawsonmhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 12, 2025
@nodejs-github-botnodejs-github-bot merged commit 4d71169 into nodejs:mainMay 12, 2025
70 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 4d71169

@aduh95aduh95 deleted the uvwasi branch May 12, 2025 23:43
targos pushed a commit that referenced this pull request May 16, 2025
PR-URL: #58270 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95 added a commit that referenced this pull request Jun 10, 2025
PR-URL: #58270 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@aduh95aduh95 added the lts-watch-v20.x PRs that may need to be released in v20.x label Sep 1, 2025
aduh95 added a commit that referenced this pull request Sep 1, 2025
PR-URL: #58270 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@marco-ippolitomarco-ippolito removed the lts-watch-v20.x PRs that may need to be released in v20.x label Nov 19, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.buildIssues and PRs related to build files or the CI.needs-ciPRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@aduh95@nodejs-github-bot@jasnell@lpinca@anonrig@mhdawson@mertcanaltin@marco-ippolito