Skip to content

Conversation

@erights
Copy link
Contributor

@erightserights commented May 13, 2025

See #43907

@nodejs-github-botnodejs-github-bot added events Issues and PRs related to the events subsystem / EventEmitter. needs-ci PRs that need a full CI run. labels May 13, 2025
@erightserightsforce-pushed the markm-avoid-event-override-by-assignment branch from 3c64785 to 7729c3dCompareMay 13, 2025 18:11
@erightserights changed the title fix: avoid event override by assignmentavoid event override by assignmentMay 13, 2025
@erightserightsforce-pushed the markm-avoid-event-override-by-assignment branch from 7729c3d to a5dce87CompareMay 13, 2025 18:14
@erightserights changed the title avoid event override by assignmentlib: avoid event override by assignmentMay 13, 2025
erightsand others added 4 commits June 18, 2025 17:32
Co-authored-by: Jordan Harband <[email protected]>
Co-authored-by: Jordan Harband <[email protected]>
Co-authored-by: Jordan Harband <[email protected]>
Co-authored-by: Jordan Harband <[email protected]>
Copy link
Member

@ljharbljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this last comment, and with some tests (that install an inherited setter and verify it's not called, and then remove the setter, presumably) this PR LGTM

Co-authored-by: Jordan Harband <[email protected]>
@erightserights marked this pull request as ready for review June 19, 2025 22:31
@codecov
Copy link

codecovbot commented Jun 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.86%. Comparing base (db18bc8) to head (f1958ee).

Additional details and impacted files
@@ Coverage Diff @@## main #58315 +/- ## ========================================== - Coverage 89.87% 89.86% -0.01%  ========================================== Files 656 656 Lines 192956 192993 +37 Branches 37846 37842 -4 ========================================== + Hits 173411 173429 +18 - Misses 12103 12110 +7 - Partials 7442 7454 +12 
Files with missing linesCoverage Δ
lib/events.js99.84% <100.00%> (+0.25%)⬆️

... and 26 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

eventsIssues and PRs related to the events subsystem / EventEmitter.needs-ciPRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@erights@ljharb@nodejs-github-bot